From: Al Viro <viro@zeniv.linux.org.uk>
To: linux-arch@vger.kernel.org
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: [PATCH 2/7] termios: get rid of stray asm/termios.h include in n_hdlc.c
Date: Sat, 20 Aug 2022 04:37:25 +0100 [thread overview]
Message-ID: <20220820033730.1498392-2-viro@zeniv.linux.org.uk> (raw)
In-Reply-To: <20220820033730.1498392-1-viro@zeniv.linux.org.uk>
that's the only one outside of include/uapi/linux/termios.h and it's
not even needed there - we have linux/tty.h already pulled and that
pulls linux/termios.h
Normally I would not consider that a sufficient reason, but there's a
plenty of linux/tty.h users, and this is the only one that follows that
with asm/termios.h. The situation with termios.h is genuinely convoluted,
and this complicates it for no good reason.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
---
drivers/tty/n_hdlc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/tty/n_hdlc.c b/drivers/tty/n_hdlc.c
index 94c1ec2dd754..5540d9be65ea 100644
--- a/drivers/tty/n_hdlc.c
+++ b/drivers/tty/n_hdlc.c
@@ -98,7 +98,6 @@
#include <linux/if.h>
#include <linux/bitops.h>
-#include <asm/termios.h>
#include <linux/uaccess.h>
#include "tty.h"
--
2.30.2
next prev parent reply other threads:[~2022-08-20 3:37 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-20 3:33 [RFC][PATCHES] termios.h cleanups Al Viro
2022-08-20 3:37 ` [PATCH 1/7] loongarch: remove generic-y += termios.h Al Viro
2022-08-20 3:37 ` Al Viro [this message]
2022-08-20 3:37 ` [PATCH 3/7] start unifying INIT_C_CC and termios convertors Al Viro
2022-08-20 3:37 ` [PATCH 4/7] termios: consolidate values for VDISCARD in INIT_C_CC Al Viro
2022-08-20 18:01 ` Linus Torvalds
2022-08-20 18:27 ` Al Viro
2022-08-20 3:37 ` [PATCH 5/7] make generic INIT_C_CC a bit more generic Al Viro
2022-08-20 3:37 ` [PATCH 6/7] termios: convert the last (sparc) INIT_C_CC to array Al Viro
2022-08-20 3:37 ` [PATCH 7/7] termios: get rid of non-UAPI asm/termios.h Al Viro
2022-08-20 18:14 ` [RFC][PATCHES] termios.h cleanups Linus Torvalds
2022-08-20 18:43 ` Al Viro
2022-08-20 21:44 ` Linus Torvalds
2022-08-21 0:30 ` Al Viro
2022-08-21 1:02 ` [PATCH v2 1/8] loongarch: remove generic-y += termios.h Al Viro
2022-08-21 1:02 ` [PATCH v2 2/8] termios: get rid of stray asm/termios.h include in n_hdlc.c Al Viro
2022-08-21 1:02 ` [PATCH v2 3/8] termios: uninline conversion helpers Al Viro
2022-08-30 12:26 ` Greg Kroah-Hartman
2022-09-01 17:03 ` Al Viro
2022-09-01 17:06 ` [PATCH v3 1/6] " Al Viro
2022-09-01 17:06 ` [PATCH v3 2/6] termios: start unifying non-UAPI parts of asm/termios.h Al Viro
2022-09-01 17:07 ` [PATCH v3 3/6] termios: consolidate values for VDISCARD in INIT_C_CC Al Viro
2022-09-01 17:07 ` [PATCH v3 4/6] make generic INIT_C_CC a bit more generic Al Viro
2022-09-01 17:08 ` [PATCH v3 5/6] termios: convert the last (sparc) INIT_C_CC to array Al Viro
2022-09-01 17:08 ` [PATCH v3 6/6] termios: get rid of non-UAPI asm/termios.h Al Viro
2022-09-02 5:32 ` [PATCH v3 7/6] termios: kill uapi termios.h that are identical to generic one Al Viro
2022-09-09 8:45 ` [PATCH v2 3/8] termios: uninline conversion helpers Greg Kroah-Hartman
2022-08-21 1:02 ` [PATCH v2 4/8] termios: start unifying non-UAPI parts of asm/termios.h Al Viro
2022-08-21 5:13 ` Al Viro
2022-08-21 1:02 ` [PATCH v2 5/8] termios: consolidate values for VDISCARD in INIT_C_CC Al Viro
2022-08-21 1:02 ` [PATCH v2 6/8] make generic INIT_C_CC a bit more generic Al Viro
2022-08-21 1:02 ` [PATCH v2 7/8] termios: convert the last (sparc) INIT_C_CC to array Al Viro
2022-08-21 1:02 ` [PATCH v2 8/8] termios: get rid of non-UAPI asm/termios.h Al Viro
2022-08-21 14:56 ` [PATCH v2 1/8] loongarch: remove generic-y += termios.h Huacai Chen
2022-08-21 14:58 ` Huacai Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220820033730.1498392-2-viro@zeniv.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).