From: Lukas Wunner <lukas@wunner.de>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: linux-serial@vger.kernel.org,
"Greg KH" <gregkh@linuxfoundation.org>,
"Jiri Slaby" <jirislaby@kernel.org>,
"Jonathan Corbet" <corbet@lwn.net>,
"Arnd Bergmann" <arnd@arndb.de>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arch@vger.kernel.org,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Lino Sanfilippo" <LinoSanfilippo@gmx.de>,
linux-api@vger.kernel.org
Subject: Re: [PATCH v9 5/6] serial: Support for RS-485 multipoint addresses
Date: Tue, 20 Sep 2022 13:20:11 +0200 [thread overview]
Message-ID: <20220920112011.GA7187@wunner.de> (raw)
In-Reply-To: <20220624204210.11112-6-ilpo.jarvinen@linux.intel.com>
On Fri, Jun 24, 2022 at 11:42:09PM +0300, Ilpo Järvinen wrote:
> ADDRB in termios indicates 9th bit addressing mode is enabled. In this
> mode, 9th bit is used to indicate an address (byte) within the
> communication line. ADDRB can only be enabled/disabled through
> ->rs485_config() that is also responsible for setting the destination and
> receiver (filter) addresses.
[...]
> --- a/include/uapi/asm-generic/termbits-common.h
> +++ b/include/uapi/asm-generic/termbits-common.h
> @@ -46,6 +46,7 @@ typedef unsigned int speed_t;
> #define EXTA B19200
> #define EXTB B38400
>
> +#define ADDRB 0x20000000 /* address bit */
> #define CMSPAR 0x40000000 /* mark or space (stick) parity */
> #define CRTSCTS 0x80000000 /* flow control */
>
You may want to consider submitting a patch to the Linux man-pages
project to document the newly introduced bit:
https://www.kernel.org/doc/man-pages/patches.html
https://git.kernel.org/pub/scm/docs/man-pages/man-pages.git/tree/man3/termios.3
Thanks,
Lukas
prev parent reply other threads:[~2022-09-20 11:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-24 20:42 [PATCH v9 0/6] Add RS485 9th bit addressing mode support to DW UART Ilpo Järvinen
2022-06-24 20:42 ` [PATCH v9 5/6] serial: Support for RS-485 multipoint addresses Ilpo Järvinen
2022-09-20 11:20 ` Lukas Wunner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220920112011.GA7187@wunner.de \
--to=lukas@wunner.de \
--cc=LinoSanfilippo@gmx.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=corbet@lwn.net \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).