linux-arch.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Baoquan He <bhe@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: linux-arch@vger.kernel.org, linux-mm@kvack.org, arnd@arndb.de,
	christophe.leroy@csgroup.eu, hch@infradead.org,
	agordeev@linux.ibm.com, wangkefeng.wang@huawei.com,
	schnelle@linux.ibm.com, David.Laight@ACULAB.COM,
	shorne@gmail.com, willy@infradead.org, deller@gmx.de,
	Baoquan He <bhe@redhat.com>, Jonas Bonn <jonas@southpole.se>,
	Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>,
	openrisc@lists.librecores.org
Subject: [PATCH v5 RESEND 09/17] openrisc: mm: Convert to GENERIC_IOREMAP
Date: Mon, 15 May 2023 17:08:40 +0800	[thread overview]
Message-ID: <20230515090848.833045-10-bhe@redhat.com> (raw)
In-Reply-To: <20230515090848.833045-1-bhe@redhat.com>

By taking GENERIC_IOREMAP method, the generic generic_ioremap_prot(),
generic_iounmap(), and their generic wrapper ioremap_prot(), ioremap()
and iounmap() are all visible and available to arch. Arch needs to
provide wrapper functions to override the generic versions if there's
arch specific handling in its ioremap_prot(), ioremap() or iounmap().
This change will simplify implementation by removing duplicated codes
with generic_ioremap_prot() and generic_iounmap(), and has the equivalent
functioality as before.

Here, add wrapper function iounmap() for openrisc's special operation
when iounmap().

Signed-off-by: Baoquan He <bhe@redhat.com>
Cc: Stafford Horne <shorne@gmail.com>
Cc: Jonas Bonn <jonas@southpole.se>
Cc: Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>
Cc: openrisc@lists.librecores.org
---
 arch/openrisc/Kconfig          |  1 +
 arch/openrisc/include/asm/io.h | 11 +++++---
 arch/openrisc/mm/ioremap.c     | 46 +---------------------------------
 3 files changed, 9 insertions(+), 49 deletions(-)

diff --git a/arch/openrisc/Kconfig b/arch/openrisc/Kconfig
index c7f282f60f64..fd9bb76a610b 100644
--- a/arch/openrisc/Kconfig
+++ b/arch/openrisc/Kconfig
@@ -21,6 +21,7 @@ config OPENRISC
 	select GENERIC_IRQ_PROBE
 	select GENERIC_IRQ_SHOW
 	select GENERIC_PCI_IOMAP
+	select GENERIC_IOREMAP
 	select GENERIC_CPU_DEVICES
 	select HAVE_PCI
 	select HAVE_UID16
diff --git a/arch/openrisc/include/asm/io.h b/arch/openrisc/include/asm/io.h
index ee6043a03173..e640960c26c2 100644
--- a/arch/openrisc/include/asm/io.h
+++ b/arch/openrisc/include/asm/io.h
@@ -15,6 +15,8 @@
 #define __ASM_OPENRISC_IO_H
 
 #include <linux/types.h>
+#include <asm/pgalloc.h>
+#include <asm/pgtable.h>
 
 /*
  * PCI: We do not use IO ports in OpenRISC
@@ -27,11 +29,12 @@
 #define PIO_OFFSET		0
 #define PIO_MASK		0
 
-#define ioremap ioremap
-void __iomem *ioremap(phys_addr_t offset, unsigned long size);
-
+/*
+ * I/O memory mapping functions.
+ */
 #define iounmap iounmap
-extern void iounmap(volatile void __iomem *addr);
+
+#define _PAGE_IOREMAP (pgprot_val(PAGE_KERNEL) | _PAGE_CI)
 
 #include <asm-generic/io.h>
 
diff --git a/arch/openrisc/mm/ioremap.c b/arch/openrisc/mm/ioremap.c
index 90b59bc53c8c..9f9941df7d4c 100644
--- a/arch/openrisc/mm/ioremap.c
+++ b/arch/openrisc/mm/ioremap.c
@@ -22,49 +22,6 @@
 
 extern int mem_init_done;
 
-/*
- * Remap an arbitrary physical address space into the kernel virtual
- * address space. Needed when the kernel wants to access high addresses
- * directly.
- *
- * NOTE! We need to allow non-page-aligned mappings too: we will obviously
- * have to convert them into an offset in a page-aligned mapping, but the
- * caller shouldn't need to know that small detail.
- */
-void __iomem *__ref ioremap(phys_addr_t addr, unsigned long size)
-{
-	phys_addr_t p;
-	unsigned long v;
-	unsigned long offset, last_addr;
-	struct vm_struct *area = NULL;
-
-	/* Don't allow wraparound or zero size */
-	last_addr = addr + size - 1;
-	if (!size || last_addr < addr)
-		return NULL;
-
-	/*
-	 * Mappings have to be page-aligned
-	 */
-	offset = addr & ~PAGE_MASK;
-	p = addr & PAGE_MASK;
-	size = PAGE_ALIGN(last_addr + 1) - p;
-
-	area = get_vm_area(size, VM_IOREMAP);
-	if (!area)
-		return NULL;
-	v = (unsigned long)area->addr;
-
-	if (ioremap_page_range(v, v + size, p,
-			__pgprot(pgprot_val(PAGE_KERNEL) | _PAGE_CI))) {
-		vfree(area->addr);
-		return NULL;
-	}
-
-	return (void __iomem *)(offset + (char *)v);
-}
-EXPORT_SYMBOL(ioremap);
-
 void iounmap(volatile void __iomem *addr)
 {
 	/* If the page is from the fixmap pool then we just clear out
@@ -88,9 +45,8 @@ void iounmap(volatile void __iomem *addr)
 		return;
 	}
 
-	return vfree((void *)(PAGE_MASK & (unsigned long)addr));
+	generic_iounmap(addr);
 }
-EXPORT_SYMBOL(iounmap);
 
 /**
  * OK, this one's a bit tricky... ioremap can get called before memory is
-- 
2.34.1


  parent reply	other threads:[~2023-05-15  9:12 UTC|newest]

Thread overview: 77+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-15  9:08 [PATCH v5 RESEND 00/17] mm: ioremap: Convert architectures to take GENERIC_IOREMAP way Baoquan He
2023-05-15  9:08 ` [PATCH v5 RESEND 01/17] asm-generic/iomap.h: remove ARCH_HAS_IOREMAP_xx macros Baoquan He
2023-05-16  6:15   ` Mike Rapoport
2023-05-16 12:54     ` Baoquan He
2023-05-16  7:07   ` Geert Uytterhoeven
2023-05-17  6:27   ` Christoph Hellwig
2023-05-15  9:08 ` [PATCH v5 RESEND 02/17] hexagon: mm: Convert to GENERIC_IOREMAP Baoquan He
2023-05-16  6:17   ` Mike Rapoport
2023-05-17  6:27   ` Christoph Hellwig
2023-05-15  9:08 ` [PATCH v5 RESEND 03/17] openrisc: mm: remove unneeded early ioremap code Baoquan He
2023-05-16  6:17   ` Mike Rapoport
2023-05-16 13:03     ` Baoquan He
2023-05-17  6:28   ` Christoph Hellwig
2023-05-15  9:08 ` [PATCH v5 RESEND 04/17] mm/ioremap: Define generic_ioremap_prot() and generic_iounmap() Baoquan He
2023-05-16  6:17   ` Mike Rapoport
2023-05-17  6:29   ` Christoph Hellwig
2023-05-18  3:38     ` Baoquan He
2023-05-18  1:56   ` Kefeng Wang
2023-05-15  9:08 ` [PATCH v5 RESEND 05/17] mm: ioremap: allow ARCH to have its own ioremap method definition Baoquan He
2023-05-16  6:48   ` Mike Rapoport
2023-05-17  6:30   ` Christoph Hellwig
2023-05-18  1:56   ` Kefeng Wang
2023-05-15  9:08 ` [PATCH v5 RESEND 06/17] mm/ioremap: add slab availability checking in ioremap_prot Baoquan He
2023-05-16  6:48   ` Mike Rapoport
2023-05-17  6:30   ` Christoph Hellwig
2023-05-18  3:43     ` Baoquan He
2023-05-18  1:57   ` Kefeng Wang
2023-05-15  9:08 ` [PATCH v5 RESEND 07/17] arc: mm: Convert to GENERIC_IOREMAP Baoquan He
2023-05-16  6:49   ` Mike Rapoport
2023-05-17  6:31   ` Christoph Hellwig
2023-05-18  3:43     ` Baoquan He
2023-05-30  9:25     ` Baoquan He
2023-06-01 11:14       ` Christoph Hellwig
2023-05-15  9:08 ` [PATCH v5 RESEND 08/17] ia64: " Baoquan He
2023-05-16  6:49   ` Mike Rapoport
2023-05-17  6:33   ` Christoph Hellwig
2023-05-18  3:44     ` Baoquan He
2023-05-15  9:08 ` Baoquan He [this message]
2023-05-16  6:49   ` [PATCH v5 RESEND 09/17] openrisc: " Mike Rapoport
2023-05-16 13:05     ` Baoquan He
2023-05-15  9:08 ` [PATCH v5 RESEND 10/17] s390: " Baoquan He
2023-05-16  6:50   ` Mike Rapoport
2023-05-17  6:36   ` Christoph Hellwig
2023-05-17  7:58     ` Niklas Schnelle
2023-05-17  8:08       ` Christoph Hellwig
2023-05-15  9:08 ` [PATCH v5 RESEND 11/17] sh: " Baoquan He
2023-05-17  6:37   ` Christoph Hellwig
2023-05-18  3:45     ` Baoquan He
2023-05-15  9:08 ` [PATCH v5 RESEND 12/17] xtensa: " Baoquan He
2023-05-16  6:51   ` Mike Rapoport
2023-05-17  6:38   ` Christoph Hellwig
2023-05-15  9:08 ` [PATCH v5 RESEND 13/17] parisc: " Baoquan He
2023-05-16  6:52   ` Mike Rapoport
2023-05-16 13:07     ` Baoquan He
2023-05-17  6:38   ` Christoph Hellwig
2023-05-15  9:08 ` [PATCH v5 RESEND 14/17] mm/ioremap: Consider IOREMAP space in generic ioremap Baoquan He
2023-05-16  6:53   ` Mike Rapoport
2023-05-17  6:41   ` Christoph Hellwig
2023-05-17  6:44     ` Christoph Hellwig
2023-05-20  3:31       ` Baoquan He
2023-05-20  5:04         ` Christoph Hellwig
2023-05-30  9:37       ` Baoquan He
2023-06-01 11:13         ` Christoph Hellwig
2023-06-02 10:42           ` Baoquan He
2023-06-02 15:05             ` Christoph Hellwig
2023-05-20  3:28     ` Baoquan He
2023-05-15  9:08 ` [PATCH v5 RESEND 15/17] powerpc: mm: Convert to GENERIC_IOREMAP Baoquan He
2023-05-16  7:00   ` Mike Rapoport
2023-05-17  6:42   ` Christoph Hellwig
2023-05-15  9:08 ` [PATCH v5 RESEND 16/17] arm64 : mm: add wrapper function ioremap_prot() Baoquan He
2023-05-16  7:02   ` Mike Rapoport
2023-05-17  6:42   ` Christoph Hellwig
2023-05-18  1:58   ` Kefeng Wang
2023-05-15  9:08 ` [PATCH v5 RESEND 17/17] mm: ioremap: remove unneeded ioremap_allowed and iounmap_allowed Baoquan He
2023-05-16  7:02   ` Mike Rapoport
2023-05-17  6:43   ` Christoph Hellwig
2023-05-18  1:58   ` Kefeng Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230515090848.833045-10-bhe@redhat.com \
    --to=bhe@redhat.com \
    --cc=David.Laight@ACULAB.COM \
    --cc=agordeev@linux.ibm.com \
    --cc=arnd@arndb.de \
    --cc=christophe.leroy@csgroup.eu \
    --cc=deller@gmx.de \
    --cc=hch@infradead.org \
    --cc=jonas@southpole.se \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=openrisc@lists.librecores.org \
    --cc=schnelle@linux.ibm.com \
    --cc=shorne@gmail.com \
    --cc=stefan.kristiansson@saunalahti.fi \
    --cc=wangkefeng.wang@huawei.com \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).