From: Baoquan He <bhe@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: linux-arch@vger.kernel.org, linux-mm@kvack.org, arnd@arndb.de,
christophe.leroy@csgroup.eu, hch@infradead.org,
agordeev@linux.ibm.com, wangkefeng.wang@huawei.com,
schnelle@linux.ibm.com, David.Laight@ACULAB.COM,
shorne@gmail.com, willy@infradead.org, deller@gmx.de,
Baoquan He <bhe@redhat.com>
Subject: [PATCH v5 RESEND 04/17] mm/ioremap: Define generic_ioremap_prot() and generic_iounmap()
Date: Mon, 15 May 2023 17:08:35 +0800 [thread overview]
Message-ID: <20230515090848.833045-5-bhe@redhat.com> (raw)
In-Reply-To: <20230515090848.833045-1-bhe@redhat.com>
From: Christophe Leroy <christophe.leroy@csgroup.eu>
Define a generic version of ioremap_prot() and iounmap() that
architectures can call after they have performed the necessary
alteration to parameters and/or necessary verifications.
Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
Signed-off-by: Baoquan He <bhe@redhat.com>
---
include/asm-generic/io.h | 4 ++++
mm/ioremap.c | 22 ++++++++++++++++------
2 files changed, 20 insertions(+), 6 deletions(-)
diff --git a/include/asm-generic/io.h b/include/asm-generic/io.h
index 587e7e9b9a37..a7ca2099ba19 100644
--- a/include/asm-generic/io.h
+++ b/include/asm-generic/io.h
@@ -1073,9 +1073,13 @@ static inline bool iounmap_allowed(void *addr)
}
#endif
+void __iomem *generic_ioremap_prot(phys_addr_t phys_addr, size_t size,
+ pgprot_t prot);
+
void __iomem *ioremap_prot(phys_addr_t phys_addr, size_t size,
unsigned long prot);
void iounmap(volatile void __iomem *addr);
+void generic_iounmap(volatile void __iomem *addr);
static inline void __iomem *ioremap(phys_addr_t addr, size_t size)
{
diff --git a/mm/ioremap.c b/mm/ioremap.c
index 8652426282cc..db6234b9db59 100644
--- a/mm/ioremap.c
+++ b/mm/ioremap.c
@@ -11,8 +11,8 @@
#include <linux/io.h>
#include <linux/export.h>
-void __iomem *ioremap_prot(phys_addr_t phys_addr, size_t size,
- unsigned long prot)
+void __iomem *generic_ioremap_prot(phys_addr_t phys_addr, size_t size,
+ pgprot_t prot)
{
unsigned long offset, vaddr;
phys_addr_t last_addr;
@@ -28,7 +28,7 @@ void __iomem *ioremap_prot(phys_addr_t phys_addr, size_t size,
phys_addr -= offset;
size = PAGE_ALIGN(size + offset);
- if (!ioremap_allowed(phys_addr, size, prot))
+ if (!ioremap_allowed(phys_addr, size, pgprot_val(prot)))
return NULL;
area = get_vm_area_caller(size, VM_IOREMAP,
@@ -38,17 +38,22 @@ void __iomem *ioremap_prot(phys_addr_t phys_addr, size_t size,
vaddr = (unsigned long)area->addr;
area->phys_addr = phys_addr;
- if (ioremap_page_range(vaddr, vaddr + size, phys_addr,
- __pgprot(prot))) {
+ if (ioremap_page_range(vaddr, vaddr + size, phys_addr, prot)) {
free_vm_area(area);
return NULL;
}
return (void __iomem *)(vaddr + offset);
}
+
+void __iomem *ioremap_prot(phys_addr_t phys_addr, size_t size,
+ unsigned long prot)
+{
+ return generic_ioremap_prot(phys_addr, size, __pgprot(prot));
+}
EXPORT_SYMBOL(ioremap_prot);
-void iounmap(volatile void __iomem *addr)
+void generic_iounmap(volatile void __iomem *addr)
{
void *vaddr = (void *)((unsigned long)addr & PAGE_MASK);
@@ -58,4 +63,9 @@ void iounmap(volatile void __iomem *addr)
if (is_vmalloc_addr(vaddr))
vunmap(vaddr);
}
+
+void iounmap(volatile void __iomem *addr)
+{
+ generic_iounmap(addr);
+}
EXPORT_SYMBOL(iounmap);
--
2.34.1
next prev parent reply other threads:[~2023-05-15 9:11 UTC|newest]
Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-15 9:08 [PATCH v5 RESEND 00/17] mm: ioremap: Convert architectures to take GENERIC_IOREMAP way Baoquan He
2023-05-15 9:08 ` [PATCH v5 RESEND 01/17] asm-generic/iomap.h: remove ARCH_HAS_IOREMAP_xx macros Baoquan He
2023-05-16 6:15 ` Mike Rapoport
2023-05-16 12:54 ` Baoquan He
2023-05-16 7:07 ` Geert Uytterhoeven
2023-05-17 6:27 ` Christoph Hellwig
2023-05-15 9:08 ` [PATCH v5 RESEND 02/17] hexagon: mm: Convert to GENERIC_IOREMAP Baoquan He
2023-05-16 6:17 ` Mike Rapoport
2023-05-17 6:27 ` Christoph Hellwig
2023-05-15 9:08 ` [PATCH v5 RESEND 03/17] openrisc: mm: remove unneeded early ioremap code Baoquan He
2023-05-16 6:17 ` Mike Rapoport
2023-05-16 13:03 ` Baoquan He
2023-05-17 6:28 ` Christoph Hellwig
2023-05-15 9:08 ` Baoquan He [this message]
2023-05-16 6:17 ` [PATCH v5 RESEND 04/17] mm/ioremap: Define generic_ioremap_prot() and generic_iounmap() Mike Rapoport
2023-05-17 6:29 ` Christoph Hellwig
2023-05-18 3:38 ` Baoquan He
2023-05-18 1:56 ` Kefeng Wang
2023-05-15 9:08 ` [PATCH v5 RESEND 05/17] mm: ioremap: allow ARCH to have its own ioremap method definition Baoquan He
2023-05-16 6:48 ` Mike Rapoport
2023-05-17 6:30 ` Christoph Hellwig
2023-05-18 1:56 ` Kefeng Wang
2023-05-15 9:08 ` [PATCH v5 RESEND 06/17] mm/ioremap: add slab availability checking in ioremap_prot Baoquan He
2023-05-16 6:48 ` Mike Rapoport
2023-05-17 6:30 ` Christoph Hellwig
2023-05-18 3:43 ` Baoquan He
2023-05-18 1:57 ` Kefeng Wang
2023-05-15 9:08 ` [PATCH v5 RESEND 07/17] arc: mm: Convert to GENERIC_IOREMAP Baoquan He
2023-05-16 6:49 ` Mike Rapoport
2023-05-17 6:31 ` Christoph Hellwig
2023-05-18 3:43 ` Baoquan He
2023-05-30 9:25 ` Baoquan He
2023-06-01 11:14 ` Christoph Hellwig
2023-05-15 9:08 ` [PATCH v5 RESEND 08/17] ia64: " Baoquan He
2023-05-16 6:49 ` Mike Rapoport
2023-05-17 6:33 ` Christoph Hellwig
2023-05-18 3:44 ` Baoquan He
2023-05-15 9:08 ` [PATCH v5 RESEND 09/17] openrisc: " Baoquan He
2023-05-16 6:49 ` Mike Rapoport
2023-05-16 13:05 ` Baoquan He
2023-05-15 9:08 ` [PATCH v5 RESEND 10/17] s390: " Baoquan He
2023-05-16 6:50 ` Mike Rapoport
2023-05-17 6:36 ` Christoph Hellwig
2023-05-17 7:58 ` Niklas Schnelle
2023-05-17 8:08 ` Christoph Hellwig
2023-05-15 9:08 ` [PATCH v5 RESEND 11/17] sh: " Baoquan He
2023-05-17 6:37 ` Christoph Hellwig
2023-05-18 3:45 ` Baoquan He
2023-05-15 9:08 ` [PATCH v5 RESEND 12/17] xtensa: " Baoquan He
2023-05-16 6:51 ` Mike Rapoport
2023-05-17 6:38 ` Christoph Hellwig
2023-05-15 9:08 ` [PATCH v5 RESEND 13/17] parisc: " Baoquan He
2023-05-16 6:52 ` Mike Rapoport
2023-05-16 13:07 ` Baoquan He
2023-05-17 6:38 ` Christoph Hellwig
2023-05-15 9:08 ` [PATCH v5 RESEND 14/17] mm/ioremap: Consider IOREMAP space in generic ioremap Baoquan He
2023-05-16 6:53 ` Mike Rapoport
2023-05-17 6:41 ` Christoph Hellwig
2023-05-17 6:44 ` Christoph Hellwig
2023-05-20 3:31 ` Baoquan He
2023-05-20 5:04 ` Christoph Hellwig
2023-05-30 9:37 ` Baoquan He
2023-06-01 11:13 ` Christoph Hellwig
2023-06-02 10:42 ` Baoquan He
2023-06-02 15:05 ` Christoph Hellwig
2023-05-20 3:28 ` Baoquan He
2023-05-15 9:08 ` [PATCH v5 RESEND 15/17] powerpc: mm: Convert to GENERIC_IOREMAP Baoquan He
2023-05-16 7:00 ` Mike Rapoport
2023-05-17 6:42 ` Christoph Hellwig
2023-05-15 9:08 ` [PATCH v5 RESEND 16/17] arm64 : mm: add wrapper function ioremap_prot() Baoquan He
2023-05-16 7:02 ` Mike Rapoport
2023-05-17 6:42 ` Christoph Hellwig
2023-05-18 1:58 ` Kefeng Wang
2023-05-15 9:08 ` [PATCH v5 RESEND 17/17] mm: ioremap: remove unneeded ioremap_allowed and iounmap_allowed Baoquan He
2023-05-16 7:02 ` Mike Rapoport
2023-05-17 6:43 ` Christoph Hellwig
2023-05-18 1:58 ` Kefeng Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230515090848.833045-5-bhe@redhat.com \
--to=bhe@redhat.com \
--cc=David.Laight@ACULAB.COM \
--cc=agordeev@linux.ibm.com \
--cc=arnd@arndb.de \
--cc=christophe.leroy@csgroup.eu \
--cc=deller@gmx.de \
--cc=hch@infradead.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=schnelle@linux.ibm.com \
--cc=shorne@gmail.com \
--cc=wangkefeng.wang@huawei.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).