From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9765C001DC for ; Fri, 14 Jul 2023 15:26:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235256AbjGNP03 (ORCPT ); Fri, 14 Jul 2023 11:26:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49970 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233758AbjGNP02 (ORCPT ); Fri, 14 Jul 2023 11:26:28 -0400 Received: from desiato.infradead.org (desiato.infradead.org [IPv6:2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 360CF1BD4; Fri, 14 Jul 2023 08:26:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=PW9O2dLBokh6X5owFYBB430L2RtltUnavOejKbrhHjw=; b=ZCqnWZPYXmbMaF2DqtjhPvKQ16 J6Rf7d1jC7H8suBMEHYrmniHqFcRDiN81vJ+fM+fZ44fBnZoyWOon1gXoAYlnXdA/ECLmmxNuY4WV 62sOQXTtVigQ8wLY3D0NVG0xH4CVDxDfsCllPO3D3yGJtZJdlrniuicm0VKq4iyjDoK5D3RJOhElb VbnBr3WMk2arYGI937L8JNlvR/ykRURCEgX/HMQeZONb5WG5HVLzggQ9rQAC+qUXdKVB6IR61SH/h r2AgXVtnjROhAYpz23dCq/AWZzC/2MA3iEQeRhKGbhF9Sy+HCxb0oAQ5l0wP2YOF2irmmw/uTjpzF Scb8Pkkw==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1qKKgR-006JOI-2P; Fri, 14 Jul 2023 15:26:16 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 5638A3001E7; Fri, 14 Jul 2023 17:26:15 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 3EF2121372896; Fri, 14 Jul 2023 17:26:15 +0200 (CEST) Date: Fri, 14 Jul 2023 17:26:15 +0200 From: Peter Zijlstra To: Matthew Wilcox Cc: tglx@linutronix.de, axboe@kernel.dk, linux-kernel@vger.kernel.org, mingo@redhat.com, dvhart@infradead.org, dave@stgolabs.net, andrealmeid@igalia.com, Andrew Morton , urezki@gmail.com, hch@infradead.org, lstoakes@gmail.com, Arnd Bergmann , linux-api@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, malteskarupke@web.de Subject: Re: [RFC][PATCH 05/10] mm: Add vmalloc_huge_node() Message-ID: <20230714152615.GE3261758@hirez.programming.kicks-ass.net> References: <20230714133859.305719029@infradead.org> <20230714141218.947137012@infradead.org> <20230714150948.GC3261758@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-arch@vger.kernel.org On Fri, Jul 14, 2023 at 04:11:39PM +0100, Matthew Wilcox wrote: > ... or just don't change vmalloc_huge()? Yeah, that, everything else just adds more lines without read benefit. I eneded up with the below. --- a/include/linux/vmalloc.h +++ b/include/linux/vmalloc.h @@ -152,6 +152,7 @@ extern void *__vmalloc_node_range(unsign void *__vmalloc_node(unsigned long size, unsigned long align, gfp_t gfp_mask, int node, const void *caller) __alloc_size(1); void *vmalloc_huge(unsigned long size, gfp_t gfp_mask) __alloc_size(1); +void *vmalloc_huge_node(unsigned long size, gfp_t gfp_mask, int node) __alloc_size(1); extern void *__vmalloc_array(size_t n, size_t size, gfp_t flags) __alloc_size(1, 2); extern void *vmalloc_array(size_t n, size_t size) __alloc_size(1, 2); --- a/mm/vmalloc.c +++ b/mm/vmalloc.c @@ -3416,6 +3416,13 @@ void *vmalloc(unsigned long size) } EXPORT_SYMBOL(vmalloc); +void *vmalloc_huge_node(unsigned long size, gfp_t gfp_mask, int node) +{ + return __vmalloc_node_range(size, 1, VMALLOC_START, VMALLOC_END, + gfp_mask, PAGE_KERNEL, VM_ALLOW_HUGE_VMAP, + node, __builtin_return_address(0)); +} + /** * vmalloc_huge - allocate virtually contiguous memory, allow huge pages * @size: allocation size