From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67F8CC001DE for ; Sat, 15 Jul 2023 14:19:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229974AbjGOOTl (ORCPT ); Sat, 15 Jul 2023 10:19:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44082 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229919AbjGOOTk (ORCPT ); Sat, 15 Jul 2023 10:19:40 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DEC1B1BDA; Sat, 15 Jul 2023 07:19:38 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6E4AF60A26; Sat, 15 Jul 2023 14:19:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5476CC433C8; Sat, 15 Jul 2023 14:19:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1689430777; bh=+Zc6MkX4Je1o4oRfyxtSq9WhWkGFgbpOiD6Q71QeBYI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Zy3rfFDF9/RcEDqv/V++Mi0WYdWrN0WzDeIRaOAJtqNziHBGyxmQCrOpfIJF193ZZ SKIEF2VT9uOU3GbnWIiyD2NLSdjwASvzp6befCgGeHVVK+/oBns/kK6RspFIzyOxZ5 BK1HNxTZ1+H1pH/VVp3C7+hLEHvSf9B2R5sKe7uM= Date: Sat, 15 Jul 2023 16:19:33 +0200 From: Greg KH To: guoren@kernel.org Cc: palmer@rivosinc.com, paul.walmsley@sifive.com, falcon@tinylab.org, bjorn@kernel.org, conor.dooley@microchip.com, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, stable@vger.kernel.org, Guo Ren Subject: Re: [PATCH 2/2] riscv: stack: Fixup independent softirq stack for CONFIG_FRAME_POINTER=n Message-ID: <2023071528-traverse-parting-14b2@gregkh> References: <20230715134552.3437933-1-guoren@kernel.org> <20230715134552.3437933-3-guoren@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230715134552.3437933-3-guoren@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-arch@vger.kernel.org On Sat, Jul 15, 2023 at 09:45:52AM -0400, guoren@kernel.org wrote: > From: Guo Ren > > The independent softirq stack uses s0 to save & restore sp, but s0 would > be corrupted when CONFIG_FRAME_POINTER=n. So add s0 in the clobber list > to fix the problem. > > Fixes: dd69d07a5a6c ("riscv: stack: Support HAVE_SOFTIRQ_ON_OWN_STACK") > Reported-by: Zhangjin Wu > Signed-off-by: Guo Ren > Signed-off-by: Guo Ren > --- > arch/riscv/kernel/irq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/riscv/kernel/irq.c b/arch/riscv/kernel/irq.c > index d0577cc6a081..0b58720109db 100644 > --- a/arch/riscv/kernel/irq.c > +++ b/arch/riscv/kernel/irq.c > @@ -83,7 +83,7 @@ void do_softirq_own_stack(void) > : > : [sp] "r" (sp) > : "a0", "a1", "a2", "a3", "a4", "a5", "a6", "a7", > - "t0", "t1", "t2", "t3", "t4", "t5", "t6", > + "t0", "t1", "t2", "t3", "t4", "t5", "t6", "s0", > "memory"); > } else > #endif > -- > 2.36.1 > This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html for how to do this properly.