From: James Morse <james.morse@arm.com>
To: linux-pm@vger.kernel.org, loongarch@lists.linux.dev,
linux-acpi@vger.kernel.org, linux-arch@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-riscv@lists.infradead.org, kvmarm@lists.linux.dev
Cc: x86@kernel.org, Salil Mehta <salil.mehta@huawei.com>,
Russell King <linux@armlinux.org.uk>,
Jean-Philippe Brucker <jean-philippe@linaro.org>,
jianyong.wu@arm.com, justin.he@arm.com
Subject: [RFC PATCH v2 02/35] drivers: base: Use present CPUs in GENERIC_CPU_DEVICES
Date: Wed, 13 Sep 2023 16:37:50 +0000 [thread overview]
Message-ID: <20230913163823.7880-3-james.morse@arm.com> (raw)
In-Reply-To: <20230913163823.7880-1-james.morse@arm.com>
Three of the five ACPI architectures create sysfs entries using
register_cpu() for present CPUs, whereas arm64, riscv and all
GENERIC_CPU_DEVICES do this for possible CPUs.
Registering a CPU is what causes them to show up in sysfs.
It makes very little sense to register all possible CPUs. Registering
a CPU is what triggers the udev notifications allowing user-space to
react to newly added CPUs.
To allow all five ACPI architectures to use GENERIC_CPU_DEVICES, change
it to use for_each_present_cpu(). Making the ACPI architectures use
GENERIC_CPU_DEVICES is a pre-requisite step to centralise their
cpu_register() logic, before moving it into the ACPI processor driver.
When ACPI is disabled this work would be done by
cpu_dev_register_generic().
Of the ACPI architectures that register possible CPUs, arm64 and riscv
do not support making possible CPUs present as they use the weak 'always
fails' version of arch_register_cpu().
Only two of the eight architectures that use GENERIC_CPU_DEVICES have a
distinction between present and possible CPUs.
The following architectures use GENERIC_CPU_DEVICES but are not SMP,
so possible == present:
* m68k
* microblaze
* nios2
The following architectures use GENERIC_CPU_DEVICES and consider
possible == present:
* csky: setup_smp()
* parisc: smp_prepare_boot_cpu() marks the boot cpu as present,
processor_probe() sets possible for all CPUs and present for all CPUs
except the boot cpu.
um appears to be a subarchitecture of x86.
The remaining architecture using GENERIC_CPU_DEVICES are:
* openrisc and hexagon:
where smp_init_cpus() makes all CPUs < NR_CPUS possible,
whereas smp_prepare_cpus() only makes CPUs < setup_max_cpus present.
After this change, openrisc and hexagon systems that use the max_cpus
command line argument would not see the other CPUs present in sysfs.
This should not be a problem as these CPUs can't bre brought online as
_cpu_up() checks cpu_present().
After this change, only CPUs which are present appear in sysfs.
Signed-off-by: James Morse <james.morse@arm.com>
---
drivers/base/cpu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/base/cpu.c b/drivers/base/cpu.c
index 9ea22e165acd..34b48f660b6b 100644
--- a/drivers/base/cpu.c
+++ b/drivers/base/cpu.c
@@ -533,7 +533,7 @@ static void __init cpu_dev_register_generic(void)
#ifdef CONFIG_GENERIC_CPU_DEVICES
int i;
- for_each_possible_cpu(i) {
+ for_each_present_cpu(i) {
if (register_cpu(&per_cpu(cpu_devices, i), i))
panic("Failed to register CPU device");
}
--
2.39.2
next prev parent reply other threads:[~2023-09-13 16:39 UTC|newest]
Thread overview: 152+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-13 16:37 [RFC PATCH v2 00/35] ACPI/arm64: add support for virtual cpuhotplug James Morse
2023-09-13 16:37 ` [RFC PATCH v2 01/35] ACPI: Move ACPI_HOTPLUG_CPU to be disabled on arm64 and riscv James Morse
2023-09-14 8:54 ` Russell King (Oracle)
2023-09-13 16:37 ` James Morse [this message]
2023-09-14 8:20 ` [RFC PATCH v2 02/35] drivers: base: Use present CPUs in GENERIC_CPU_DEVICES Russell King (Oracle)
2023-09-14 10:56 ` Jonathan Cameron
2023-09-14 11:11 ` Russell King (Oracle)
2023-09-14 10:56 ` Jonathan Cameron
2023-09-13 16:37 ` [RFC PATCH v2 03/35] drivers: base: Allow parts of GENERIC_CPU_DEVICES to be overridden James Morse
2023-09-14 8:33 ` Russell King (Oracle)
2023-09-14 11:00 ` Jonathan Cameron
2023-09-14 11:05 ` Jonathan Cameron
2023-09-13 16:37 ` [RFC PATCH v2 04/35] drivers: base: Move cpu_dev_init() after node_dev_init() James Morse
2023-09-14 9:40 ` Russell King (Oracle)
2023-09-14 11:16 ` Jonathan Cameron
2023-09-13 16:37 ` [RFC PATCH v2 05/35] drivers: base: Print a warning instead of panic() when register_cpu() fails James Morse
2023-09-14 9:52 ` Russell King (Oracle)
2023-09-18 3:33 ` Gavin Shan
2023-10-20 11:16 ` Russell King (Oracle)
2023-09-13 16:37 ` [RFC PATCH v2 06/35] arm64: setup: Switch over to GENERIC_CPU_DEVICES using arch_register_cpu() James Morse
2023-09-14 9:56 ` Russell King (Oracle)
2023-09-14 11:27 ` Jonathan Cameron
2023-09-14 14:07 ` Russell King (Oracle)
2023-09-14 14:56 ` Jonathan Cameron
2023-09-13 16:37 ` [RFC PATCH v2 07/35] x86: intel_epb: Don't rely on link order James Morse
2023-09-14 10:02 ` Russell King (Oracle)
2023-09-18 3:48 ` Gavin Shan
2023-09-13 16:37 ` [RFC PATCH v2 08/35] x86/topology: Switch over to GENERIC_CPU_DEVICES James Morse
2023-09-14 10:01 ` Russell King (Oracle)
2023-09-14 11:40 ` Jonathan Cameron
2023-09-13 16:37 ` [RFC PATCH v2 09/35] LoongArch: " James Morse
2023-09-14 10:03 ` Russell King (Oracle)
2023-09-14 11:47 ` Jonathan Cameron
2023-09-13 16:37 ` [RFC PATCH v2 10/35] riscv: " James Morse
2023-09-14 10:04 ` Russell King (Oracle)
2023-09-14 11:48 ` Jonathan Cameron
2023-09-13 16:37 ` [RFC PATCH v2 11/35] arch_topology: Make register_cpu_capacity_sysctl() tolerant to late CPUs James Morse
2023-09-14 12:01 ` Jonathan Cameron
2023-10-20 11:53 ` Russell King (Oracle)
2023-10-21 10:56 ` Greg KH
2023-10-20 13:44 ` Russell King (Oracle)
2023-11-14 10:04 ` Russell King (Oracle)
2023-11-30 16:46 ` Jonathan Cameron
2023-09-13 16:38 ` [RFC PATCH v2 12/35] ACPI: Use the acpi_device_is_present() helper in more places James Morse
2023-09-14 12:04 ` Jonathan Cameron
2023-09-18 4:06 ` Gavin Shan
2023-09-13 16:38 ` [RFC PATCH v2 13/35] ACPI: Rename acpi_scan_device_not_present() to be about enumeration James Morse
2023-09-18 4:13 ` Gavin Shan
2023-10-20 16:01 ` Russell King (Oracle)
2023-10-20 16:41 ` Jonathan Cameron
2023-09-13 16:38 ` [RFC PATCH v2 14/35] ACPI: Only enumerate enabled (or functional) devices James Morse
2023-09-14 12:27 ` Jonathan Cameron
2023-09-14 13:09 ` Jonathan Cameron
2023-10-20 15:32 ` Russell King (Oracle)
2023-10-20 16:43 ` Jonathan Cameron
2023-09-18 4:38 ` Gavin Shan
2023-09-18 23:43 ` Gavin Shan
2023-10-20 15:45 ` Russell King (Oracle)
2023-09-13 16:38 ` [RFC PATCH v2 15/35] ACPI: processor: Add support for processors described as container packages James Morse
2023-09-14 13:53 ` Jonathan Cameron
2023-11-03 10:43 ` Russell King (Oracle)
2023-11-03 10:57 ` Russell King (Oracle)
2023-11-03 12:52 ` Jonathan Cameron
2023-09-18 5:02 ` Gavin Shan
2023-11-03 10:54 ` Russell King (Oracle)
2023-11-03 11:37 ` Russell King (Oracle)
2023-09-13 16:38 ` [RFC PATCH v2 16/35] ACPI: processor: Register CPUs that are online, but not described in the DSDT James Morse
2023-09-14 13:56 ` Jonathan Cameron
2023-09-18 5:12 ` Gavin Shan
2023-09-13 16:38 ` [RFC PATCH v2 17/35] ACPI: processor: Register all CPUs from acpi_processor_get_info() James Morse
2023-09-18 5:19 ` Gavin Shan
2023-09-13 16:38 ` [RFC PATCH v2 18/35] ACPI: Rename ACPI_HOTPLUG_CPU to include 'present' James Morse
2023-09-18 5:22 ` Gavin Shan
2023-09-13 16:38 ` [RFC PATCH v2 19/35] ACPI: Move acpi_bus_trim_one() before acpi_scan_hot_remove() James Morse
2023-09-14 14:10 ` Jonathan Cameron
2023-09-18 5:36 ` Gavin Shan
2023-09-13 16:38 ` [RFC PATCH v2 20/35] ACPI: Rename acpi_processor_hotadd_init and remove pre-processor guards James Morse
2023-09-14 14:17 ` Jonathan Cameron
2023-09-18 5:50 ` Gavin Shan
2023-10-23 20:01 ` Russell King (Oracle)
2023-09-13 16:38 ` [RFC PATCH v2 21/35] ACPI: Add post_eject to struct acpi_scan_handler for cpu hotplug James Morse
2023-09-14 14:28 ` Jonathan Cameron
2023-09-19 0:31 ` Gavin Shan
2023-09-13 16:38 ` [RFC PATCH v2 22/35] ACPI: Check _STA present bit before making CPUs not present James Morse
2023-09-14 14:31 ` Jonathan Cameron
2023-11-03 14:09 ` Russell King (Oracle)
2023-09-19 0:45 ` Gavin Shan
2023-11-03 14:37 ` Russell King (Oracle)
2023-09-13 16:38 ` [RFC PATCH v2 23/35] ACPI: Warn when the present bit changes but the feature is not enabled James Morse
2023-09-14 14:32 ` Jonathan Cameron
2023-09-19 0:49 ` Gavin Shan
2023-09-13 16:38 ` [RFC PATCH v2 24/35] drivers: base: Implement weak arch_unregister_cpu() James Morse
2023-09-14 14:39 ` Jonathan Cameron
2023-09-19 0:59 ` Gavin Shan
2023-10-23 8:44 ` Russell King (Oracle)
2023-10-23 8:55 ` Russell King (Oracle)
2023-09-13 16:38 ` [RFC PATCH v2 25/35] LoongArch: Use the __weak version of arch_unregister_cpu() James Morse
2023-09-14 14:41 ` Jonathan Cameron
2023-10-23 8:48 ` Russell King (Oracle)
2023-09-19 1:09 ` Gavin Shan
2023-09-13 16:38 ` [RFC PATCH v2 26/35] arm64: acpi: Move get_cpu_for_acpi_id() to a header James Morse
2023-09-14 14:43 ` Jonathan Cameron
2023-09-19 1:16 ` Gavin Shan
2023-09-13 16:38 ` [RFC PATCH v2 27/35] ACPICA: Add new MADT GICC flags fields [code first?] James Morse
2023-09-14 7:57 ` Ard Biesheuvel
2023-09-14 14:54 ` Jonathan Cameron
2023-09-14 15:34 ` Ard Biesheuvel
2023-09-14 15:49 ` Russell King (Oracle)
2023-09-15 2:29 ` Salil Mehta
2023-09-15 7:09 ` Russell King (Oracle)
2023-09-15 8:45 ` Rafael J. Wysocki
2023-09-15 9:34 ` Salil Mehta
2023-09-15 10:21 ` Rafael J. Wysocki
2023-09-15 14:49 ` Salil Mehta
2023-09-15 15:16 ` Russell King (Oracle)
2023-09-15 16:46 ` Salil Mehta
2023-09-15 13:43 ` Russell King (Oracle)
2023-09-15 15:17 ` Salil Mehta
2023-09-15 15:32 ` Jonathan Cameron
2023-09-15 17:12 ` Salil Mehta
2023-09-15 15:41 ` Russell King (Oracle)
2023-09-15 17:07 ` Salil Mehta
2023-09-15 9:21 ` Salil Mehta
2023-09-14 14:48 ` Jonathan Cameron
2023-09-13 16:38 ` [RFC PATCH v2 28/35] arm64, irqchip/gic-v3, ACPI: Move MADT GICC enabled check into a helper James Morse
2023-09-14 8:09 ` Russell King (Oracle)
2023-09-14 14:58 ` Jonathan Cameron
2023-09-19 1:23 ` Gavin Shan
2023-09-13 16:38 ` [RFC PATCH v2 29/35] irqchip/gic-v3: Don't return errors from gic_acpi_match_gicc() James Morse
2023-09-14 15:02 ` Jonathan Cameron
2023-10-23 18:58 ` Russell King (Oracle)
2023-09-19 3:39 ` Gavin Shan
2023-09-19 3:51 ` Gavin Shan
2023-09-13 16:38 ` [RFC PATCH v2 30/35] irqchip/gic-v3: Add support for ACPI's disabled but 'online capable' CPUs James Morse
2023-09-14 8:10 ` Russell King (Oracle)
2023-09-19 3:53 ` Gavin Shan
2023-09-13 16:38 ` [RFC PATCH v2 31/35] arm64: psci: Ignore DENIED CPUs James Morse
2023-09-14 16:01 ` Jonathan Cameron
2023-09-19 4:31 ` Gavin Shan
2023-09-13 16:38 ` [RFC PATCH v2 32/35] ACPI: add support to register CPUs based on the _STA enabled bit James Morse
2023-09-14 16:13 ` Jonathan Cameron
2023-09-19 10:24 ` Russell King (Oracle)
2023-09-19 4:46 ` Gavin Shan
2023-09-19 9:55 ` Russell King (Oracle)
2023-09-13 16:38 ` [RFC PATCH v2 33/35] arm64: document virtual CPU hotplug's expectations James Morse
2023-09-14 16:41 ` Jonathan Cameron
2023-09-13 16:38 ` [RFC PATCH v2 34/35] ACPI: Add _OSC bits to advertise OS support for toggling CPU present/enabled James Morse
2023-09-14 16:50 ` Jonathan Cameron
2023-09-13 16:38 ` [RFC PATCH v2 35/35] cpumask: Add enabled cpumask for present CPUs that can be brought online James Morse
2023-09-14 16:54 ` Jonathan Cameron
2023-09-18 10:27 ` [RFC PATCH v2 00/35] ACPI/arm64: add support for virtual cpuhotplug Russell King (Oracle)
2023-09-26 13:16 ` Salil Mehta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230913163823.7880-3-james.morse@arm.com \
--to=james.morse@arm.com \
--cc=jean-philippe@linaro.org \
--cc=jianyong.wu@arm.com \
--cc=justin.he@arm.com \
--cc=kvmarm@lists.linux.dev \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=loongarch@lists.linux.dev \
--cc=salil.mehta@huawei.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).