linux-arch.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Baoquan He <bhe@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: linux-arch@vger.kernel.org, linux-mm@kvack.org,
	akpm@linux-foundation.org, arnd@arndb.de,
	jiaxun.yang@flygoat.com, mpe@ellerman.id.au,
	geert@linux-m68k.org, mcgrof@kernel.org, hch@infradead.org,
	tsbogend@alpha.franken.de, f.fainelli@gmail.com, deller@gmx.de,
	Baoquan He <bhe@redhat.com>
Subject: [PATCH v5 0/4] arch/*/io.h: remove ioremap_uc in some architectures
Date: Thu, 21 Sep 2023 19:04:20 +0800	[thread overview]
Message-ID: <20230921110424.215592-1-bhe@redhat.com> (raw)

This patchset tries to remove ioremap_uc() in the current architectures
except of x86 and ia64. They will use the default ioremap_uc version
in <asm-generic/io.h> which returns NULL. Anyone who wants to add new
invocation of ioremap_uc(), please consider using ioremap() instead or
adding a new ARCH specific ioremap_uc(), or refer to the callsite
in drivers/video/fbdev/aty/atyfb_base.c.

This change won't cuase breakage to the current kernel because in the
only ioremap_uc callsite, an adjustment is made to eliminate impact in
patch 1 of this series.

To get rid of all of them other than x86 and ia64, add asm-generic/io.h
to asm/io.h of mips ARCH. With this adding, we can get rid of the
ioremap_uc() in mips too. This is done in patch 2. And a followup patch
4 is added to remove duplicated code according to Arnd's suggestion.

Test:
=====
Except of Jiaxun's efficient testing on patch 2/4, I also did cross compiling
of this series on mips64, building passed.

History:
=======
v4->v5:
  - In v4, Thomas reported that adding <asm-generic/io.h> including into
    mips always cause crash on his malta qemu. Finally, Jiaxun stood up to
    take over the patch 2/4 and make it work. This patchset collects
    Jiaxun's patch v5 and add Arnd's tag. Thanks to Jiaxun.
  - Meanwhile, the old patch 4/4 need be adjusted because Jiaxun has done
    some removal of duplicated codes in <asm/io.h>.
  - Add reviewers' tags from v4.
v3->v4:
  - Add patch 1 to adjust code in the only ioremap_uc() callsite so that
    later removing ioremap_uc() won't cause breakage.
  - Update log and document writing in patch 3.
  - Add followup patch 4 to clean up duplicated code in asm/io.h of MIPS.
v2->v3:
  - In patch 1, move those macro definition of functio near its function
    declaration according to Arnd's suggestion. And remove the unneeded
    change in asm/mmiowb.h introduced in old version.
  - In patch 2, clean up and rewrite the messy document related to
    ioremap_uc() in Documentation/driver-api/device-io.rst.
v1->v2:
  - Update log of patch 2, and document related to ioremap_uc()
    according to Geert's comment.
  - Add Geert's Acked-by.

Arnd Bergmann (1):
  video: fbdev: atyfb: only use ioremap_uc() on i386 and ia64

Baoquan He (2):
  arch/*/io.h: remove ioremap_uc in some architectures
  mips: io: remove duplicated codes

Jiaxun Yang (1):
  mips: add <asm-generic/io.h> including

 Documentation/driver-api/device-io.rst |   9 +-
 arch/alpha/include/asm/io.h            |   1 -
 arch/hexagon/include/asm/io.h          |   3 -
 arch/m68k/include/asm/kmap.h           |   1 -
 arch/mips/include/asm/io.h             | 123 +++++++++++++++----------
 arch/mips/include/asm/mmiowb.h         |   4 +-
 arch/mips/include/asm/smp-ops.h        |   2 -
 arch/mips/include/asm/smp.h            |   4 +-
 arch/mips/kernel/setup.c               |   1 +
 arch/mips/pci/pci-ip27.c               |   3 +
 arch/parisc/include/asm/io.h           |   2 -
 arch/powerpc/include/asm/io.h          |   1 -
 arch/sh/include/asm/io.h               |   2 -
 arch/sparc/include/asm/io_64.h         |   1 -
 drivers/video/fbdev/aty/atyfb_base.c   |   4 +
 15 files changed, 88 insertions(+), 73 deletions(-)

-- 
2.41.0


             reply	other threads:[~2023-09-21 20:20 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-21 11:04 Baoquan He [this message]
2023-09-21 11:04 ` [PATCH v5 1/4] video: fbdev: atyfb: only use ioremap_uc() on i386 and ia64 Baoquan He
2023-09-23 18:53   ` Helge Deller
2023-09-21 11:04 ` [PATCH v5 2/4] mips: add <asm-generic/io.h> including Baoquan He
2023-10-06  8:05   ` Thomas Bogendoerfer
2023-09-21 11:04 ` [PATCH v5 3/4] arch/*/io.h: remove ioremap_uc in some architectures Baoquan He
2023-09-21 12:27   ` Arnd Bergmann
2023-10-06  8:05   ` Thomas Bogendoerfer
2023-10-06  8:31   ` John Paul Adrian Glaubitz
2023-09-21 11:04 ` [PATCH v5 4/4] mips: io: remove duplicated codes Baoquan He
2023-09-21 12:24   ` Arnd Bergmann
2023-10-06  8:06   ` Thomas Bogendoerfer
2023-10-26 12:36 ` [PATCH v5 0/4] arch/*/io.h: remove ioremap_uc in some architectures Jiaxun Yang
2023-10-26 23:18   ` Baoquan He

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230921110424.215592-1-bhe@redhat.com \
    --to=bhe@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=arnd@arndb.de \
    --cc=deller@gmx.de \
    --cc=f.fainelli@gmail.com \
    --cc=geert@linux-m68k.org \
    --cc=hch@infradead.org \
    --cc=jiaxun.yang@flygoat.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mcgrof@kernel.org \
    --cc=mpe@ellerman.id.au \
    --cc=tsbogend@alpha.franken.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).