From: Conor Dooley <conor@kernel.org>
To: Charlie Jenkins <charlie@rivosinc.com>
Cc: Palmer Dabbelt <palmer@dabbelt.com>,
Samuel Holland <samuel.holland@sifive.com>,
David Laight <David.Laight@aculab.com>,
Xiao Wang <xiao.w.wang@intel.com>, Evan Green <evan@rivosinc.com>,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-arch@vger.kernel.org,
Paul Walmsley <paul.walmsley@sifive.com>,
Albert Ou <aou@eecs.berkeley.edu>, Arnd Bergmann <arnd@arndb.de>,
Conor Dooley <conor.dooley@microchip.com>
Subject: Re: [PATCH v9 0/5] riscv: Add fine-tuned checksum functions
Date: Wed, 1 Nov 2023 11:50:46 +0000 [thread overview]
Message-ID: <20231101-palace-tightly-97a1d35a4597@spud> (raw)
In-Reply-To: <20231031-optimize_checksum-v9-0-ea018e69b229@rivosinc.com>
[-- Attachment #1: Type: text/plain, Size: 1292 bytes --]
On Tue, Oct 31, 2023 at 05:18:50PM -0700, Charlie Jenkins wrote:
> Each architecture generally implements fine-tuned checksum functions to
> leverage the instruction set. This patch adds the main checksum
> functions that are used in networking.
>
> This patch takes heavy use of the Zbb extension using alternatives
> patching.
>
> To test this patch, enable the configs for KUNIT, then CHECKSUM_KUNIT
> and RISCV_CHECKSUM_KUNIT.
>
> I have attempted to make these functions as optimal as possible, but I
> have not ran anything on actual riscv hardware. My performance testing
> has been limited to inspecting the assembly, running the algorithms on
> x86 hardware, and running in QEMU.
>
> ip_fast_csum is a relatively small function so even though it is
> possible to read 64 bits at a time on compatible hardware, the
> bottleneck becomes the clean up and setup code so loading 32 bits at a
> time is actually faster.
>
> Relies on https://lore.kernel.org/lkml/20230920193801.3035093-1-evan@rivosinc.com/
I coulda sworn I reported build issues against the v8 of this series
that are still present in this v9. For example:
https://patchwork.kernel.org/project/linux-riscv/patch/20231031-optimize_checksum-v9-3-ea018e69b229@rivosinc.com/
Cheers,
Conor.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-11-01 11:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-01 0:18 [PATCH v9 0/5] riscv: Add fine-tuned checksum functions Charlie Jenkins
2023-11-01 0:18 ` [PATCH v9 1/5] asm-generic: Improve csum_fold Charlie Jenkins
2023-11-01 0:18 ` [PATCH v9 2/5] riscv: Add static key for misaligned accesses Charlie Jenkins
2023-11-01 0:18 ` [PATCH v9 3/5] riscv: Checksum header Charlie Jenkins
2023-11-01 15:22 ` Jisheng Zhang
2023-11-01 17:07 ` Charlie Jenkins
2023-11-01 0:18 ` [PATCH v9 4/5] riscv: Add checksum library Charlie Jenkins
2023-11-01 0:18 ` [PATCH v9 5/5] riscv: Test checksum functions Charlie Jenkins
2023-11-01 19:14 ` Arnd Bergmann
2023-11-01 20:12 ` Charlie Jenkins
2023-11-01 11:50 ` Conor Dooley [this message]
2023-11-01 17:06 ` [PATCH v9 0/5] riscv: Add fine-tuned " Charlie Jenkins
2023-11-02 10:21 ` Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231101-palace-tightly-97a1d35a4597@spud \
--to=conor@kernel.org \
--cc=David.Laight@aculab.com \
--cc=aou@eecs.berkeley.edu \
--cc=arnd@arndb.de \
--cc=charlie@rivosinc.com \
--cc=conor.dooley@microchip.com \
--cc=evan@rivosinc.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=samuel.holland@sifive.com \
--cc=xiao.w.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox