From: Steven Price <steven.price@arm.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Steven Price <steven.price@arm.com>,
linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] fixmap: Remove unused set_fixmap_offset_io()
Date: Wed, 12 Jun 2024 17:00:38 +0100 [thread overview]
Message-ID: <20240612160038.522924-1-steven.price@arm.com> (raw)
The macro set_fixmap_offset_io() was added in commit f774b7d10e21
("arm64: fixmap: fix missing sub-page offset for earlyprintk") but then
commit 8ef0ed95ee04 ("arm64: remove arch specific earlyprintk") removed
the file causing the only user to be removed when the two commits were
merged. Since this has never been used again since the v3.15 release
remove it.
Signed-off-by: Steven Price <steven.price@arm.com>
---
This came up because for Arm CCA there is a need to override
set_fixmap_io() [1] and rather than also update set_fixmap_offset_io() I
thought it would be better to just drop the unused macro.
[1] https://lore.kernel.org/lkml/20240605093006.145492-6-steven.price@arm.com/
---
include/asm-generic/fixmap.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/include/asm-generic/fixmap.h b/include/asm-generic/fixmap.h
index 8cc7b09c1bc7..29cab7947980 100644
--- a/include/asm-generic/fixmap.h
+++ b/include/asm-generic/fixmap.h
@@ -97,8 +97,5 @@ static inline unsigned long virt_to_fix(const unsigned long vaddr)
#define set_fixmap_io(idx, phys) \
__set_fixmap(idx, phys, FIXMAP_PAGE_IO)
-#define set_fixmap_offset_io(idx, phys) \
- __set_fixmap_offset(idx, phys, FIXMAP_PAGE_IO)
-
#endif /* __ASSEMBLY__ */
#endif /* __ASM_GENERIC_FIXMAP_H */
--
2.34.1
next reply other threads:[~2024-06-12 16:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-12 16:00 Steven Price [this message]
2024-06-12 20:02 ` [PATCH] fixmap: Remove unused set_fixmap_offset_io() Arnd Bergmann
2024-06-27 13:58 ` Steven Price
2024-07-10 12:45 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240612160038.522924-1-steven.price@arm.com \
--to=steven.price@arm.com \
--cc=arnd@arndb.de \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox