From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f180.google.com (mail-lj1-f180.google.com [209.85.208.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C64C215E5C8 for ; Wed, 28 Aug 2024 09:06:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724835969; cv=none; b=fGbVLjENSMJdeVS/N/764a1eSCHoZcK98h5UvFsGz01/iCm1PcdvZkpdFS7Albtm74DwPtn3guu3yUTq0DIXhqq1oaG8G3BinBdkNuWmJO/dm8cBqB/Sn7x0anCUKxMONvzRcaEBy/GQihKnRpKr+LqlyKP+Fl37w/Aj2q56kLE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724835969; c=relaxed/simple; bh=tilZU3Kh158lJuUVKV7O5vJ4OjgZWFiiF6RI0BZAfg8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=tq6Fyym9yN7UjrFbXn15LY9ZhSm3qwGEktW2hONyZJzGRXD/Bfga5TwNF/XOl+c0zdgMBFqkPsYL1xLKeC5aXjPRDgpCfmPKM2TpV/cFryiIAKup3b1ZZPYyoUrNr5X2qk+l/qMmn2UtEoQUNpphaT8SHJCLSDe3m0Q9XZS4O04= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ventanamicro.com; spf=pass smtp.mailfrom=ventanamicro.com; dkim=pass (2048-bit key) header.d=ventanamicro.com header.i=@ventanamicro.com header.b=B57pwSUN; arc=none smtp.client-ip=209.85.208.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ventanamicro.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ventanamicro.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ventanamicro.com header.i=@ventanamicro.com header.b="B57pwSUN" Received: by mail-lj1-f180.google.com with SMTP id 38308e7fff4ca-2f3f0bdbcd9so71793721fa.1 for ; Wed, 28 Aug 2024 02:06:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1724835966; x=1725440766; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=eUwP1bH89y2mjDwy+uYIsF7q8d+iUjc7F7MG+V5YoHA=; b=B57pwSUNrzfkeq72C1HWzOwMvaNQjY3cIv/ivPN2tDcAUNjRGZQbMvcXTA9yxXEpdw +bKFt1GzR/Tl1v51WshqzJDq+Jlkxnt9sugzURczlNMOiPt7vZ/BtL5P9LiGBh0lSAey YAVLyQM1BF0b16ig0dGX225roICmwcZkFa2/cOVVHYPBCJxLeKHXMJ1HBtk5h5kMh8/m KZDS/7bGVgDW90C8SMON16UZW2qf2WfHmOmp7DOp33Nqdag5LX9Iwz5rL7RtHv3TUmoh 5IkCSMrDGmHWvhbE1lyt9s0c3r22oDbVFKs+ll86gOJpP6sBh8PpD/y06sQ6hQ4iV1tp RGow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724835966; x=1725440766; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=eUwP1bH89y2mjDwy+uYIsF7q8d+iUjc7F7MG+V5YoHA=; b=lwAf95Ssl+bTb28QrwkXUsgtBCnc+0cyYAWWIBpXfaTJR5lhZFmInibMPGjTYWCL8K aSdr8NNTzUjgEj8w8DrlIcRfNe7rU2Sbznz549PslA0qEOJ/mchLu3+x+HuLscH8mTtv AuIYk38S5ENaLppB3Ees0eB9XJi9pieKh5b2VfE8pEe+5GxUnjdMMtu/6/VcT93zj1gx 3Dz2A8r/zbznzIAr2bAV47R/IO6ty+LhmIPMej2lgjo7DvpuM2wX7u91RVB85+iWnhGc D7mumRLDaASVVXA3fUcQV/CPVyXKbDKdSG+L6dWysWDnU+/6E6fUfzjaxEOKXLbkRIgn n3OQ== X-Forwarded-Encrypted: i=1; AJvYcCWVexsrR0hmGo5Ek+ZRSAQio61wpbyxghH7lxOBKxG/Sqygma75qLMqCiAlU8cYB5PHlZqWBAZfwdpi@vger.kernel.org X-Gm-Message-State: AOJu0YxvU5lJYEbtbhOx77NWGu9itT70Dk9LZkFQh/Yt4+a3e51YKT4i FGsWt96gRArI7jIPxdZmg6KfwkPoroXV1nr7Y5+mW0wp+q9gdqVK9z6t/0m6t20= X-Google-Smtp-Source: AGHT+IEk0hGUKNFKy1gAbF519cS1Zf9jNVuoleszEhO12zfKPjpQIg/vIHKKuEXsuMjAwz6KFlZ/ow== X-Received: by 2002:a2e:908a:0:b0:2ef:2d3a:e70a with SMTP id 38308e7fff4ca-2f4f49090f4mr89975361fa.18.1724835964996; Wed, 28 Aug 2024 02:06:04 -0700 (PDT) Received: from localhost (cst2-173-13.cust.vodafone.cz. [31.30.173.13]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5c0bb4824e7sm1973814a12.92.2024.08.28.02.06.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Aug 2024 02:06:04 -0700 (PDT) Date: Wed, 28 Aug 2024 11:06:02 +0200 From: Andrew Jones To: Alexandre Ghiti Cc: Jonathan Corbet , Paul Walmsley , Palmer Dabbelt , Albert Ou , Conor Dooley , Rob Herring , Krzysztof Kozlowski , Andrea Parri , Nathan Chancellor , Peter Zijlstra , Ingo Molnar , Will Deacon , Waiman Long , Boqun Feng , Arnd Bergmann , Leonardo Bras , Guo Ren , linux-doc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, linux-arch@vger.kernel.org Subject: Re: [PATCH v5 13/13] riscv: Add qspinlock support Message-ID: <20240828-801ce72599586044dcaa767d@orel> References: <20240818063538.6651-1-alexghiti@rivosinc.com> <20240818063538.6651-14-alexghiti@rivosinc.com> <20240821-ec1ec92842570050429621d1@orel> Precedence: bulk X-Mailing-List: linux-arch@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Aug 28, 2024 at 10:16:40AM GMT, Alexandre Ghiti wrote: ... > I sent the kernel size impact using -Os as asked and > ARCH_WEAK_RELEASE_ACQUIRE should be handled by Andrea. Sounds good. Thanks. > > Thanks for all the reviews drew, the patchset is way better now! I > won't respin a new version since there is only a minor comment change > requested in "riscv: Improve zacas fully-ordered cmpxchg()" unless you > insist. I don't insist. It might be nice to change the comment text at merge though since it's safe to do with only compile-testing and it would improve readability. Thanks, drew