From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D40F2217338; Tue, 8 Oct 2024 22:41:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728427311; cv=none; b=ngtVrIMpq2VK8OtLCuR2WoeRq3cXcNb7UhuvvauscZvgBxEgpS1zBIxe/1hc6Wfno0R5IRr/aR0LvCDQKBFkZd/zaZAyI/ewLoieHywCmi1ZBzpR9QBAMNjdifk8g+eX+qNiBjz/jVekSTtQf/pkxPx6Zsq0jYmqVM6Z5I4OEDs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728427311; c=relaxed/simple; bh=dcyvt0dgAZszkRlVAvb5HjPFo8uYI0c0H8I8+ifT9Mc=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=ejQpcduJEg3Cg0K1e4GaivddGtXnUqtYAKSy4HLYH0cnapHE3h6qPGayN144PSw6BAKlDLkimAzaik8zp2zSFpEFDTbM05/v9lRzA3IuLaWVPeMrfOojyBW8yPE0MSUoP5bBuXmnQrtYucJm9XTwfFMDp17EnuduNyLKJHgbs9I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=YVKI9Crq; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="YVKI9Crq" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 821CEC4CEC7; Tue, 8 Oct 2024 22:41:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1728427310; bh=dcyvt0dgAZszkRlVAvb5HjPFo8uYI0c0H8I8+ifT9Mc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=YVKI9Crqoxb+kubNcOuiLkrNECGkggxSHQ7zCyU+C4i8uxiYSqLNhL0X/vyK4nbzv ZTZhdx2QyfKE2LnLqpmbl5qupaMKqcPjo4pfP0XVVDT7jJ3Pi+yGLIFlAoyQ1zJ8f/ LRx6mNnFL/YEgXB3zZceNPZm3XxIxsg2PBPTbpBe46PAYpR81VHsD8MOEnS/HXOEZ2 Ap8/akyKsgqNs5Pe4svGt4x+EP0vBEWmNqIITelNqML0XZvg5lqB67aOG28+RNgkvt wfDDeXaYNBD5I8SjevQEEAIRaEj2kZMlEcSfY0ZWuEXT4HdfIj190zY9PkfL3KNXYl LDp5MEWE7lO/w== Date: Wed, 9 Oct 2024 07:41:40 +0900 From: Masami Hiramatsu (Google) To: Steven Rostedt Cc: LKML , Linux Trace Kernel , linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, "linux-arch@vger.kernel.org" , "x86@kernel.org" , Masami Hiramatsu , Mathieu Desnoyers , Mark Rutland , Catalin Marinas , Will Deacon , Huacai Chen , WANG Xuerui , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Madhavan Srinivasan , Paul Walmsley , Palmer Dabbelt , Albert Ou , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen Subject: Re: [PATCH] ftrace: Make ftrace_regs abstract from direct use Message-Id: <20241009074140.b163eceb2f973227b400c962@kernel.org> In-Reply-To: <20241007204743.41314f1d@gandalf.local.home> References: <20241007204743.41314f1d@gandalf.local.home> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-arch@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Hi Steve, > diff --git a/include/asm-generic/ftrace.h b/include/asm-generic/ftrace.h > index 3a23028d69d2..ba7b7d6e55d6 100644 > --- a/include/asm-generic/ftrace.h > +++ b/include/asm-generic/ftrace.h > @@ -10,4 +10,17 @@ > * common definitions are already in linux/ftrace.h. > */ > > +#ifndef CONFIG_HAVE_DYNAMIC_FTRACE_WITH_ARGS > +struct __arch_ftrace_regs { > + struct pt_regs regs; > +}; > + > +#define arch_ftrace_get_regs(fregs) \ > + ({ struct __arch_fregs_regs *__f = (struct __arch_ftrace_regs *)(fregs); \ > + &__f->regs; \ > + }) > + > +struct ftrace_regs; > +#define arch_ftrace_regs(fregs) ((struct __arch_ftrace_regs *)(fregs)) > + > #endif /* __ASM_GENERIC_FTRACE_H__ */ There seems no #endif for CONFIG_HAVE_DYNAMIC_FTRACE_WITH_ARGS. I wonder how it passed the build. (#ifdef block does not affect over the file boundary? Thank you, -- Masami Hiramatsu (Google)