From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E66C1C687; Fri, 1 Nov 2024 01:51:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730425870; cv=none; b=Xat2SoLn+XAyzAcWywp4866f60D8lKxJknxsEdkmEIO6ncVfeuDOhJoDOr+vj+zwrpM5CtAK3CkQQXvsq4ybPp8zzNLXt7czZf0/Yg2spJgHGji8BeardXxPuQs5ibJ3Ov+94xeIc3XXCBTlDUi17yfW+XfV6PjmA7IynInByZE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730425870; c=relaxed/simple; bh=mQn2vYnNjvmJzZqgDpy9vINksBNngUZWVd/553rFPcg=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=RIbTKbJUtnhYt95m/A6CueI/50zBnolPubkdur9QR7BjhudH+EgAfKStEEYqcP0aow7CSX1kqIM29KGVoZo884cTp6r1nZ3M3Z7zXEz9iw6TQAX8m9HSd0FU+CX7NCOuhxoobIJ2t6hCRyCtTI2iNsvfMa+YUUnHYjWDLGXG8zU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=idYJx8Sj; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="idYJx8Sj" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A89BEC4CED0; Fri, 1 Nov 2024 01:51:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1730425870; bh=mQn2vYnNjvmJzZqgDpy9vINksBNngUZWVd/553rFPcg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=idYJx8Sj8SnC5eI7bQ/Bw/TBQSTo5m7rTvgxVXcxDZ1TgiXPj5v/dNNgZVarZMfvm MaSdhyxrS7If1diO4gMx8+l9rvpJZ4hMCn9KzZOKhho/b4cfKBTeDnkKFmZc7tft7/ 3SCAfveMIjBKDFZmp7Bmf9lcs+q+WY/0BwbtIDBSEp1yPPGqJDnCSyYvLQgrjFaY1K zGAE5WMpmR27EQRg/4cTcfYpfNjAmRjKZNwU1ZANOziBrcN97FqpKq4qm6tngsjuBj 0hJMd+uy5TgputFdONTk5KUbG2NVDEcUXBciFG61tdYS+TZrudw7xfq7z4en1T3XFk F11UOhSDgRHug== Date: Fri, 1 Nov 2024 10:51:02 +0900 From: Masami Hiramatsu (Google) To: Steven Rostedt Cc: Alexei Starovoitov , Florent Revest , linux-trace-kernel@vger.kernel.org, LKML , Martin KaFai Lau , bpf , Alexei Starovoitov , Jiri Olsa , Alan Maguire , Mark Rutland , linux-arch@vger.kernel.org, Catalin Marinas , Will Deacon , Huacai Chen , WANG Xuerui , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Madhavan Srinivasan , Paul Walmsley , Palmer Dabbelt , Albert Ou , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Mathieu Desnoyers Subject: Re: [PATCH v18 01/17] fgraph: Pass ftrace_regs to entryfunc Message-Id: <20241101105102.eb308ab85b2b13d03444d4bf@kernel.org> In-Reply-To: <20241031155324.108ed8ef@gandalf.local.home> References: <172991731968.443985.4558065903004844780.stgit@devnote2> <172991733069.443985.15154246733356205391.stgit@devnote2> <20241031155324.108ed8ef@gandalf.local.home> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-arch@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 31 Oct 2024 15:53:24 -0400 Steven Rostedt wrote: > On Sat, 26 Oct 2024 13:35:30 +0900 > "Masami Hiramatsu (Google)" wrote: > > > From: Masami Hiramatsu (Google) > > > > Pass ftrace_regs to the fgraph_ops::entryfunc(). If ftrace_regs is not > > available, it passes a NULL instead. User callback function can access > > some registers (including return address) via this ftrace_regs. > > > > Note that the ftrace_regs can be NULL when the arch does NOT define: > > HAVE_DYNAMIC_FTRACE_WITH_ARGS or HAVE_DYNAMIC_FTRACE_WITH_REGS. > > More specifically, if HAVE_DYNAMIC_FTRACE_WITH_REGS is defined but > > not the HAVE_DYNAMIC_FTRACE_WITH_ARGS, and the ftrace ops used to > > register the function callback does not set FTRACE_OPS_FL_SAVE_REGS. > > In this case, ftrace_regs can be NULL in user callback. > > If HAVE_DYNAMIC_FTRACE_WITH_REGS is defined but not > HAVE_DYNAMIC_FTRACE_WITH_ARGS is not, then the callback will have regs defined. > > > @@ -977,7 +980,7 @@ unsigned long ftrace_graph_ret_addr(struct task_struct *task, int *idx, > > > > static struct ftrace_ops graph_ops = { > > .func = ftrace_graph_func, > > - .flags = FTRACE_OPS_GRAPH_STUB, > > + .flags = FTRACE_OPS_GRAPH_STUB | FTRACE_OPS_FL_SAVE_ARGS, > > Enabling FTRACE_OPS_FL_SAVE_ARGS will pass full regs in that case. Are you > just saying in the change log that this is what you did? As it currently > reads, it sounds like a fgraph user needs to add FTRACE_OPS_FL_SAVE_REGS?? Ah, good catch! It should put the flag only when HAVE_DYNAMIC_FTRACE_WITH_ARGS is enabled. static struct ftrace_ops graph_ops = { .func = ftrace_graph_func, #ifdef CONFIG_DYNAMIC_FTRACE_WITH_ARGS .flags = FTRACE_OPS_GRAPH_STUB | FTRACE_OPS_FL_SAVE_ARGS, #elif defined(CONFIG_DYNAMIC_FTRACE_WITH_ARGS) .flags = FTRACE_OPS_GRAPH_STUB | FTRACE_OPS_FL_SAVE_REGS, #else .flags = FTRACE_OPS_GRAPH_STUB, #endif This will save fregs or regs or NULL according to the configuration. > > -- Steve > > > > #ifdef FTRACE_GRAPH_TRAMP_ADDR > > .trampoline = FTRACE_GRAPH_TRAMP_ADDR, > > /* trampoline_size is only needed for dynamically allocated tramps */ > > @@ -987,7 +990,8 @@ static struct ftrace_ops graph_ops = { > > void fgraph_init_ops(struct ftrace_ops *dst_ops, > > struct ftrace_ops *src_ops) > > { > > - dst_ops->flags = FTRACE_OPS_FL_PID | FTRACE_OPS_GRAPH_STUB; > > + dst_ops->flags = FTRACE_OPS_FL_PID | FTRACE_OPS_GRAPH_STUB | > > + FTRACE_OPS_FL_SAVE_ARGS; > > > > #ifdef CONFIG_DYNAMIC_FTRACE > > if (src_ops) { -- Masami Hiramatsu (Google)