From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6D30F19ABD5; Sat, 9 Nov 2024 15:11:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731165063; cv=none; b=R/G0ZSIvOhrRESsGWqjYmLA8djUF3KLOntMmXTl+QcUUY9977YfEJQf+/qVtPyP3t7r1zwdG3EE/wr8AUORM2UElPAUSWgw6uwXozqP3KzVYq5YhIsPVfGvZLqeuONzpDCR5dVG1EjUXiCDcY8MsjxPW7eXLUBxcgJWc07UGEBA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731165063; c=relaxed/simple; bh=TPwfAmDjNRlKpMlwR68ymGtPsQXE+Pd6kBFBv3CzJHA=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=pxPVxocBXuhskinBmS2nVA/t3pQ6CQlO0v5TqEjMTUeXhUucqqEaljfq3Wr9DyKvgvvDyH1puH+HlnJHLQP09WTlKCAB8rTqNDkF8t8eKb9suqoTbS/vP2HVlCxyzl9/lP0xx0b5UXmtJWdPYLM5n4gG/DD6H5+OyjsluP22fb8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=UJiqpOOt; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="UJiqpOOt" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4581EC4CECE; Sat, 9 Nov 2024 15:10:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1731165063; bh=TPwfAmDjNRlKpMlwR68ymGtPsQXE+Pd6kBFBv3CzJHA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=UJiqpOOt+j7i5PkxwN9LXvisxD5u3R5gQrHTaFbGO2MtaJn5yyxKcjpTd97YQTJWn hKvVc3DriUspWM4U3BuHIFwbsBoYKq0OTgiNluqZzBQEx3EbHXrfAyJVm64WEORgu8 rutrWgzhMRmlBWhQ5Avo/M0m46AKmWM4ZjrgYB2tFjiIz8kxZsGQCqCmL3WHG1cah+ 4qinqK+JQKyWY5pbwEAab++Hgz+DdCVx0RWQnKlI48EPDfIaF71y37grcvRRAYFenP kzgaJY8aJ/pngbV1byl93jlWJU4RoxpJwnHPecclNHrBmKFc4vSNIiGR++s9rZwlO+ Ymi7/UHiHV9Ow== Date: Sun, 10 Nov 2024 00:10:54 +0900 From: Masami Hiramatsu (Google) To: Steven Rostedt Cc: Alexei Starovoitov , Florent Revest , linux-trace-kernel@vger.kernel.org, LKML , Martin KaFai Lau , bpf , Alexei Starovoitov , Jiri Olsa , Alan Maguire , Mark Rutland , linux-arch@vger.kernel.org, Catalin Marinas , Will Deacon , Huacai Chen , WANG Xuerui , Paul Walmsley , Palmer Dabbelt , Albert Ou , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Arnd Bergmann , Mathieu Desnoyers Subject: Re: [PATCH v18 12/17] fprobe: Add fprobe_header encoding feature Message-Id: <20241110001054.b0a5afb2d7bb1c09b4bd6b0b@kernel.org> In-Reply-To: <20241101102212.5e9d74d9@gandalf.local.home> References: <172991731968.443985.4558065903004844780.stgit@devnote2> <172991747946.443985.11014834036464028393.stgit@devnote2> <20241101102212.5e9d74d9@gandalf.local.home> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-arch@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 1 Nov 2024 10:22:12 -0400 Steven Rostedt wrote: > On Sat, 26 Oct 2024 13:37:59 +0900 > "Masami Hiramatsu (Google)" wrote: > > > From: Masami Hiramatsu (Google) > > > > Fprobe store its data structure address and size on the fgraph return stack > > by __fprobe_header. But most 64bit architecture can combine those to > > one unsigned long value because 4 MSB in the kernel address are the same. > > With this encoding, fprobe can consume less space on ret_stack. > > > > This introduces asm/fprobe.h to define arch dependent encode/decode > > macros. Note that since fprobe depends on CONFIG_HAVE_FUNCTION_GRAPH_FREGS, > > currently only arm64, loongarch, riscv, s390 and x86 are supported. > > > > Signed-off-by: Masami Hiramatsu (Google) > > Cc: Catalin Marinas > > Cc: Will Deacon > > Cc: Huacai Chen > > Cc: WANG Xuerui > > Cc: Paul Walmsley > > Cc: Palmer Dabbelt > > Cc: Albert Ou > > Cc: Heiko Carstens > > Cc: Vasily Gorbik > > Cc: Alexander Gordeev > > Cc: Christian Borntraeger > > Cc: Sven Schnelle > > Cc: Thomas Gleixner > > Cc: Ingo Molnar > > Cc: Borislav Petkov > > Cc: Dave Hansen > > Cc: x86@kernel.org > > Cc: "H. Peter Anvin" > > Cc: Arnd Bergmann > > Cc: Steven Rostedt > > Cc: Masami Hiramatsu > > Cc: Mathieu Desnoyers > > --- > > arch/arm64/include/asm/fprobe.h | 7 +++++++ > > arch/loongarch/include/asm/fprobe.h | 5 +++++ > > arch/riscv/include/asm/fprobe.h | 9 +++++++++ > > arch/s390/include/asm/fprobe.h | 10 ++++++++++ > > arch/x86/include/asm/fprobe.h | 9 +++++++++ > > include/asm-generic/fprobe.h | 33 +++++++++++++++++++++++++++++++++ > > kernel/trace/fprobe.c | 29 +++++++++++++++++++++++++++++ > > 7 files changed, 102 insertions(+) > > create mode 100644 arch/arm64/include/asm/fprobe.h > > create mode 100644 arch/loongarch/include/asm/fprobe.h > > create mode 100644 arch/riscv/include/asm/fprobe.h > > create mode 100644 arch/s390/include/asm/fprobe.h > > create mode 100644 arch/x86/include/asm/fprobe.h > > create mode 100644 include/asm-generic/fprobe.h > > > > diff --git a/arch/arm64/include/asm/fprobe.h b/arch/arm64/include/asm/fprobe.h > > new file mode 100644 > > index 000000000000..bbf254db878d > > --- /dev/null > > +++ b/arch/arm64/include/asm/fprobe.h > > @@ -0,0 +1,7 @@ > > +/* SPDX-License-Identifier: GPL-2.0 */ > > +#ifndef _ASM_ARM64_FPROBE_H > > +#define _ASM_ARM64_FPROBE_H > > + > > +#include > > + > > +#endif /* _ASM_ARM64_FPROBE_H */ > > \ No newline at end of file > > This isn't the way to add asm-generic code to architectures. It needs to be > in the Kbuild file. Like this: > > diff --git a/arch/arm64/include/asm/Kbuild b/arch/arm64/include/asm/Kbuild > index 4e350df9a02d..0d0a638d41a8 100644 > --- a/arch/arm64/include/asm/Kbuild > +++ b/arch/arm64/include/asm/Kbuild > @@ -14,6 +14,7 @@ generic-y += qrwlock.h > generic-y += qspinlock.h > generic-y += parport.h > generic-y += user.h > +generic-y += fprobe.h > > generated-y += cpucap-defs.h > generated-y += sysreg-defs.h OK. > > > > diff --git a/arch/loongarch/include/asm/fprobe.h b/arch/loongarch/include/asm/fprobe.h > > new file mode 100644 > > index 000000000000..68156a66873c > > --- /dev/null > > +++ b/arch/loongarch/include/asm/fprobe.h > > @@ -0,0 +1,5 @@ > > +/* SPDX-License-Identifier: GPL-2.0 */ > > +#ifndef _ASM_LOONGARCH_FPROBE_H > > +#define _ASM_LOONGARCH_FPROBE_H > > + > > +#endif /* _ASM_LOONGARCH_FPROBE_H */ > > \ No newline at end of file > > diff --git a/arch/riscv/include/asm/fprobe.h b/arch/riscv/include/asm/fprobe.h > > new file mode 100644 > > index 000000000000..51fc2ef3eda1 > > --- /dev/null > > +++ b/arch/riscv/include/asm/fprobe.h > > @@ -0,0 +1,9 @@ > > +/* SPDX-License-Identifier: GPL-2.0 */ > > +#ifndef _ASM_RISCV_FPROBE_H > > +#define _ASM_RISCV_FPROBE_H > > + > > +#ifdef CONFIG_64BIT > > +#include > > +#endif > > + > > +#endif /* _ASM_RISCV_FPROBE_H */ > > \ No newline at end of file > > diff --git a/arch/s390/include/asm/fprobe.h b/arch/s390/include/asm/fprobe.h > > new file mode 100644 > > index 000000000000..84b94ba6e3a4 > > --- /dev/null > > +++ b/arch/s390/include/asm/fprobe.h > > @@ -0,0 +1,10 @@ > > +/* SPDX-License-Identifier: GPL-2.0 */ > > +#ifndef _ASM_S390_FPROBE_H > > +#define _ASM_S390_FPROBE_H > > + > > +#include > > + > > +#undef FPROBE_HEADER_MSB_PATTERN > > +#define FPROBE_HEADER_MSB_PATTERN 0 > > + > > +#endif /* _ASM_S390_FPROBE_H */ > > \ No newline at end of file > > diff --git a/arch/x86/include/asm/fprobe.h b/arch/x86/include/asm/fprobe.h > > new file mode 100644 > > index 000000000000..c863518bef90 > > --- /dev/null > > +++ b/arch/x86/include/asm/fprobe.h > > @@ -0,0 +1,9 @@ > > +/* SPDX-License-Identifier: GPL-2.0 */ > > +#ifndef _ASM_X86_FPROBE_H > > +#define _ASM_X86_FPROBE_H > > + > > +#ifdef CONFIG_64BIT > > +#include > > +#endif > > + > > +#endif /* _ASM_X86_FPROBE_H */ > > \ No newline at end of file > > Same for the above. OK, but x86 and riscv, we need this default template on 64bit only. So those may keep it, right? Thank you, > > -- Steve -- Masami Hiramatsu (Google)