From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 55C1D4594D; Sun, 10 Nov 2024 17:07:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.156.1 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731258477; cv=none; b=k79JpZjK0ObAZNT4M3POc9KbvzIIoKdBeaD8SUAfo1/oLSALnemSfWj1a+gEDlAjLn3ufsATIrOTYJ8kWcLi9Wec9fVlyhfKR4I1Altw/9VT3d6ULQa1NNK1vp7SgoEiWdmCXqxVm0XVdensM5EpZovW32+V59AqF8jmcnwx/RM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731258477; c=relaxed/simple; bh=h60pEsIQpOR1/jSz0MbvvPG4Nuacn2L5RGrtOYqjjog=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=UdGoD9qinZsb++zuXqNNT1kLHEf4+HoIsrnerlfD0GBTvZuRthWsbsUP1VMwe1ul8uWd8VOOo+k/ZObEaCx3Kd1jstJJaPH8tawaGPfXLqHrj3PgQST1oX5YTAwinqTYLq0LKuaOWtJNlSVDf5uENXKAhIn2GfLO+kTn2SMPb9Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=oKbC6L9u; arc=none smtp.client-ip=148.163.156.1 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="oKbC6L9u" Received: from pps.filterd (m0356517.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4AAFb5Ki032278; Sun, 10 Nov 2024 17:07:23 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=pp1; bh=Fyttpba9yUUO6fCu6rMH3lKtKc9KsN UyGlgNKi1Ih2M=; b=oKbC6L9uPt5jsN2l5/TQ28E7qs+6jFqB90CbVvz0N40qvp q9UoqJLTCgqqnVkvm9sqlEg7NnLQH2v6B/iy0+0glGA2FjtLUI/ivnKTEkuPmcLn u9j21sA2dxSznFI1A3p0ueIJ4JJ6zZrzjLvTICfbhGdWe+LKV9e1rhWbAR+md1eR GVRNstc1PEcupTLwnNoBTdO6qDLidg+hqQaIZIL2ozYUeyZfShMDQhSy26uglrDO IVlp04YQwU6boaWg8xNpTS+RJUr5Xr0t+AHFx446fvqALOQhzutvPlGrzKMTc6Ic TZ/ZejsMGJ2i05xOqQEmE5ZPZYoR4kCXfQtMhpOQ== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 42tjg3a944-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 10 Nov 2024 17:07:23 +0000 (GMT) Received: from m0356517.ppops.net (m0356517.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 4AAH7MB3003803; Sun, 10 Nov 2024 17:07:22 GMT Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 42tjg3a940-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 10 Nov 2024 17:07:22 +0000 (GMT) Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 4AAFVWtB029688; Sun, 10 Nov 2024 17:07:21 GMT Received: from smtprelay07.fra02v.mail.ibm.com ([9.218.2.229]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 42tkjk5ux6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 10 Nov 2024 17:07:21 +0000 Received: from smtpav07.fra02v.mail.ibm.com (smtpav07.fra02v.mail.ibm.com [10.20.54.106]) by smtprelay07.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 4AAH7HTv39322004 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 10 Nov 2024 17:07:17 GMT Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 44FD020043; Sun, 10 Nov 2024 17:07:17 +0000 (GMT) Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id AF80A20040; Sun, 10 Nov 2024 17:07:15 +0000 (GMT) Received: from osiris (unknown [9.171.74.231]) by smtpav07.fra02v.mail.ibm.com (Postfix) with ESMTPS; Sun, 10 Nov 2024 17:07:15 +0000 (GMT) Date: Sun, 10 Nov 2024 18:07:14 +0100 From: Heiko Carstens To: "Masami Hiramatsu (Google)" Cc: Alexei Starovoitov , Steven Rostedt , Florent Revest , linux-trace-kernel@vger.kernel.org, LKML , Martin KaFai Lau , bpf , Alexei Starovoitov , Jiri Olsa , Alan Maguire , Mark Rutland , linux-arch@vger.kernel.org, Catalin Marinas , Will Deacon , Huacai Chen , WANG Xuerui , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Madhavan Srinivasan , Paul Walmsley , Palmer Dabbelt , Albert Ou , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Mathieu Desnoyers , Andrew Morton Subject: Re: [PATCH v19 12/19] fprobe: Rewrite fprobe on function-graph tracer Message-ID: <20241110170714.6661-D-hca@linux.ibm.com> References: <173125372214.172790.6929368952404083802.stgit@devnote2> <173125386944.172790.10278368602020246931.stgit@devnote2> Precedence: bulk X-Mailing-List: linux-arch@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <173125386944.172790.10278368602020246931.stgit@devnote2> X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: rdhWYV-Fr8MreJ0VWZbe0TF3N1RWiPHL X-Proofpoint-GUID: QTHKXNGy9oTA1Zp4hBNbPcOoy1xbMP0g X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-10-15_01,2024-10-11_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 malwarescore=0 mlxlogscore=457 lowpriorityscore=0 adultscore=0 mlxscore=0 impostorscore=0 bulkscore=0 phishscore=0 clxscore=1015 spamscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2409260000 definitions=main-2411100151 On Mon, Nov 11, 2024 at 12:51:09AM +0900, Masami Hiramatsu (Google) wrote: > From: Masami Hiramatsu (Google) > > Rewrite fprobe implementation on function-graph tracer. > Major API changes are: > - 'nr_maxactive' field is deprecated. > - This depends on CONFIG_DYNAMIC_FTRACE_WITH_ARGS or > !CONFIG_HAVE_DYNAMIC_FTRACE_WITH_ARGS, and > CONFIG_HAVE_FUNCTION_GRAPH_FREGS. So currently works only > on x86_64. > - Currently the entry size is limited in 15 * sizeof(long). > - If there is too many fprobe exit handler set on the same > function, it will fail to probe. > > Signed-off-by: Masami Hiramatsu (Google) > --- > arch/arm64/include/asm/ftrace.h | 6 > arch/loongarch/include/asm/ftrace.h | 6 > arch/powerpc/include/asm/ftrace.h | 6 > arch/riscv/include/asm/ftrace.h | 5 > arch/s390/include/asm/ftrace.h | 6 > arch/x86/include/asm/ftrace.h | 6 > include/linux/fprobe.h | 58 ++- > kernel/trace/Kconfig | 10 - > kernel/trace/fprobe.c | 637 +++++++++++++++++++++++++---------- > lib/test_fprobe.c | 45 -- > 10 files changed, 539 insertions(+), 246 deletions(-) ... > diff --git a/arch/s390/include/asm/ftrace.h b/arch/s390/include/asm/ftrace.h > index fd3f0fe9f7b3..a3b73a4f626e 100644 > --- a/arch/s390/include/asm/ftrace.h > +++ b/arch/s390/include/asm/ftrace.h > @@ -77,6 +77,12 @@ ftrace_regs_get_frame_pointer(struct ftrace_regs *fregs) > return ftrace_regs_get_stack_pointer(fregs); > } > > +static __always_inline unsigned long > +ftrace_regs_get_return_address(const struct ftrace_regs *fregs) > +{ > + return arch_ftrace_regs(fregs)->regs.gprs[14]; > +} > + Acked-by: Heiko Carstens # s390