Re: [PATCH v4 25/30] context_tracking,x86: Defer kernel text patching IPIs

K Prateek Nayak
2025-01-24T10:48:47Z

Hello Valentin,

On 1/14/2025 11:21 PM, Valentin Schneider wrote:
> [..snip..]
> diff --git a/include/linux/context_tracking_work.h b/include/linux/context_tracking_work.h
> index c68245f8d77c5..931ade1dcbcc2 100644
> --- a/include/linux/context_tracking_work.h
> +++ b/include/linux/context_tracking_work.h
> @@ -5,12 +5,12 @@
> #include <linux/bitops.h>
>
> enum {
> - CT_WORK_n_OFFSET,
> + CT_WORK_SYNC,

nit.

Shouldn't this be "CT_WORK_SYNC_OFFSET"?

I believe it gets fixed in Patch 29/30 when "CT_WORK_TLBI_OFFSET" is
added but perhaps that can be moved here to preserve bisection.

> CT_WORK_MAX_OFFSET
> };
>
> enum ct_work {
> - CT_WORK_n = BIT(CT_WORK_n_OFFSET),
> + CT_WORK_SYNC = BIT(CT_WORK_SYNC_OFFSET),
> CT_WORK_MAX = BIT(CT_WORK_MAX_OFFSET)
> };
>

--
Thanks and Regards,
Prateek