From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f51.google.com (mail-qv1-f51.google.com [209.85.219.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 139A91F03C9; Mon, 21 Apr 2025 16:42:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745253771; cv=none; b=aJF1sPNVkZGGYJ4HIwv7qbtaT+jb/5rtXkQudmhiVV1IDLXiiCQWuML1L4ZQTWjVW9j9oO8zo2ufH4aeg9JCQVS/4zaqpGr6yQXjzj6bz+y+wOXEXQd7cJ50nsUE2UzcSBDZrD9pzmVUYZVyKqwqmaW3kCon7E8k331g/iQZ29c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745253771; c=relaxed/simple; bh=ir9Jiu1Y1J4FXKxDOougVPhBcRyH5oNJ6vvblr33dic=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=OTc+uRGUke53BjX8JxFriD2GxIpPjJWm0du4qmks/D6amqinU3GIOXBK9nwa6mLzw7bsLsAShwJ2N4T4kPE0D4YqRBUfNAw+BYVaU6NklkKYcv52X7lYTDvyziXOYaq9k5LrFwp//5d/OYFsuziuQPmqmiwXpEoXfIMjR33yMqc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=T9WDzMWD; arc=none smtp.client-ip=209.85.219.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="T9WDzMWD" Received: by mail-qv1-f51.google.com with SMTP id 6a1803df08f44-6eeb7589db4so47912336d6.1; Mon, 21 Apr 2025 09:42:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745253768; x=1745858568; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:feedback-id:from:to:cc:subject :date:message-id:reply-to; bh=uMU54tdag8mXyAmWP+eFJWJLUiSas5VBnDSB0h2I5Ow=; b=T9WDzMWDeaUkn5VzGRPeLGJccyBtu5/vxujaB9Ma6CyYMg4mw2sYIVJXvLUDOYax/E j4Tmxsr6m4G0E0shr5BC9FzdFxhQNI7bmMuuet9/w2EWXDBPIP8WgOfbpHhvDX9LuDWQ mAFuZC/5DNyWqNFZjkbOAQI6x0JRCvLzqkKQ47WqDHWiGxI0pd0Qqy1ZGyLgTSWBSe9P GMyTcrmrzbrSAufx2bjstWM/J92haiEi2KevzWiPQkumHOA925puCcOs2dRboWeAOkWn xqpXEVu39YIY9jrO/VAnVnAb43zKOLj7t/cteSJDA4nDS/YCy7w0IjGb+2ZVCJJkxmBD WdUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745253768; x=1745858568; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:feedback-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=uMU54tdag8mXyAmWP+eFJWJLUiSas5VBnDSB0h2I5Ow=; b=haN8nbAETR+GBxO52LYPXQWVNWYhGQ0gbkVzqy3v4v9G4d/Jz7perN3evCfYWQ8jJV BTDD3P3Tz3WmOP0oDbbLw5ILZkfw3zsePpsR1tif9kOHmjyYJMVNcjNJB3J/+opkaCms mkh3sb/aSQFqqCnfIAwCs6IXP7vWyIYCovDNRqn/KHucSGfZYKkR2kMsF3rV8SeRypir pqgcuUyj6aGRs0LY1N7d3tJDlwOAoyOagbmJXt8h0Zwnb09UW0zw/CRNM0ofEpd2DCHq G7B22iIQtEbz3kehzmoLin1fDHuAEgKpwgTIcLOIpa1loRFUGF8CrodiJMvataVLeKJZ vPnA== X-Forwarded-Encrypted: i=1; AJvYcCUJG+ySefSiOG0CF5yFXfBU9J7g6hF+c3pJpkri16d2OvUIjYF/6zJgBfQ/vYWqciFEUquffvYgLX9CaUb4@vger.kernel.org, AJvYcCUiJS0LblW/RgkabqtRis9hCVgQPvflpEno9xsEIIl3+dzBjVszfoSOHL5Al8qX0j1hCdkUs9YN5+2aCdHQ9A==@vger.kernel.org, AJvYcCVtxopTXpdlt+kqtT0gxXD5DdPz1juMeJWng3NWrTISkczJ22Rl0sGZYQecm+AK194qOjLUSUc1N3bH@vger.kernel.org, AJvYcCWMFGI6Wf6PEoi21pGmvAFBvc0hZ1NHoT71b1cteaXWnFjLFLXh0lBwKPrcCZTVUBAiiYJ0@vger.kernel.org X-Gm-Message-State: AOJu0YyfEYdKhoiAnX5oqdKRTyEd3SUutWQOz7Ox4V4PslGQB34Ju43a 86HbrXx7Te4d/2lMrJw/sR9TTlTML8rqe9eCRzPBbKq45qw4BFmZ3UtOzQ== X-Gm-Gg: ASbGncut4q+fhstzwaLxS3skwM5v8suVj9k201kt7itPzCB4tVH3bIFWbRXE2LTzJW5 vWceS15KFINJDe5wrEt3jQHpAPdMSBO0SnAmFLDC9wDA1dJMCr4+mt+INCjP25Fw1TFBwlEgPxs XiYwrGKpjEn4CSnqyRdby7sr9ZXeSb1u/K28bceN+b/oZwNVclLVSKppZ7HVmUg+2cnA8L5D/5c 17CzCTCusZ9jaS7Guu3XPLuxR95AKYTtdDAFjXPT3NhoPAkUiB6Ru0BDAsh5nfi85I96JpQGgtM kWtL9buVrtnuxnF2tGe18j3en2qgOQh9o6vYaOIGkb5OEANCyLaqMgcxs2aBpNDqBpIgqqhCvpA NIYAXwi8bO6qDn+3gsQqCvUekNbpJc5p02L6jDpd7aw== X-Google-Smtp-Source: AGHT+IGU0JcGAhVuULdUx6Z4ZKxYf32ZP2BkzbnQ+QciqlajuN2LNG68/aiDW+Pw4v75CJt6Z5kDGA== X-Received: by 2002:ad4:5b83:0:b0:6ed:122c:7da7 with SMTP id 6a1803df08f44-6f2c4509511mr225275636d6.5.1745253767862; Mon, 21 Apr 2025 09:42:47 -0700 (PDT) Received: from fauth-a2-smtp.messagingengine.com (fauth-a2-smtp.messagingengine.com. [103.168.172.201]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6f2c2b0cb51sm45755526d6.31.2025.04.21.09.42.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Apr 2025 09:42:47 -0700 (PDT) Received: from phl-compute-03.internal (phl-compute-03.phl.internal [10.202.2.43]) by mailfauth.phl.internal (Postfix) with ESMTP id 25E5B1200043; Mon, 21 Apr 2025 12:42:47 -0400 (EDT) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-03.internal (MEProxy); Mon, 21 Apr 2025 12:42:47 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddvgedufeeiucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggv pdfurfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpih gvnhhtshculddquddttddmnecujfgurhephffvvefufffkofgjfhgggfestdekredtredt tdenucfhrhhomhepuehoqhhunhcuhfgvnhhguceosghoqhhunhdrfhgvnhhgsehgmhgrih hlrdgtohhmqeenucggtffrrghtthgvrhhnpeegleejiedthedvheeggfejveefjeejkefg veffieeujefhueeigfegueehgeeggfenucevlhhushhtvghrufhiiigvpedtnecurfgrrh grmhepmhgrihhlfhhrohhmpegsohhquhhnodhmvghsmhhtphgruhhthhhpvghrshhonhgr lhhithihqdeiledvgeehtdeigedqudejjeekheehhedvqdgsohhquhhnrdhfvghngheppe hgmhgrihhlrdgtohhmsehfihigmhgvrdhnrghmvgdpnhgspghrtghpthhtohepheeipdhm ohguvgepshhmthhpohhuthdprhgtphhtthhopehruhhsthdqfhhorhdqlhhinhhugiesvh hgvghrrdhkvghrnhgvlhdrohhrghdprhgtphhtthhopehrtghusehvghgvrhdrkhgvrhhn vghlrdhorhhgpdhrtghpthhtoheplhhinhhugidqkhgvrhhnvghlsehvghgvrhdrkhgvrh hnvghlrdhorhhgpdhrtghpthhtoheplhhinhhugidqrghrtghhsehvghgvrhdrkhgvrhhn vghlrdhorhhgpdhrtghpthhtoheplhhlvhhmsehlihhsthhsrdhlihhnuhigrdguvghvpd hrtghpthhtoheplhhkmhhmsehlihhsthhsrdhlihhnuhigrdguvghvpdhrtghpthhtohep ohhjvggurgeskhgvrhhnvghlrdhorhhgpdhrtghpthhtoheprghlvgigrdhgrgihnhhorh esghhmrghilhdrtghomhdprhgtphhtthhopegsohhquhhnrdhfvghnghesghhmrghilhdr tghomh X-ME-Proxy: Feedback-ID: iad51458e:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 21 Apr 2025 12:42:46 -0400 (EDT) From: Boqun Feng To: rust-for-linux@vger.kernel.org, rcu@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, llvm@lists.linux.dev, lkmm@lists.linux.dev Cc: Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?UTF-8?q?Bj=C3=B6rn=20Roy=20Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Alan Stern , Andrea Parri , Will Deacon , Peter Zijlstra , Nicholas Piggin , David Howells , Jade Alglave , Luc Maranget , "Paul E. McKenney" , Akira Yokosawa , Daniel Lustig , Joel Fernandes , Nathan Chancellor , Nick Desaulniers , kent.overstreet@gmail.com, Greg Kroah-Hartman , elver@google.com, Mark Rutland , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Catalin Marinas , torvalds@linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-fsdevel@vger.kernel.org, Trevor Gross , dakr@redhat.com, Frederic Weisbecker , Neeraj Upadhyay , Josh Triplett , Uladzislau Rezki , Steven Rostedt , Mathieu Desnoyers , Lai Jiangshan , Zqiang , Paul Walmsley , Palmer Dabbelt , Albert Ou , linux-riscv@lists.infradead.org Subject: [RFC v3 10/12] rust: sync: atomic: Add arithmetic ops for Atomic<*mut T> Date: Mon, 21 Apr 2025 09:42:19 -0700 Message-ID: <20250421164221.1121805-11-boqun.feng@gmail.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20250421164221.1121805-1-boqun.feng@gmail.com> References: <20250421164221.1121805-1-boqun.feng@gmail.com> Precedence: bulk X-Mailing-List: linux-arch@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit (This is more an RFC) Add arithmetic operations support for `Atomic<*mut T>`. Currently the semantics of arithmetic atomic operation is the same as pointer arithmetic, that is, e.g. `Atomic<*mut u64>::add(1)` is adding 8 (`size_of::`) to the pointer value. In Rust std library, there are two sets of pointer arithmetic for `AtomicPtr`: * ptr_add() and ptr_sub(), which is the same as Atomic<*mut T>::add(), pointer arithmetic. * byte_add() and byte_sub(), which use the input as byte offset to change the pointer value, e.g. byte_add(1) means adding 1 to the pointer value. We can either take the approach in the current patch and add byte_add() later on if needed, or start with ptr_add() and byte_add() naming. Signed-off-by: Boqun Feng --- rust/kernel/sync/atomic.rs | 29 +++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+) diff --git a/rust/kernel/sync/atomic.rs b/rust/kernel/sync/atomic.rs index ffec46e50a06..f2dd72c531fd 100644 --- a/rust/kernel/sync/atomic.rs +++ b/rust/kernel/sync/atomic.rs @@ -197,3 +197,32 @@ fn from_repr(repr: Self::Repr) -> Self { repr as _ } } + +/// ```rust +/// use kernel::sync::atomic::{Atomic, Relaxed}; +/// +/// let s: &mut [i32] = &mut [1, 3, 2, 4]; +/// +/// let x = Atomic::new(s.as_mut_ptr()); +/// +/// x.add(1, Relaxed); +/// +/// let ptr = x.fetch_add(1, Relaxed); // points to the 2nd element. +/// let ptr2 = x.load(Relaxed); // points to the 3rd element. +/// +/// // SAFETY: `ptr` and `ptr2` are valid pointers to the 2nd and 3rd elements of `s` with writing +/// // provenance, and no other thread is accessing these elements. +/// unsafe { core::ptr::swap(ptr, ptr2); } +/// +/// assert_eq!(s, &mut [1, 2, 3, 4]); +/// ``` +impl generic::AllowAtomicArithmetic for *mut T { + type Delta = isize; + + /// The behavior of arithmetic operations + fn delta_into_repr(d: Self::Delta) -> Self::Repr { + // Since atomic arithmetic operations are wrapping, so a wrapping_mul() here suffices even + // if overflow may happen. + d.wrapping_mul(core::mem::size_of::() as _) as _ + } +} -- 2.47.1