From: Steven Rostedt <rostedt@goodmis.org>
To: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-trace-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org,
llvm@lists.linux.dev
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Masami Hiramatsu <mhiramat@kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
Masahiro Yamada <masahiroy@kernel.org>,
Nathan Chancellor <nathan@kernel.org>,
Nicolas Schier <nicolas.schier@linux.dev>,
Nick Desaulniers <nick.desaulniers+lkml@gmail.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v2 0/5] tracepoints: Add warnings for unused tracepoints and trace events
Date: Fri, 13 Jun 2025 10:42:40 -0400 [thread overview]
Message-ID: <20250613104240.509ff13c@batman.local.home> (raw)
In-Reply-To: <20250613102834.539bd849@batman.local.home>
[-- Attachment #1: Type: text/plain, Size: 1028 bytes --]
On Fri, 13 Jun 2025 10:28:34 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:
> And each DEFINE_EVENT() is approximately 1296 bytes.
> ((19559 - 2069) - 5819) / 9
Interesting enough, just raw tracepoints are not much better. I updated
the header file (attached) to have 10 of these, and compiled that.
DECLARE_TRACE(size_event_1,
TP_PROTO(struct size_event_struct *A, struct size_event_struct *B),
TP_ARGS(A, B));
The result is:
text data bss dec hex filename
629 1440 0 2069 815 no-events.ko
44837 15424 0 60261 eb65 trace-events.ko
11495 8064 0 19559 4c67 define-events.ko
10865 4408 0 15273 3ba9 declare-trace.ko
Where each DECLARE_TRACE() ends up being 1320 bytes.
(15273 - 2069) / 10
This is slightly bigger than a DEFINE_EVENT(), but that's also because
the DEFINE_EVENT() shares some of the tracepoint creation in the
DECLARE_EVENT_CLASS(), where as that work is done fully in the
DECLARE_TRACE().
-- Steve
[-- Attachment #2: size_events.h --]
[-- Type: text/x-chdr, Size: 7840 bytes --]
/* SPDX-License-Identifier: GPL-2.0 */
#undef TRACE_SYSTEM
#define TRACE_SYSTEM event-sizes
#undef TRACE_SYSTEM_VAR
#define TRACE_SYSTEM_VAR event_sizes
#if !defined(_SIZE_EVENT_H) || defined(TRACE_HEADER_MULTI_READ)
#define _SIZE_EVENT_H
#include <linux/tracepoint.h>
#ifndef SIZE_EVENT_DEFINED
#define SIZE_EVENT_DEFINED
struct size_event_struct {
unsigned long a;
unsigned long b;
};
#endif
#define DEFINE_EVENT_SIZES 0
#define DEFINE_FULL_EVENTS 0
#define DEFINE_JUST_TRACEPOINTS 1
#if DEFINE_EVENT_SIZES
TRACE_EVENT(size_event_1,
TP_PROTO(struct size_event_struct *A, struct size_event_struct *B),
TP_ARGS(A, B),
TP_STRUCT__entry(
__field( unsigned long, Aa)
__field( unsigned long, Ab)
__field( unsigned long, Ba)
__field( unsigned long, Bb)
),
TP_fast_assign(
__entry->Aa = A->a;
__entry->Ab = A->b;
__entry->Ba = B->a;
__entry->Bb = B->b;
),
TP_printk("Aa=%ld Ab=%ld Ba=%ld Bb=%ld",
__entry->Aa, __entry->Ab, __entry->Ba, __entry->Bb)
);
#if DEFINE_FULL_EVENTS
TRACE_EVENT(size_event_2,
TP_PROTO(struct size_event_struct *A, struct size_event_struct *B),
TP_ARGS(A, B),
TP_STRUCT__entry(
__field( unsigned long, Aa)
__field( unsigned long, Ab)
__field( unsigned long, Ba)
__field( unsigned long, Bb)
),
TP_fast_assign(
__entry->Aa = A->a;
__entry->Ab = A->b;
__entry->Ba = B->a;
__entry->Bb = B->b;
),
TP_printk("Aa=%ld Ab=%ld Ba=%ld Bb=%ld",
__entry->Aa, __entry->Ab, __entry->Ba, __entry->Bb)
);
TRACE_EVENT(size_event_3,
TP_PROTO(struct size_event_struct *A, struct size_event_struct *B),
TP_ARGS(A, B),
TP_STRUCT__entry(
__field( unsigned long, Aa)
__field( unsigned long, Ab)
__field( unsigned long, Ba)
__field( unsigned long, Bb)
),
TP_fast_assign(
__entry->Aa = A->a;
__entry->Ab = A->b;
__entry->Ba = B->a;
__entry->Bb = B->b;
),
TP_printk("Aa=%ld Ab=%ld Ba=%ld Bb=%ld",
__entry->Aa, __entry->Ab, __entry->Ba, __entry->Bb)
);
TRACE_EVENT(size_event_4,
TP_PROTO(struct size_event_struct *A, struct size_event_struct *B),
TP_ARGS(A, B),
TP_STRUCT__entry(
__field( unsigned long, Aa)
__field( unsigned long, Ab)
__field( unsigned long, Ba)
__field( unsigned long, Bb)
),
TP_fast_assign(
__entry->Aa = A->a;
__entry->Ab = A->b;
__entry->Ba = B->a;
__entry->Bb = B->b;
),
TP_printk("Aa=%ld Ab=%ld Ba=%ld Bb=%ld",
__entry->Aa, __entry->Ab, __entry->Ba, __entry->Bb)
);
TRACE_EVENT(size_event_5,
TP_PROTO(struct size_event_struct *A, struct size_event_struct *B),
TP_ARGS(A, B),
TP_STRUCT__entry(
__field( unsigned long, Aa)
__field( unsigned long, Ab)
__field( unsigned long, Ba)
__field( unsigned long, Bb)
),
TP_fast_assign(
__entry->Aa = A->a;
__entry->Ab = A->b;
__entry->Ba = B->a;
__entry->Bb = B->b;
),
TP_printk("Aa=%ld Ab=%ld Ba=%ld Bb=%ld",
__entry->Aa, __entry->Ab, __entry->Ba, __entry->Bb)
);
TRACE_EVENT(size_event_6,
TP_PROTO(struct size_event_struct *A, struct size_event_struct *B),
TP_ARGS(A, B),
TP_STRUCT__entry(
__field( unsigned long, Aa)
__field( unsigned long, Ab)
__field( unsigned long, Ba)
__field( unsigned long, Bb)
),
TP_fast_assign(
__entry->Aa = A->a;
__entry->Ab = A->b;
__entry->Ba = B->a;
__entry->Bb = B->b;
),
TP_printk("Aa=%ld Ab=%ld Ba=%ld Bb=%ld",
__entry->Aa, __entry->Ab, __entry->Ba, __entry->Bb)
);
TRACE_EVENT(size_event_7,
TP_PROTO(struct size_event_struct *A, struct size_event_struct *B),
TP_ARGS(A, B),
TP_STRUCT__entry(
__field( unsigned long, Aa)
__field( unsigned long, Ab)
__field( unsigned long, Ba)
__field( unsigned long, Bb)
),
TP_fast_assign(
__entry->Aa = A->a;
__entry->Ab = A->b;
__entry->Ba = B->a;
__entry->Bb = B->b;
),
TP_printk("Aa=%ld Ab=%ld Ba=%ld Bb=%ld",
__entry->Aa, __entry->Ab, __entry->Ba, __entry->Bb)
);
TRACE_EVENT(size_event_8,
TP_PROTO(struct size_event_struct *A, struct size_event_struct *B),
TP_ARGS(A, B),
TP_STRUCT__entry(
__field( unsigned long, Aa)
__field( unsigned long, Ab)
__field( unsigned long, Ba)
__field( unsigned long, Bb)
),
TP_fast_assign(
__entry->Aa = A->a;
__entry->Ab = A->b;
__entry->Ba = B->a;
__entry->Bb = B->b;
),
TP_printk("Aa=%ld Ab=%ld Ba=%ld Bb=%ld",
__entry->Aa, __entry->Ab, __entry->Ba, __entry->Bb)
);
TRACE_EVENT(size_event_9,
TP_PROTO(struct size_event_struct *A, struct size_event_struct *B),
TP_ARGS(A, B),
TP_STRUCT__entry(
__field( unsigned long, Aa)
__field( unsigned long, Ab)
__field( unsigned long, Ba)
__field( unsigned long, Bb)
),
TP_fast_assign(
__entry->Aa = A->a;
__entry->Ab = A->b;
__entry->Ba = B->a;
__entry->Bb = B->b;
),
TP_printk("Aa=%ld Ab=%ld Ba=%ld Bb=%ld",
__entry->Aa, __entry->Ab, __entry->Ba, __entry->Bb)
);
TRACE_EVENT(size_event_10,
TP_PROTO(struct size_event_struct *A, struct size_event_struct *B),
TP_ARGS(A, B),
TP_STRUCT__entry(
__field( unsigned long, Aa)
__field( unsigned long, Ab)
__field( unsigned long, Ba)
__field( unsigned long, Bb)
),
TP_fast_assign(
__entry->Aa = A->a;
__entry->Ab = A->b;
__entry->Ba = B->a;
__entry->Bb = B->b;
),
TP_printk("Aa=%ld Ab=%ld Ba=%ld Bb=%ld",
__entry->Aa, __entry->Ab, __entry->Ba, __entry->Bb)
);
#else /* !DEFINE_FULL_EVENTS */
DEFINE_EVENT(size_event_1, size_event_2,
TP_PROTO(struct size_event_struct *A, struct size_event_struct *B),
TP_ARGS(A, B));
DEFINE_EVENT(size_event_1, size_event_3,
TP_PROTO(struct size_event_struct *A, struct size_event_struct *B),
TP_ARGS(A, B));
DEFINE_EVENT(size_event_1, size_event_4,
TP_PROTO(struct size_event_struct *A, struct size_event_struct *B),
TP_ARGS(A, B));
DEFINE_EVENT(size_event_1, size_event_5,
TP_PROTO(struct size_event_struct *A, struct size_event_struct *B),
TP_ARGS(A, B));
DEFINE_EVENT(size_event_1, size_event_6,
TP_PROTO(struct size_event_struct *A, struct size_event_struct *B),
TP_ARGS(A, B));
DEFINE_EVENT(size_event_1, size_event_7,
TP_PROTO(struct size_event_struct *A, struct size_event_struct *B),
TP_ARGS(A, B));
DEFINE_EVENT(size_event_1, size_event_8,
TP_PROTO(struct size_event_struct *A, struct size_event_struct *B),
TP_ARGS(A, B));
DEFINE_EVENT(size_event_1, size_event_9,
TP_PROTO(struct size_event_struct *A, struct size_event_struct *B),
TP_ARGS(A, B));
DEFINE_EVENT(size_event_1, size_event_10,
TP_PROTO(struct size_event_struct *A, struct size_event_struct *B),
TP_ARGS(A, B));
#endif /* !DEFINE_FULL_EVENTS */
#elif DEFINE_JUST_TRACEPOINTS
DECLARE_TRACE(size_event_1,
TP_PROTO(struct size_event_struct *A, struct size_event_struct *B),
TP_ARGS(A, B));
DECLARE_TRACE(size_event_2,
TP_PROTO(struct size_event_struct *A, struct size_event_struct *B),
TP_ARGS(A, B));
DECLARE_TRACE(size_event_3,
TP_PROTO(struct size_event_struct *A, struct size_event_struct *B),
TP_ARGS(A, B));
DECLARE_TRACE(size_event_4,
TP_PROTO(struct size_event_struct *A, struct size_event_struct *B),
TP_ARGS(A, B));
DECLARE_TRACE(size_event_5,
TP_PROTO(struct size_event_struct *A, struct size_event_struct *B),
TP_ARGS(A, B));
DECLARE_TRACE(size_event_6,
TP_PROTO(struct size_event_struct *A, struct size_event_struct *B),
TP_ARGS(A, B));
DECLARE_TRACE(size_event_7,
TP_PROTO(struct size_event_struct *A, struct size_event_struct *B),
TP_ARGS(A, B));
DECLARE_TRACE(size_event_8,
TP_PROTO(struct size_event_struct *A, struct size_event_struct *B),
TP_ARGS(A, B));
DECLARE_TRACE(size_event_9,
TP_PROTO(struct size_event_struct *A, struct size_event_struct *B),
TP_ARGS(A, B));
DECLARE_TRACE(size_event_10,
TP_PROTO(struct size_event_struct *A, struct size_event_struct *B),
TP_ARGS(A, B));
#endif /* DEFINE_EVENT_SIZES && DEFINE_JUST_TRACEPOINTS */
#endif
/***** NOTICE! The #if protection ends here. *****/
#undef TRACE_INCLUDE_PATH
#undef TRACE_INCLUDE_FILE
#define TRACE_INCLUDE_PATH .
#define TRACE_INCLUDE_FILE size_events
#include <trace/define_trace.h>
prev parent reply other threads:[~2025-06-13 14:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-12 23:58 [PATCH v2 0/5] tracepoints: Add warnings for unused tracepoints and trace events Steven Rostedt
2025-06-12 23:58 ` [PATCH v2 1/5] tracepoints: Add verifier that makes sure all defined tracepoints are used Steven Rostedt
2025-06-12 23:58 ` [PATCH v2 2/5] tracing: sorttable: Add a tracepoint verification check at build time Steven Rostedt
2025-06-12 23:58 ` [PATCH v2 3/5] tracing: sorttable: Find unused tracepoints for arm64 that uses reloc for address Steven Rostedt
2025-06-12 23:58 ` [PATCH v2 4/5] tracepoint: Do not warn for unused event that is exported Steven Rostedt
2025-06-12 23:58 ` [PATCH v2 5/5] tracing: Call trace_ftrace_test_filter() for the event Steven Rostedt
2025-06-13 0:05 ` [PATCH v2 0/5] tracepoints: Add warnings for unused tracepoints and trace events Steven Rostedt
2025-06-13 3:20 ` Randy Dunlap
2025-06-13 12:07 ` Steven Rostedt
2025-06-13 14:28 ` Steven Rostedt
2025-06-13 14:42 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250613104240.509ff13c@batman.local.home \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=masahiroy@kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=nathan@kernel.org \
--cc=nick.desaulniers+lkml@gmail.com \
--cc=nicolas.schier@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).