From: Al Viro <viro@zeniv.linux.org.uk>
To: linux-arch@vger.kernel.org
Cc: Arnd Bergmann <arnd@arndb.de>, Guo Ren <guoren@kernel.org>,
linux-alpha@vger.kernel.org,
Geert Uytterhoeven <geert@linux-m68k.org>,
Michal Simek <monstr@monstr.eu>,
Max Filippov <jcmvbkbc@gmail.com>,
Jonas Bonn <jonas@southpole.se>
Subject: [PATCH 6/6] alpha: unobfuscate _PAGE_P() definition
Date: Thu, 11 Sep 2025 02:55:08 +0100 [thread overview]
Message-ID: <20250911015508.GF2604499@ZenIV> (raw)
In-Reply-To: <20250911015124.GV31600@ZenIV>
Way, way back it used to be
_PAGE_NORMAL((x) | ((x & _PAGE_FOW) ? 0 : _PAGE_FOW | _PAGE_COW))
Then (in 1.3.54) _PAGE_COW had died. Result:
_PAGE_NORMAL((x) | ((x & _PAGE_FOW) ? 0 : _PAGE_FOW))
which is somewhat... obscure. What it does is simply
_PAGE_NORMAL((x) | _PAGE_FOW)
and IMO that's easier to follow.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
---
arch/alpha/include/asm/pgtable.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/alpha/include/asm/pgtable.h b/arch/alpha/include/asm/pgtable.h
index 84014e9be504..90e7a9539102 100644
--- a/arch/alpha/include/asm/pgtable.h
+++ b/arch/alpha/include/asm/pgtable.h
@@ -107,7 +107,7 @@ struct vm_area_struct;
#define _PAGE_NORMAL(x) __pgprot(_PAGE_VALID | __ACCESS_BITS | (x))
-#define _PAGE_P(x) _PAGE_NORMAL((x) | (((x) & _PAGE_FOW)?0:_PAGE_FOW))
+#define _PAGE_P(x) _PAGE_NORMAL((x) | _PAGE_FOW)
#define _PAGE_S(x) _PAGE_NORMAL(x)
/*
--
2.47.2
prev parent reply other threads:[~2025-09-11 1:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-11 1:51 [PATCHES] misc dead code removals in arch/* - mostly asm/pgtable.h Al Viro
2025-09-11 1:52 ` [PATCH 1/6] csky: remove BS check for FAULT_FLAG_ALLOW_RETRY Al Viro
2025-09-11 2:55 ` Guo Ren
2025-09-11 1:53 ` [PATCH 2/6][alpha,m68k,openrisc] PAGE_PTR() had been last used outside of arch/* in 1.1.94 Al Viro
2025-09-11 7:29 ` Geert Uytterhoeven
2025-09-11 1:53 ` [PATCH 3/6][openrisc] SET_PAGE_DIR() users had been gone since 2.3.12pre1 Al Viro
2025-09-11 1:54 ` [PATCH 4/6] alpha: get rid of the remnants of BAD_PAGE and friends Al Viro
2025-09-11 1:54 ` [PATCH 5/6][microblaze,xtensa] kill FIRST_USER_PGD_NR Al Viro
2025-09-11 14:57 ` Max Filippov
2025-09-15 6:42 ` Michal Simek
2025-09-11 1:55 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250911015508.GF2604499@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=arnd@arndb.de \
--cc=geert@linux-m68k.org \
--cc=guoren@kernel.org \
--cc=jcmvbkbc@gmail.com \
--cc=jonas@southpole.se \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=monstr@monstr.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).