From: Nathan Chancellor <nathan@kernel.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Qi Xi <xiqi2@huawei.com>,
bobo.shaobowang@huawei.com, xiexiuqi@huawei.com,
linux-kernel@vger.kernel.org,
Masahiro Yamada <masahiroy@kernel.org>,
Jakub Kicinski <kuba@kernel.org>,
Eric Dumazet <edumazet@google.com>,
Linux-Arch <linux-arch@vger.kernel.org>,
linux-kbuild@vger.kernel.org, Nicolas Schier <nicolas@fjasle.eu>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v3] once: fix race by moving DO_ONCE to separate section
Date: Thu, 25 Sep 2025 20:19:43 -0400 [thread overview]
Message-ID: <20250926001943.GA1080352@ax162> (raw)
In-Reply-To: <3de848cc-0f01-4999-a4fc-1ff3cc11daa4@app.fastmail.com>
On Thu, Sep 25, 2025 at 08:14:35AM +0200, Arnd Bergmann wrote:
> I hadn't seen this until your ping and had a look since it
> touches asm-generic. The patch looks correct to me, thanks for
> addressing this and for the detailed patch description.
Agreed, I am not super familiar with this infrastructure but this seems
correct from my basic understanding.
> I think what happened is that nobody felt responsible for
> applying it, between the networking (which originally
> added the infrastructure) and kbuild maintainers (Masahiro
> did the last changes to this bit, but recently handed
> over maintenance to Nathan).
Yeah, that seems likely. For the record, I would not have felt
responsible for this code even if it was Cc'd to me since this does not
read as Kbuild material to me.
> I've applied the fix to the asm-generic tree for 6.18 now
> to be sure that it makes it in and gets linux-next testing,
> but it's not my area either really.
>
> It would be best to have another review though. If Nathan
> or Andrew want to instead pick it up through one of their
> trees, please add
>
> Acked-by: Arnd Bergmann <arnd@arndb.de>
I do not have a strong opinion on whether you or Andrew take it (I think
it makes sense either way) but I do not think it makes sense for me to
take it via Kbuild.
Cheers,
Nathan
prev parent reply other threads:[~2025-09-26 0:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-09 11:29 [PATCH v3] once: fix race by moving DO_ONCE to separate section Qi Xi
2025-09-09 12:01 ` Qi Xi
2025-09-25 1:49 ` Qi Xi
2025-09-25 6:14 ` Arnd Bergmann
2025-09-26 0:19 ` Nathan Chancellor [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250926001943.GA1080352@ax162 \
--to=nathan@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=bobo.shaobowang@huawei.com \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=nicolas@fjasle.eu \
--cc=xiexiuqi@huawei.com \
--cc=xiqi2@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox