Re: [PATCH] asm-generic: replace ________addr with __UNIQUE_ID(addr)

Andrew Morton
2026-04-25T22:12:40Z

On Sat, 25 Apr 2026 23:01:34 +0100 David Laight <david.laight.linux@gmail.com> wrote:

> > > The real problem with this define is that both idx and phys are
> > > expanded twice.
> >
> > The real problem with this define is that it's a define. Why oh why do
> > we keep doing this to ourselves?
>
> Sometimes #defines generate better code because they are expanded earlier,
> and sometimes you want type-agnostic 'functions'.
> But neither is true here.
>
> But I think I'd go for 'always_inline'.
> Sometimes the compilers make silly decisions.

Gee, if `static inline' misbehaves then we have big problems!

What's special about the fixmap code anyway? It's not exactly
fastpath. Perhaps this stuff can simply be uninlined.

Pet peeves:

We use too many macros.

We inline too much stuff.