From: Bjorn Helgaas <helgaas@kernel.org>
To: Mukesh R <mrathor@linux.microsoft.com>
Cc: hpa@zytor.com, robin.murphy@arm.com, robh@kernel.org,
wei.liu@kernel.org, mhklinux@outlook.com, muislam@microsoft.com,
namjain@linux.microsoft.com, magnuskulke@linux.microsoft.com,
anbelski@linux.microsoft.com, linux-kernel@vger.kernel.org,
linux-hyperv@vger.kernel.org, iommu@lists.linux.dev,
linux-pci@vger.kernel.org, linux-arch@vger.kernel.org,
kys@microsoft.com, haiyangz@microsoft.com, decui@microsoft.com,
longli@microsoft.com, tglx@kernel.org, mingo@redhat.com,
bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org,
joro@8bytes.org, will@kernel.org, lpieralisi@kernel.org,
kwilczynski@kernel.org, bhelgaas@google.com, arnd@arndb.de
Subject: Re: [PATCH V2 08/11] PCI: hv: Build device id for a VMBus device, export PCI devid function
Date: Fri, 1 May 2026 11:33:43 -0500 [thread overview]
Message-ID: <20260501163343.GA489081@bhelgaas> (raw)
In-Reply-To: <20260501004157.3108202-9-mrathor@linux.microsoft.com>
s/id/ID/ in subject.
I don't know if the "export PCI devid function" part is essential in
the subject. If it is, I don't know whether that refers to
hv_build_devid_type_pci() of hv_pci_vmbus_device_id(). Both are
exported by this patch. Could just mention the actual name instead of
"PCI devid function" or could make the exports a separate patch.
On Thu, Apr 30, 2026 at 05:41:54PM -0700, Mukesh R wrote:
> On Hyper-V, most hypercalls related to PCI passthru to map/unmap regions,
> interrupts, etc need a device ID as a parameter. This device ID refers
> to that specific device during the lifetime of passthru.
> +++ b/include/asm-generic/mshyperv.h
> @@ -23,6 +23,7 @@
> #include <acpi/acpi_numa.h>
> #include <linux/cpumask.h>
> #include <linux/nmi.h>
> +#include <linux/pci.h>
It doesn't look like mshyperv.h actually needs the definition, so you
probably don't need to include pci.h. A "struct pci_dev;" declaration
should be sufficient.
> #include <asm/ptrace.h>
> #include <hyperv/hvhdk.h>
>
> @@ -329,6 +330,13 @@ static inline enum hv_isolation_type hv_get_isolation_type(void)
> }
> #endif /* CONFIG_HYPERV */
>
> +#if IS_ENABLED(CONFIG_PCI_HYPERV)
> +u64 hv_pci_vmbus_device_id(struct pci_dev *pdev);
> +#else
> +static inline u64 hv_pci_vmbus_device_id(struct pci_dev *pdev)
> +{ return 0; }
> +#endif /* IS_ENABLED(CONFIG_PCI_HYPERV) */
> +
> #if IS_ENABLED(CONFIG_MSHV_ROOT)
> static inline bool hv_root_partition(void)
> {
> --
> 2.51.2.vfs.0.1
>
next prev parent reply other threads:[~2026-05-01 16:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-01 0:41 [PATCH V2 00/11] PCI passthru on Hyper-V (Part I) Mukesh R
2026-05-01 0:41 ` [PATCH V2 01/11] iommu/hyperv: rename hyperv-iommu.c to hyperv-irq.c Mukesh R
2026-05-01 0:41 ` [PATCH V2 02/11] x86/hyperv: cosmetic changes in irqdomain.c for readability Mukesh R
2026-05-01 0:41 ` [PATCH V2 03/11] mshv: Provide a way to get partition id if running in a VMM process Mukesh R
2026-05-01 0:41 ` [PATCH V2 04/11] mshv: Declarations and definitions for VFIO-MSHV bridge device Mukesh R
2026-05-01 0:41 ` [PATCH V2 05/11] mshv: Implement mshv bridge device for VFIO Mukesh R
2026-05-01 0:41 ` [PATCH V2 06/11] mshv: Add ioctl support for MSHV-VFIO bridge device Mukesh R
2026-05-01 0:41 ` [PATCH V2 07/11] mshv: Import data structs around device passthru from hyperv headers Mukesh R
2026-05-01 0:41 ` [PATCH V2 08/11] PCI: hv: Build device id for a VMBus device, export PCI devid function Mukesh R
2026-05-01 16:33 ` Bjorn Helgaas [this message]
2026-05-01 18:38 ` Easwar Hariharan
2026-05-01 0:41 ` [PATCH V2 09/11] x86/hyperv: Implement hyperv virtual IOMMU Mukesh R
2026-05-01 0:41 ` [PATCH V2 10/11] mshv: Populate mmio mappings for PCI passthru Mukesh R
2026-05-01 0:41 ` [PATCH V2 11/11] mshv: Mark mem regions as non-movable upfront if device passthru Mukesh R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260501163343.GA489081@bhelgaas \
--to=helgaas@kernel.org \
--cc=anbelski@linux.microsoft.com \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=decui@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=hpa@zytor.com \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=kwilczynski@kernel.org \
--cc=kys@microsoft.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=longli@microsoft.com \
--cc=lpieralisi@kernel.org \
--cc=magnuskulke@linux.microsoft.com \
--cc=mhklinux@outlook.com \
--cc=mingo@redhat.com \
--cc=mrathor@linux.microsoft.com \
--cc=muislam@microsoft.com \
--cc=namjain@linux.microsoft.com \
--cc=robh@kernel.org \
--cc=robin.murphy@arm.com \
--cc=tglx@kernel.org \
--cc=wei.liu@kernel.org \
--cc=will@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox