From: Kees Cook <kees@kernel.org>
To: guoren@kernel.org
Cc: arnd@arndb.de, palmer@rivosinc.com, tglx@linutronix.de,
peterz@infradead.org, luto@kernel.org,
conor.dooley@microchip.com, heiko@sntech.de, jszhang@kernel.org,
lazyparser@gmail.com, falcon@tinylab.org, chenhuacai@kernel.org,
apatel@ventanamicro.com, atishp@atishpatra.org,
mark.rutland@arm.com, bjorn@kernel.org, palmer@dabbelt.com,
bjorn@rivosinc.com, daniel.thompson@linaro.org,
linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-riscv@lists.infradead.org, stable@vger.kernel.org,
Guo Ren <guoren@linux.alibaba.com>
Subject: Re: [PATCH] riscv: entry: Fixup do_trap_break from kernel side
Date: Fri, 19 Jun 2026 16:54:53 -0700 [thread overview]
Message-ID: <202606191652.38297DE51@keescook> (raw)
In-Reply-To: <20230702025708.784106-1-guoren@kernel.org>
*thread encromancy*
On Sat, Jul 01, 2023 at 10:57:07PM -0400, guoren@kernel.org wrote:
> From: Guo Ren <guoren@linux.alibaba.com>
>
> The irqentry_nmi_enter/exit would force the current context into in_interrupt.
> That would trigger the kernel to dead panic, but the kdb still needs "ebreak" to
> debug the kernel.
>
> Move irqentry_nmi_enter/exit to exception_enter/exit could correct handle_break
> of the kernel side.
>
> Before the fixup:
> $echo BUG > /sys/kernel/debug/provoke-crash/DIRECT
> lkdtm: Performing direct entry BUG
> ------------[ cut here ]------------
> kernel BUG at drivers/misc/lkdtm/bugs.c:78!
> [...]
> Kernel panic - not syncing: Aiee, killing interrupt handler!
This appears to still be unfixed. What's the blocker? The solutions in
this thread seem to work...
I'd like to be exercising an Oops path via KUnit (for KCFI), and riscv
just instantly falls over instead of thread-killing on the exception.
Thanks!
-Kees
--
Kees Cook
next prev parent reply other threads:[~2026-06-19 23:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-02 2:57 [PATCH] riscv: entry: Fixup do_trap_break from kernel side guoren
2023-07-03 10:29 ` Daniel Thompson
2023-07-04 2:44 ` Guo Ren
2023-07-04 16:40 ` Peter Zijlstra
2023-07-04 17:34 ` Daniel Thompson
2023-07-09 2:30 ` Guo Ren
2023-07-10 8:01 ` Peter Zijlstra
2023-07-16 23:33 ` Guo Ren
2023-07-17 10:45 ` Peter Zijlstra
2023-07-17 16:14 ` Guo Ren
2026-06-19 23:54 ` Kees Cook [this message]
2026-06-21 6:52 ` Guo Ren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202606191652.38297DE51@keescook \
--to=kees@kernel.org \
--cc=apatel@ventanamicro.com \
--cc=arnd@arndb.de \
--cc=atishp@atishpatra.org \
--cc=bjorn@kernel.org \
--cc=bjorn@rivosinc.com \
--cc=chenhuacai@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=daniel.thompson@linaro.org \
--cc=falcon@tinylab.org \
--cc=guoren@kernel.org \
--cc=guoren@linux.alibaba.com \
--cc=heiko@sntech.de \
--cc=jszhang@kernel.org \
--cc=lazyparser@gmail.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=luto@kernel.org \
--cc=mark.rutland@arm.com \
--cc=palmer@dabbelt.com \
--cc=palmer@rivosinc.com \
--cc=peterz@infradead.org \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox