From: Xin Zhao <jackzxcui1989@163.com>
To: brauner@kernel.org
Cc: alex.aring@gmail.com, allen.lkml@gmail.com, arnd@arndb.de,
chuck.lever@oracle.com, david@kernel.org, ebiederm@xmission.com,
j.granados@samsung.com, jack@suse.cz, jackzxcui1989@163.com,
jlayton@kernel.org, keescook@chromium.org,
linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org, ljs@kernel.org,
mcgrof@kernel.org, mjguzik@gmail.com, pfalcato@suse.de,
rppt@kernel.org, viro@zeniv.linux.org.uk
Subject: Re: [PATCH v4] coredump: Add /proc/<pid>/coredump_pre_exit for pre-exit before dumping
Date: Tue, 30 Jun 2026 16:09:32 +0800 [thread overview]
Message-ID: <20260630080932.60881-1-jackzxcui1989@163.com> (raw)
In-Reply-To: <20260625-wappnen-drohbrief-wermutstropfen-c53538f01547@brauner>
Dear Christian,
On Thu, 25 Jun 2026 09:28:08 +0200 Christian Brauner <brauner@kernel.org> wrote:
> Nah, we're not doing a separate file for this. That makes no sense
> whatsoever. I've already explained this in the first mail. There are
> effectively three modes:
>
> (1) dump to a file
> (2) spawn super-privileged usermode helper process connect coredumping
> process and said helper via pipe
> (3) coredumping process connects to AF_UNIX socket
>
> Parameterize (1) and (2) via a command line arguments. I strongly
> suspect you're using some AI tooling so it should be able to figure out
> how this was done in the past.
>
> (3) can be extended by just introducing a new flag value for struct
> coredump_req. That is also illustrated by previous work.
>
> We're not spreading procfs files. It's terrible api design especially
> for security sensitive changes.
I am unsure whether the addition of a bit 9 for coredump_filter in version
v5 will be acceptable to everyone, as there are still many projects using
the coredump file and coredump pipe mechanisms. I found that coredump
files are used in elf_coredump_extra_notes_write, which makes it difficult
to distinguish between these two types and determine whether early release
of the files is possible without setting parameters. I am reluctant to add
another bit for this purpose, but it seems necessary. I am not sure if my
understanding is correct or if you have better suggestions, as I really do
not want to address only the coredump socket situation.
Thanks
Xin Zhao
next prev parent reply other threads:[~2026-06-30 8:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-24 14:55 [PATCH v4] coredump: Add /proc/<pid>/coredump_pre_exit for pre-exit before dumping Xin Zhao
2026-06-24 16:28 ` Al Viro
2026-06-25 2:51 ` Xin Zhao
2026-06-25 7:28 ` Christian Brauner
2026-06-25 8:50 ` Xin Zhao
2026-06-25 16:55 ` Al Viro
2026-06-25 10:57 ` David Hildenbrand (Arm)
2026-06-25 11:18 ` Pedro Falcato
2026-06-25 11:43 ` David Hildenbrand (Arm)
2026-06-29 7:11 ` Christian Brauner
2026-06-30 8:09 ` Xin Zhao [this message]
2026-06-25 12:48 ` Lorenzo Stoakes
2026-06-25 15:45 ` Xin Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260630080932.60881-1-jackzxcui1989@163.com \
--to=jackzxcui1989@163.com \
--cc=alex.aring@gmail.com \
--cc=allen.lkml@gmail.com \
--cc=arnd@arndb.de \
--cc=brauner@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=david@kernel.org \
--cc=ebiederm@xmission.com \
--cc=j.granados@samsung.com \
--cc=jack@suse.cz \
--cc=jlayton@kernel.org \
--cc=keescook@chromium.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=mcgrof@kernel.org \
--cc=mjguzik@gmail.com \
--cc=pfalcato@suse.de \
--cc=rppt@kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox