From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj2-f43.google.com (mail-pj2-f43.google.com [74.125.227.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DEAB34FDA48 for ; Fri, 2 Oct 2026 17:09:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790960958; cv=none; b=X0cJcxnLiaGAWcSKtM21KflKea8ej5Wcnj+mNc8BhJDUk1fmB1Pi/q2YJho6KaoHSbK35ilkm6ST5zd+2RDIh34XVmgB11TaUJsUFHuhYVBcYTQ96XLWz6A2qulRyWFeoSPS0eDDEIVHW8L4SZJgmVuwhQWVVx47kCTx4UW8lHU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790960958; c=relaxed/simple; bh=NerSRQgPomHVGQsyQmO2Em3s0dFaIoYpp/fMfD73Ojo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=K0VE5Y/nS/3Y62mGBgYpFuwLklmnLrjakFepOqeN37+/to30KH0sA/zuXc+X8WUy7r0jewhOC6/Wp0xvfUb6sdB5zu6LS6YAQMPpcHKQp5b1+9nPQoVWN2ZDghHJ22BjqgyznQQj4IuTR+wda2Wxztz1NRAGP5uJWH6cR9WS+fA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XMUSuhZ7; arc=none smtp.client-ip=74.125.227.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XMUSuhZ7" Received: by mail-pj2-f43.google.com with SMTP id 98e67ed59e1d1-3a4c8262465so162423a91.2 for ; Fri, 02 Oct 2026 10:09:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790960953; x=1791565753; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=xfCwDuuYoLXczS4CwGW4NE2cKOD24/roRAYfYD5E8yk=; b=XMUSuhZ7aEvmUgnNjY1tXraPyp2eyWD8SE4lauvJViBRjuM1wvgQnScqVpLporaYGl w1BQz46tNb2tou92v9nngwcAaQ+Q8om+9zMNlI24Kr+xG0oe4sWx76tz1/WzOHeKBlAT v52wPVY4OyOTiZzRivRQH6OnsjTikqpsmdL1l14wrF+tQFkXz/UxxzYz4NpfeYWXjKLU YhTlKIf49gcYsZ1tRxuwsg3rwAd69od/Z2OPl/PhFrZCPU8V52Jb0YD+qMrn5AnMaNBW t282HmoJlQ4cKLZkD9Udbgl7e2+UgeqVb18z/WVJxhS9FW6qu38bXpHhh6WToRMBxEyz 757Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790960953; x=1791565753; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=xfCwDuuYoLXczS4CwGW4NE2cKOD24/roRAYfYD5E8yk=; b=MlF28jILaBC0bUWp/CJSAry2QGHRsjmJz4PstX0iOqKb+9M799pCGG2jaTtnX1wgLX Qke2IpNorr0N0tuXuuWVmcFrRqo4hq/CeD32761pKvN/QdF7ZkaeaIDA31d5/9+ytu+t MCzyXIaMnZiwa9aIxHgTv405q3kf/gxco2eELHJHavu2tEf5J9HvIEd8P+MGoQrsCuN9 J5W5LIHCLKa/jxfKLC7h4ZEVdsYbOt+fRln82TGmmT2nmLJx2kn7znxuhxhf73yBWyEF Jo2/Qp9Tb1omeX+pkIPjinaT8VAsc7O5+VLDUXUr1+Vl6GIjNokdrzymzOT9wsF9O4UI kiQg== X-Forwarded-Encrypted: i=1; AKwUvBwKdy6D+ngYKmTvGYdE4ypR1UAQm3MXO1b77LjpUMrvc7Ac4unIwrAp+1q7ubfyHuQ7ACfzv3eMxC8O@vger.kernel.org X-Gm-Message-State: AFq9FYIJtYDNgMR2dUBw8bj9fYif4oOGkqDkhhlrIm10l9fb1GyZSxPG ZjQ6Nb6QzEjvpkUIS6+cDwA/DTbwqw7UcYsw3t4qWL4FnjYtE13qoAq9 X-Gm-Gg: AYBFou2j+fYcNA/8KZr49q31CqrczwU9/I0vOl5/aMaTVctLTTyPHI+X0whl9X0w01B XxU734jtqZwL12gsBkN9U0lNkDYdYP1brBw4RMZshsONVxhzhBCjF12Q27/OKKeCvv01l+ktR7V B280tUJXitkHk6oMgyMBBhOQ1wX9v8EBu6OtXHern9bLt+21jKXql0Aecu+N6l/Hady5iUUPkTm Y3QLs7W510OTpvoxw3V+93EahSTr5ADS9AhFGabKhegd6ZGpeLLI29h/I7qIwbTXArhoIJY7Vtm MhTdIPZgFpH1BSZJ3skAiUEsDMCcuC5LV44nDJsW+TniHx1gkak/WeKrft28g+gEPa0fqBAGmcY lYmj/JtNI3zneajJxQR4umrh+jkRMIIWq/7i0OWc4ABuSMVpawSf7AwzJxcjUGxAK9+x+pRVRKH /drMKZm+j9e4K7k/bje8bRux/7Xo1SVRtTLWQQ4cOgJcS7MiSaJhpvkH3U80xGQxPnnlMR9wJRF qi/5jkKE56GiolGvw== X-Received: by 2002:a17:90b:4ac3:b0:3a0:a781:2c39 with SMTP id 98e67ed59e1d1-3a6ce3a978dmr3051291a91.7.1790960952344; Fri, 02 Oct 2026 10:09:12 -0700 (PDT) Received: from kernel.tail6741c6.ts.net ([185.220.238.43]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3a7024d0f5fsm1597719a91.0.2026.10.02.10.09.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Oct 2026 10:09:11 -0700 (PDT) From: Kunwu Chan To: paulmck@kernel.org, corbet@lwn.net, mingo@redhat.com, frederic@kernel.org, neeraj.upadhyay@kernel.org, josh@joshtriplett.org, urezki@gmail.com, dave@stgolabs.net, lianux.mm@gmail.com Cc: stern@rowland.harvard.edu, parri.andrea@gmail.com, will@kernel.org, peterz@infradead.org, boqun@kernel.org, npiggin@gmail.com, dhowells@redhat.com, j.alglave@ucl.ac.uk, luc.maranget@inria.fr, akiyks@gmail.com, dlustig@nvidia.com, joelagnelf@nvidia.com, skhan@linuxfoundation.org, rdunlap@infradead.org, longman@redhat.com, rostedt@goodmis.org, mathieu.desnoyers@efficios.com, jiangshanlai@gmail.com, qiang.zhang@linux.dev, kunwu.chan@gmail.com, brads@mainlining.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, lkmm@lists.linux.dev, linux-doc@vger.kernel.org, rcu@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: [PATCH RFC v2 01/15] hazptr: add shared scan kthread Date: Sat, 3 Oct 2026 01:08:33 +0800 Message-ID: <20261002170847.3653663-2-kunwu.chan@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261002170847.3653663-1-kunwu.chan@gmail.com> References: <20261002170847.3653663-1-kunwu.chan@gmail.com> Precedence: bulk X-Mailing-List: linux-arch@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Batch concurrent hazptr_synchronize() callers into a shared scan cycle, avoiding redundant wildcard flips and slot scans. Queue waiters to a kthread and perform a two-phase wildcard scan once for all queued waiters. After both phases, complete waiters whose address is no longer held by any slot; waiters that remain blocked are retried in a later cycle. Waiters are embedded in the caller's stack frame, so no dynamic allocation is needed in the synchronize path. Fall back to the direct scan if the scan kthread is unavailable. Adapted from the scan-kthread approach in Boqun Feng's shazptr implementation. Link: https://lore.kernel.org/lkml/20250625031101.12555-1-boqun.feng@gmail.com/ Signed-off-by: Kunwu Chan --- kernel/hazptr.c | 201 ++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 201 insertions(+) diff --git a/kernel/hazptr.c b/kernel/hazptr.c index d3d1050d92cf..9e274a691af5 100644 --- a/kernel/hazptr.c +++ b/kernel/hazptr.c @@ -12,6 +12,10 @@ #include #include #include +#include +#include +#include +#include /* * The current hazard pointer wildcard. Flips between 1UL and 2UL to guarantee @@ -209,12 +213,179 @@ void hazptr_scan_period(void *addr, void *scan_wildcard) } } +struct hazptr_waiter { + struct list_head node; + void *addr; + struct completion done; +}; + +struct hazptr_scan_state { + struct task_struct *kthread; + struct swait_queue_head wq; + bool wakeup; + struct mutex lock; + struct list_head pending; + struct list_head scanning; /* kthread only */ +}; +static struct hazptr_scan_state hazptr_scan; + +/* + * Check per-CPU slots before overflow-list slots to match the + * acquisition ordering of promoted slots. + */ +static bool hazptr_value_present(void *val) +{ + int cpu; + + for_each_possible_cpu(cpu) { + struct hazptr_percpu_slots *percpu_slots = per_cpu_ptr(&hazptr_percpu_slots, cpu); + struct hazptr_overflow_list_flip *overflow_list_flip = per_cpu_ptr(&percpu_overflow_list_flip, cpu); + unsigned int idx; + + for (idx = 0; idx < NR_HAZPTR_PERCPU_SLOTS; idx++) { + struct hazptr_slot_item *item = &percpu_slots->items[idx]; + + /* Pairs with smp_store_release in hazptr_release(). */ + if (smp_load_acquire(&item->slot.addr) == val) + return true; + } + for (int i = 0; i < 2; i++) { + struct hazptr_overflow_list *list = &overflow_list_flip->array[i]; + struct hazptr_backup_slot *b; + unsigned long flags; + + raw_spin_lock_irqsave(&list->lock, flags); + hlist_for_each_entry(b, &list->head, overflow_node) { + /* Pairs with smp_store_release in hazptr_release(). */ + if (smp_load_acquire(&b->slot.addr) == val) { + raw_spin_unlock_irqrestore(&list->lock, flags); + return true; + } + } + raw_spin_unlock_irqrestore(&list->lock, flags); + } + } + return false; +} + +/* + * Wait until no per-CPU slot or overflow-list slot holds @wc. + * Callers must ensure that the wildcard value in use by new acquires + * differs from @wc, so that the set of slots holding @wc only + * shrinks, which guarantees forward progress. + */ +static void hazptr_drain_wildcard(void *wc) +{ + while (hazptr_value_present(wc)) + cond_resched(); +} + +/* + * Move pending waiters to ->scanning and perform a two-phase + * wildcard scan shared by all waiters. + */ +static void hazptr_scan_do_cycle(void) +{ + void *scan_wildcard, *old_wildcard; + struct hazptr_waiter *w, *n; + LIST_HEAD(done); + + mutex_lock(&hazptr_wildcard_lock); + + mutex_lock(&hazptr_scan.lock); + list_splice_tail_init(&hazptr_scan.pending, &hazptr_scan.scanning); + mutex_unlock(&hazptr_scan.lock); + + if (list_empty(&hazptr_scan.scanning)) { + mutex_unlock(&hazptr_wildcard_lock); + return; + } + + /* Pass 1: drain the unpublished wildcard. */ + scan_wildcard = flip_wildcard(READ_ONCE(hazptr_wildcard)); + hazptr_drain_wildcard(scan_wildcard); + + /* Flip so new acquires use the new generation. */ + WRITE_ONCE(hazptr_wildcard, scan_wildcard); + old_wildcard = flip_wildcard(scan_wildcard); + + /* Pass 2: drain the old wildcard. */ + hazptr_drain_wildcard(old_wildcard); + + /* Complete waiters whose address is no longer held by any slot. */ + list_for_each_entry_safe(w, n, &hazptr_scan.scanning, node) { + if (!hazptr_value_present(w->addr)) + list_move(&w->node, &done); + } + + mutex_unlock(&hazptr_wildcard_lock); + + list_for_each_entry_safe(w, n, &done, node) { + list_del_init(&w->node); + complete(&w->done); + } +} + +static int hazptr_scan_kthread(void *unused) +{ + for (;;) { + bool idle; + + swait_event_idle_exclusive(hazptr_scan.wq, + READ_ONCE(hazptr_scan.wakeup)); + + hazptr_scan_do_cycle(); + + mutex_lock(&hazptr_scan.lock); + idle = list_empty(&hazptr_scan.pending) && + list_empty(&hazptr_scan.scanning); + if (idle) + WRITE_ONCE(hazptr_scan.wakeup, false); + mutex_unlock(&hazptr_scan.lock); + + if (idle) + continue; + /* Waiters still blocked: retry after a short delay. */ + schedule_timeout_idle(1); + } + return 0; +} + +/* + * Queue @addr for the shared scan. The waiter lives on the + * caller's stack, so no allocation is needed. + */ +static void hazptr_synchronize_queued(void *addr) +{ + struct hazptr_waiter waiter = { + .addr = addr, + }; + + init_completion(&waiter.done); + INIT_LIST_HEAD(&waiter.node); + + /* Enqueue and wake the scan kthread. */ + mutex_lock(&hazptr_scan.lock); + list_add_tail(&waiter.node, &hazptr_scan.pending); + if (!READ_ONCE(hazptr_scan.wakeup)) { + WRITE_ONCE(hazptr_scan.wakeup, true); + swake_up_one(&hazptr_scan.wq); + } + mutex_unlock(&hazptr_scan.lock); + + /* Sleep until the scan kthread completes this waiter. */ + wait_for_completion(&waiter.done); +} + /* * hazptr_synchronize: Wait until @addr is released from all slots. * * Wait to observe that each slot contains a value that differs from * @addr before returning. * Should be called from preemptible context. + * + * If available, queue the caller for a shared scan; otherwise use + * the direct scan path. */ void hazptr_synchronize(void *addr) { @@ -235,6 +406,13 @@ void hazptr_synchronize(void *addr) /* Memory ordering: Store A before Load B. */ smp_mb(); + /* Pairs with smp_store_release in hazptr_scan_init(). */ + if (smp_load_acquire(&hazptr_scan.kthread)) { + hazptr_synchronize_queued(addr); + return; + } + + /* Fallback: use the direct scan path. */ guard(mutex)(&hazptr_wildcard_lock); scan_wildcard = flip_wildcard(hazptr_wildcard); hazptr_scan_period(addr, scan_wildcard); @@ -282,3 +460,26 @@ void __init hazptr_init(void) } } } + +/* + * Initialize the scan kthread. Failure falls back to the + * direct scan. + */ +static int __init hazptr_scan_init(void) +{ + struct task_struct *t; + + init_swait_queue_head(&hazptr_scan.wq); + mutex_init(&hazptr_scan.lock); + INIT_LIST_HEAD(&hazptr_scan.pending); + INIT_LIST_HEAD(&hazptr_scan.scanning); + + t = kthread_run(hazptr_scan_kthread, NULL, "hazptr_scan"); + if (!IS_ERR(t)) + /* Pairs with smp_load_acquire in hazptr_synchronize(). */ + smp_store_release(&hazptr_scan.kthread, t); + else + pr_warn("hazptr: scan kthread failed, using direct scan\n"); + return 0; +} +core_initcall(hazptr_scan_init); -- 2.43.0