From: Bjorn Helgaas <helgaas@kernel.org>
To: Pavel Popov <pavel.e.popov@intel.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Logan Gunthorpe <logang@deltatee.com>,
Arnd Bergmann <arnd@arndb.de>, Leon Romanovsky <leon@kernel.org>,
Lukas Wunner <lukas@wunner.de>, Thomas Gleixner <tglx@kernel.org>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, Jim Chow <jim.chow@broadcom.com>,
Radu Rugina <radu.rugina@broadcom.com>,
Alexey Makhalov <alexey.makhalov@broadcom.com>,
Wei Liu <wei.liu@kernel.org>,
Michael Kelley <mhklinux@outlook.com>,
Nathan Ciobanu <nathan.d.ciobanu@linux.intel.com>,
bcm-kernel-feedback-list@broadcom.com,
virtualization@lists.linux.dev, linux-hyperv@vger.kernel.org,
linux-arch@vger.kernel.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 0/3] PCI/P2PDMA: Allow P2PDMA on Intel Xeon server CPUs
Date: Fri, 20 Nov 2026 19:07:08 -0600 [thread overview]
Message-ID: <20261121010708.GA929035@bhelgaas> (raw)
In-Reply-To: <20261111234439.4098-1-pavel.e.popov@intel.com>
On Wed, Nov 11, 2026 at 04:44:36PM -0700, Pavel Popov wrote:
> VMware and Hyper-V expose passthrough devices to guest VMs without an
> explicit host bridge device. Consequently, host_bridge_whitelist()
> cannot automatically identify the underlying host bridge structure,
> causing Peer-to-Peer DMA (P2PDMA) requests to be rejected unless the
> device IDs are explicitly listed in pci_p2pdma_whitelist[]. To enable
> P2PDMA on Intel hosts, this series extends cpu_supports_p2pdma(), which
> so far covers AMD Zen and newer, with an explicit list of Intel Xeon
> server generations.
>
> Patch 1 adds a generic <asm/cpu_device_id.h>, so that generic code can
> include it without #ifdef CONFIG_X86.
> Patch 2 moves the CONFIG_X86 #ifdef out of cpu_supports_p2pdma(); this
> is the v4 1/2 patch, unchanged.
> Patch 3 is the v4 2/2 patch with Logan's Reviewed-by carried over; the
> only change is in the includes.
>
> Arnd, if 1/3 looks OK to you, could it go through the PCI tree
> together with 2/3 and 3/3?
>
> The other users of <asm/cpu_device_id.h> and <asm/intel-family.h>
> under #ifdef CONFIG_X86 (ACPI, cpufreq, i915, amdgpu, tpm, ccp,
> platform/x86) are converted in a follow-up series on top of this one.
>
> Based on mainline (7.4-rc2+). Built with x86_64 and arm64
> allmodconfig, each patch separately.
>
> Changes in v5:
> - Add 1/3, a generic <asm/cpu_device_id.h>, so the include no longer
> needs #ifdef CONFIG_X86 (Leon Romanovsky)
> - Drop the <asm/intel-family.h> include, <asm/cpu_device_id.h>
> includes it on x86
>
> Changes in v4:
> - Add 1/2, moving the CONFIG_X86 #ifdef out of cpu_supports_p2pdma()
> (Logan Gunthorpe, Leon Romanovsky)
> - Keep the #ifdef around the asm/ includes, as these headers exist
> only on x86 (Bjorn Helgaas)
>
> Changes in v3:
> - Drop the hypervisor check and move the Xeon list into
> cpu_supports_p2pdma(), next to the AMD check, as suggested by Logan
> Gunthorpe and Leon Romanovsky [1]
> - Fold the VMware and Hyper-V patches into one, as the check no longer
> depends on the hypervisor
>
> Changes in v2:
> - Replace the Skylake-and-newer threshold with an explicit list of Intel
> Xeon server generations, from Skylake-SP to Diamond Rapids (Logan
> Gunthorpe)
> - Move the CONFIG_X86 #ifdef out of hypervisor_supports_p2pdma()
> (Logan Gunthorpe)
> - Rebased on current mainline
>
> [1] https://lore.kernel.org/r/20261016153147.GC219304@unreal
>
> v4: https://lore.kernel.org/r/20261020173736.81755-1-pavel.e.popov@intel.com
> v3: https://lore.kernel.org/r/20261020151305.65218-1-pavel.e.popov@intel.com
> v2: https://lore.kernel.org/r/20261016223402.19991-1-pavel.e.popov@intel.com
> v1: https://lore.kernel.org/r/20261009154034.82321-1-pavel.e.popov@intel.com
>
> Pavel Popov (3):
> asm-generic: Add <asm-generic/cpu_device_id.h>
> PCI/P2PDMA: Move CONFIG_X86 #ifdef out of cpu_supports_p2pdma()
> PCI/P2PDMA: Allow P2PDMA on Intel Xeon server CPUs
>
> drivers/pci/p2pdma.c | 30 +++++++++++++++++++++++++++--
> include/asm-generic/Kbuild | 1 +
> include/asm-generic/cpu_device_id.h | 5 +++++
> 3 files changed, 34 insertions(+), 2 deletions(-)
> create mode 100644 include/asm-generic/cpu_device_id.h
Applied to pci/p2pdma for v7.5, thanks for the reminder.
There were minor conflicts with Leon's series, but I applied yours
directly on v7.4-rc1 and resolved the conflicts when adding Leon's on
top.
prev parent reply other threads:[~2026-11-21 1:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-11 23:44 [PATCH v5 0/3] PCI/P2PDMA: Allow P2PDMA on Intel Xeon server CPUs Pavel Popov
2026-11-11 23:44 ` [PATCH v5 1/3] asm-generic: Add <asm-generic/cpu_device_id.h> Pavel Popov
2026-11-12 13:56 ` Arnd Bergmann
2026-11-13 4:13 ` Logan Gunthorpe
2026-11-13 23:34 ` Sohil Mehta
2026-11-16 14:17 ` Leon Romanovsky
2026-11-11 23:44 ` [PATCH v5 2/3] PCI/P2PDMA: Move CONFIG_X86 #ifdef out of cpu_supports_p2pdma() Pavel Popov
2026-11-13 4:13 ` Logan Gunthorpe
2026-11-16 14:19 ` Leon Romanovsky
2026-11-11 23:44 ` [PATCH v5 3/3] PCI/P2PDMA: Allow P2PDMA on Intel Xeon server CPUs Pavel Popov
2026-11-16 6:22 ` Christoph Hellwig
2026-11-16 11:17 ` David Laight
2026-11-16 14:16 ` Leon Romanovsky
2026-11-16 17:35 ` Popov, Pavel E
2026-11-20 21:44 ` [PATCH v5 0/3] " Popov, Pavel E
2026-11-21 1:07 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261121010708.GA929035@bhelgaas \
--to=helgaas@kernel.org \
--cc=alexey.makhalov@broadcom.com \
--cc=arnd@arndb.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bhelgaas@google.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=jim.chow@broadcom.com \
--cc=leon@kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=logang@deltatee.com \
--cc=lukas@wunner.de \
--cc=mhklinux@outlook.com \
--cc=mingo@redhat.com \
--cc=nathan.d.ciobanu@linux.intel.com \
--cc=pavel.e.popov@intel.com \
--cc=radu.rugina@broadcom.com \
--cc=tglx@kernel.org \
--cc=virtualization@lists.linux.dev \
--cc=wei.liu@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox