From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Howells Subject: Re: [patch 05/16] frv: use generic pci_enable_resources() Date: Wed, 05 Mar 2008 14:52:46 +0000 Message-ID: <20881.1204728766@redhat.com> References: <20080304185820.723623873@ldl.fc.hp.com> <20080304185646.864917286@ldl.fc.hp.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20080304185820.723623873@ldl.fc.hp.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linuxppc-dev-bounces+glppd-linuxppc64-dev=m.gmane.org@ozlabs.org Errors-To: linuxppc-dev-bounces+glppd-linuxppc64-dev=m.gmane.org@ozlabs.org To: Bjorn Helgaas Cc: linux-arch@vger.kernel.org, Chris Zankel , Grant Grundler , linux-parisc@vger.kernel.org, Matthew Wilcox , Kyle McMartin , linuxppc-dev@ozlabs.org, Paul Mackerras , linux-pci@atrey.karlin.mff.cuni.cz, linux-arm-kernel@lists.arm.linux.org.uk, Russell King List-Id: linux-arch.vger.kernel.org Bjorn Helgaas wrote: > Use the generic pci_enable_resources() instead of the arch-specific code. > > Unlike this arch-specific code, the generic version: > - checks PCI_NUM_RESOURCES (11), not 6, resources > - skips resources that have neither IORESOURCE_IO nor IORESOURCE_MEM set > - skips ROM resources unless IORESOURCE_ROM_ENABLE is set > - checks for resource collisions with "!r->parent" > > Signed-off-by: Bjorn Helgaas Acked-by: David Howells From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com ([66.187.233.31]:33672 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752652AbYCEPFf (ORCPT ); Wed, 5 Mar 2008 10:05:35 -0500 From: David Howells In-Reply-To: <20080304185820.723623873@ldl.fc.hp.com> References: <20080304185820.723623873@ldl.fc.hp.com> <20080304185646.864917286@ldl.fc.hp.com> Subject: Re: [patch 05/16] frv: use generic pci_enable_resources() Date: Wed, 05 Mar 2008 14:52:46 +0000 Message-ID: <20881.1204728766@redhat.com> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Bjorn Helgaas Cc: dhowells@redhat.com, Russell King , linux-arm-kernel@lists.arm.linux.org.uk, Kyle McMartin , Matthew Wilcox , Grant Grundler , linux-parisc@vger.kernel.org, Paul Mackerras , Benjamin Herrenschmidt , linuxppc-dev@ozlabs.org, Chris Zankel , linux-pci@atrey.karlin.mff.cuni.cz, linux-arch@vger.kernel.org Message-ID: <20080305145246._gHHNe94YrPSQDIWR1WPXN7zp5PCVNPIvG1uX8r9WXI@z> Bjorn Helgaas wrote: > Use the generic pci_enable_resources() instead of the arch-specific code. > > Unlike this arch-specific code, the generic version: > - checks PCI_NUM_RESOURCES (11), not 6, resources > - skips resources that have neither IORESOURCE_IO nor IORESOURCE_MEM set > - skips ROM resources unless IORESOURCE_ROM_ENABLE is set > - checks for resource collisions with "!r->parent" > > Signed-off-by: Bjorn Helgaas Acked-by: David Howells