Re: [PATCH 33/45] include/uapi/asm-generic/signal.h: include stdlib.h in userspace

Arnd Bergmann
2015-03-11T10:02:29Z

On Wednesday 11 March 2015 00:58:28 Mikko Rapeli wrote:
> linux/kexec.h seems suspicious though:
>
> #ifndef __KERNEL__
> /*
> * This structure is used to hold the arguments that are used when
> * loading kernel binaries.
> */
> struct kexec_segment {
> const void *buf;
> size_t bufsz;
> const void *mem;
> size_t memsz;
> };
>
> #endif /* __KERNEL__ */
>

Hmm, maybe that just needs to be removed as well, after we
have removed the function declaration that used to follow it
as part of this commit:

http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=9dc5c05f45ca8101025046cd

Using __kernel_size_t would work here as well, but I suspect that
the entire structure is useless as it is not used by kernel or
user space, and kexec_tools has its own copy of the structure.

Arnd