From: David Howells <dhowells@redhat.com>
To: Andrew Morton <akpm@osdl.org>
Cc: David Howells <dhowells@redhat.com>,
torvalds@osdl.org, linux-kernel@vger.kernel.org,
linux-arch@vger.kernel.org
Subject: Re: [PATCH 5/7] Alter get_order() so that it can make use of ilog2() on a constant [try #3]
Date: Tue, 19 Sep 2006 10:08:17 +0100 [thread overview]
Message-ID: <23843.1158656897@warthog.cambridge.redhat.com> (raw)
In-Reply-To: <20060919003031.166d08a4.akpm@osdl.org>
Andrew Morton <akpm@osdl.org> wrote:
> This breaks ia64:
Okay, drop it for now.
> But for some reason putting ARCH_HAS_GET_ORDER into
> include/asm-ia64/bitops.h and including linux/log2.h in
> include/asm-ia64/page.h doesn't fix it.
Seems I need to get an IA64 cross-compiler.
> I didn't pursue it further, because sprinkling ARCH_HAS_FOO things into
> bitops.h(!) is all rather hacky. Better to use CONFIG_* so they're always
> visible and one knows where to go to find things.
But (1) they're not config options, and (2) there's plenty of precedent for
this sort of thing (ARCH_HAS_PREFETCH for example).
David
next prev parent reply other threads:[~2006-09-19 9:08 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-13 18:35 [PATCH 1/7] FRV: Fix fls() to handle bit 31 being set correctly [try #3] David Howells
2006-09-13 18:35 ` [PATCH 2/7] FRV: Implement fls64() " David Howells
2006-09-13 18:35 ` [PATCH 3/7] FRV: Optimise ffs() " David Howells
2006-09-13 18:35 ` [PATCH 4/7] Implement a general integer log2 facility in the kernel " David Howells
2006-09-14 1:19 ` Stephen Rothwell
2006-09-13 18:35 ` [PATCH 5/7] Alter get_order() so that it can make use of ilog2() on a constant " David Howells
2006-09-14 1:24 ` Stephen Rothwell
2006-09-14 11:52 ` David Howells
2006-09-15 1:35 ` Stephen Rothwell
2006-09-15 14:42 ` David Howells
2006-09-17 10:04 ` Stephen Rothwell
2006-09-19 7:30 ` Andrew Morton
2006-09-19 9:08 ` David Howells [this message]
2006-09-19 15:03 ` Andrew Morton
2006-09-19 15:08 ` Christoph Hellwig
2006-09-13 18:35 ` [PATCH 6/7] Alter roundup_pow_of_two() " David Howells
2006-09-13 18:35 ` [PATCH 7/7] Provide ilog2() fallbacks for powerpc " David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23843.1158656897@warthog.cambridge.redhat.com \
--to=dhowells@redhat.com \
--cc=akpm@osdl.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox