From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH v9 07/17] h8300: miscellaneous functions Date: Mon, 27 Apr 2015 10:57:10 +0200 Message-ID: <2426012.sTXZYqKJ88@wuerfel> References: <1430112924-1134-1-git-send-email-ysato@users.sourceforge.jp> <1430112924-1134-8-git-send-email-ysato@users.sourceforge.jp> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: Received: from mout.kundenserver.de ([212.227.126.187]:51221 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751948AbbD0I5Y (ORCPT ); Mon, 27 Apr 2015 04:57:24 -0400 In-Reply-To: <1430112924-1134-8-git-send-email-ysato@users.sourceforge.jp> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Yoshinori Sato Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org On Monday 27 April 2015 14:35:14 Yoshinori Sato wrote: > +void dma_sync_single_for_device(struct device *dev, dma_addr_t handle, > + size_t size, enum dma_data_direction dir) > +{ > +} > +EXPORT_SYMBOL(dma_sync_single_for_device); > + > +void dma_sync_sg_for_device(struct device *dev, struct scatterlist *sg, > + int nents, enum dma_data_direction dir) > +{ > + int i; > + > + for (i = 0; i < nents; sg++, i++) > + dma_sync_single_for_device(dev, sg->dma_address, > + sg->length, dir); > +} > +EXPORT_SYMBOL(dma_sync_sg_for_device); > + > +dma_addr_t dma_map_single(struct device *dev, void *addr, size_t size, > + enum dma_data_direction dir) > +{ > + dma_addr_t handle = virt_to_bus(addr); > + > + dma_sync_single_for_device(dev, handle, size, dir); > + return handle; > +} > +EXPORT_SYMBOL(dma_map_single); As this all doesn't do anything, and your dma-mapping.h header explains that the architecture is cache-coherent, just remove these functions, and replace them with empty 'static inline' helpers in that header. Arnd