linux-arch.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Yoshinori Sato <ysato@users.sourceforge.jp>
Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org
Subject: Re: [PATCH v3] Add ARCH_MIGHT_HAVE_VGA_CONSOLE
Date: Wed, 04 Feb 2015 08:37:16 +0100	[thread overview]
Message-ID: <2520649.mPxvSuP2QL@wuerfel> (raw)
In-Reply-To: <87a90ujjrf.wl-ysato@users.sourceforge.jp>

On Wednesday 04 February 2015 15:03:32 Yoshinori Sato wrote:
> @@ -2,14 +2,14 @@
>  # Video configuration
>  #
>  
> +config ARCH_MIGHT_HAVE_VGA_CONSOLE
> +        bool
> +
>  menu "Console display driver support"
>  
> 

I just noticed one more problem: The file that you add the option to is
conditional on CONFIG_VT, and that option is user-selectable. If
VT is disabled, you will get a warning from architectures that select
the symbol.

I think you should move the statement above into drivers/video/Kconfig,
outside of the 'if VT'.

	Arnd

  reply	other threads:[~2015-02-04  7:37 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <877fw093oa.wl-ysato@users.sourceforge.jp>
2015-02-02  8:10 ` [PATCH] Add ARCH_MIGHT_HAVE_VGA_CONSOLE Geert Uytterhoeven
2015-02-02 15:48   ` Yoshinori Sato
2015-02-02 15:48     ` Yoshinori Sato
2015-02-02 20:11     ` Arnd Bergmann
2015-02-03  0:08       ` Stephen Rothwell
2015-02-03  4:42       ` Yoshinori Sato
2015-02-02 21:07     ` Geert Uytterhoeven
2015-02-02 21:07       ` Geert Uytterhoeven
2015-02-03  4:42       ` Yoshinori Sato
2015-02-04  6:03 ` [PATCH v3] " Yoshinori Sato
2015-02-04  7:37   ` Arnd Bergmann [this message]
2015-02-07  7:42     ` Yoshinori Sato
2015-02-15  7:22 ` [PATCH v4] " Yoshinori Sato
2015-02-15  9:03   ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2520649.mPxvSuP2QL@wuerfel \
    --to=arnd@arndb.de \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ysato@users.sourceforge.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).