From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com ([66.187.233.31]:30444 "EHLO mx1.redhat.com") by vger.kernel.org with ESMTP id S1750761AbWHINSY (ORCPT ); Wed, 9 Aug 2006 09:18:24 -0400 From: David Howells In-Reply-To: <20060809094516.GA17993@infradead.org> References: <20060809094516.GA17993@infradead.org> <20060807115537.GA15253@in.ibm.com> <20060807120024.GD15253@in.ibm.com> <20060808162559.GB28647@infradead.org> <20060809094311.GA20050@in.ibm.com> Subject: Re: [PATCH 2/3] Kprobes: Define retval helper Date: Wed, 09 Aug 2006 14:16:04 +0100 Message-ID: <26750.1155129364@warthog.cambridge.redhat.com> Sender: linux-arch-owner@vger.kernel.org To: Christoph Hellwig Cc: Ananth N Mavinakayanahalli , linux-kernel@vger.kernel.org, Prasanna S Panchamukhi , Anil S Keshavamurthy , Jim Keniston , linux-arch@vger.kernel.org List-ID: Christoph Hellwig wrote: > > > Good idea. You should add parentheses around regs, otherwise the C > > > preprocessor might bite users. Also the shouting name is quite ugly. > > > In fact it should probably go to asm/system.h or similar and not have > > > a kprobes name - it just extracts the return value from a struct pt_regs > > > after all. > > > > Done! How does this look? I added it to asm/ptrace.h so it lives along > > with the instruction_pointer() definition. I presume we don't care about return values that span multiple registers - for instance if you return a 64-bit value on i386 it'll wind up in EDX:EAX. David