From: Chintan Pandya <cpandya@codeaurora.org>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: will.deacon@arm.com, mark.rutland@arm.com, toshi.kani@hpe.com,
linux-arch@vger.kernel.org, arnd@arndb.de,
ard.biesheuvel@linaro.org, marc.zyngier@arm.com,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
kristina.martsenko@arm.com, takahiro.akashi@linaro.org,
james.morse@arm.com, tglx@linutronix.de,
akpm@linux-foundation.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v8 2/4] arm64: tlbflush: Introduce __flush_tlb_kernel_pgtable
Date: Fri, 27 Apr 2018 18:00:22 +0530 [thread overview]
Message-ID: <26d3696d-a298-fe1b-c686-0f12ea94d5a6@codeaurora.org> (raw)
In-Reply-To: <20180427102900.4e63lo4eksk23vtn@armageddon.cambridge.arm.com>
On 4/27/2018 3:59 PM, Catalin Marinas wrote:
> On Tue, Apr 03, 2018 at 01:30:44PM +0530, Chintan Pandya wrote:
>> Add an interface to invalidate intermediate page tables
>> from TLB for kernel.
>>
>> Signed-off-by: Chintan Pandya <cpandya@codeaurora.org>
>> ---
>> arch/arm64/include/asm/tlbflush.h | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/arch/arm64/include/asm/tlbflush.h b/arch/arm64/include/asm/tlbflush.h
>> index 9e82dd7..6a4816d 100644
>> --- a/arch/arm64/include/asm/tlbflush.h
>> +++ b/arch/arm64/include/asm/tlbflush.h
>> @@ -209,6 +209,12 @@ static inline void __flush_tlb_pgtable(struct mm_struct *mm,
>> dsb(ish);
>> }
>>
>> +static inline void __flush_tlb_kernel_pgtable(unsigned long addr)
>> +{
>> + addr >>= 12;
>> + __tlbi(vaae1is, addr);
>> + dsb(ish);
>> +}
>> #endif
>
> Please use __TLBI_VADDR here as it does some additional masking.
>
Sure.
Chintan
--
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center,
Inc. is a member of the Code Aurora Forum, a Linux Foundation
Collaborative Project
next prev parent reply other threads:[~2018-04-27 12:30 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-03 8:00 [PATCH v8 0/4] Fix issues with huge mapping in ioremap for ARM64 Chintan Pandya
2018-04-03 8:00 ` Chintan Pandya
2018-04-03 8:00 ` [PATCH v8 1/4] ioremap: Update pgtable free interfaces with addr Chintan Pandya
2018-04-03 8:00 ` Chintan Pandya
2018-04-03 8:00 ` [PATCH v8 2/4] arm64: tlbflush: Introduce __flush_tlb_kernel_pgtable Chintan Pandya
2018-04-03 8:00 ` Chintan Pandya
2018-04-27 10:29 ` Catalin Marinas
2018-04-27 10:29 ` Catalin Marinas
2018-04-27 12:30 ` Chintan Pandya [this message]
2018-04-27 12:30 ` Chintan Pandya
2018-04-03 8:00 ` [PATCH v8 3/4] arm64: Implement page table free interfaces Chintan Pandya
2018-04-03 8:00 ` Chintan Pandya
2018-04-03 8:00 ` [PATCH v8 4/4] Revert "arm64: Enforce BBM for huge IO/VMAP mappings" Chintan Pandya
2018-04-03 8:00 ` Chintan Pandya
2018-04-03 8:43 ` [PATCH v8 0/4] Fix issues with huge mapping in ioremap for ARM64 Marc Zyngier
2018-04-03 8:43 ` Marc Zyngier
2018-04-03 11:55 ` Chintan Pandya
2018-04-03 11:55 ` Chintan Pandya
2018-04-05 9:09 ` Chintan Pandya
2018-04-05 9:09 ` Chintan Pandya
2018-04-17 10:25 ` Chintan Pandya
2018-04-17 10:25 ` Chintan Pandya
2018-04-27 10:27 ` Catalin Marinas
2018-04-27 10:27 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26d3696d-a298-fe1b-c686-0f12ea94d5a6@codeaurora.org \
--to=cpandya@codeaurora.org \
--cc=akpm@linux-foundation.org \
--cc=ard.biesheuvel@linaro.org \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=gregkh@linuxfoundation.org \
--cc=james.morse@arm.com \
--cc=kristina.martsenko@arm.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=takahiro.akashi@linaro.org \
--cc=tglx@linutronix.de \
--cc=toshi.kani@hpe.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox