From: David Howells <dhowells@redhat.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: linux-arch@vger.kernel.org
Subject: Re: [PATCH] consolidate shmat usage
Date: Wed, 23 Mar 2005 10:54:28 +0000 [thread overview]
Message-ID: <27271.1111575268@redhat.com> (raw)
In-Reply-To: <20050323174810.17df4440.sfr@canb.auug.org.au>
Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> This patch creates sys_shmat and sys_smhatcall and uses them wherever
> possible - this tidies up sys_ipc a bit in most cases. I have not touched
> um arch.
>
> I am eventually aiming at consolidating (as much as possible of) sys_ipc
> and doing compat_sys_ipc.
>
> I suspetc the conditional compilation of sys_shmat{,call} is a bit much
> and have no problem with removing the conditionals.
Looks okay to me; but the #ifdef haters are going to hate your guts and insist
that the sys_shmat and sys_shmatcall functions you added go in their own files
and get conditionally included by the Makefile.
David
next prev parent reply other threads:[~2005-03-23 10:54 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-23 4:01 [PATCH] consolidate asm/ipc.h Stephen Rothwell
2005-03-23 4:12 ` David S. Miller
2005-03-23 6:48 ` [PATCH] consolidate shmat usage Stephen Rothwell
2005-03-23 10:54 ` David Howells [this message]
2005-04-05 8:02 ` Stephen Rothwell
2005-03-23 14:51 ` Matthew Wilcox
2005-04-05 8:01 ` Stephen Rothwell
2005-04-05 13:03 ` Matthew Wilcox
2005-04-05 20:00 ` Ralf Baechle
2005-04-05 20:16 ` Russell King
2005-04-05 20:20 ` Ralf Baechle
2005-04-06 15:05 ` Stephen Rothwell
2005-04-07 5:14 ` Stephen Rothwell
2005-04-11 20:29 ` Russell King
2005-04-27 6:27 ` [PATCH] consolidate sys_shmat Stephen Rothwell
2005-04-27 12:50 ` Ralf Baechle
2005-04-27 14:36 ` Stephen Rothwell
2005-04-05 8:05 ` [PATCH] consolidate shmat usage Stephen Rothwell
2005-03-23 8:06 ` [PATCH] consolidate asm/ipc.h Andi Kleen
2005-03-24 0:30 ` Stephen Rothwell
2005-03-23 10:49 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=27271.1111575268@redhat.com \
--to=dhowells@redhat.com \
--cc=linux-arch@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox