From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH 20/25] arm64:ilp32: add sys_ilp32.c and a separate table (in entry.S) to use it Date: Thu, 28 Apr 2016 22:43:59 +0200 Message-ID: <2760348.qmm1L3yQch@wuerfel> References: <1459894127-17698-1-git-send-email-ynorov@caviumnetworks.com> <20160426165701.GE8525@e104818-lin.cambridge.arm.com> <20160428191914.GA28527@yury-N73SV> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20160428191914.GA28527@yury-N73SV> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Yury Norov Cc: linux-arch@vger.kernel.org, linux-s390@vger.kernel.org, pinskia@gmail.com, Prasun.Kapoor@caviumnetworks.com, Catalin Marinas , joseph@codesourcery.com, linux-doc@vger.kernel.org, heiko.carstens@de.ibm.com, linux-kernel@vger.kernel.org, agraf@suse.de, klimov.linux@gmail.com, Andrew Pinski , broonie@kernel.org, bamvor.zhangjian@huawei.com, Andrew Pinski , schwab@suse.de, schwidefsky@de.ibm.com, Nathan_Lynch@mentor.com, linux-arm-kernel@lists.infradead.org, christoph.muellner@theobroma-systems.com List-Id: linux-arch.vger.kernel.org On Thursday 28 April 2016 22:19:14 Yury Norov wrote: > > Yes, we need. Otherwise we have circular dependency like this: > arch/arm64/kernel/sys_ilp32.c:60:0: warning: "__SC_WRAP" redefined > #define __SC_WRAP(nr, sym) [nr] = compat_##sym, > ^ > In file included from include/asm-generic/unistd.h:1:0, > from ./arch/arm64/include/uapi/asm/unistd.h:16, > from ./arch/arm64/include/asm/unistd.h:62, > from ./include/uapi/linux/unistd.h:7, > from include/linux/syscalls.h:23, > from arch/arm64/kernel/sys_ilp32.c:30: > include/uapi/asm-generic/unistd.h:33:0: note: this is the location of the previous definition > #define __SC_WRAP __SYSCALL > > Defining __SYSCALL_COMPAT at the top of the file does not help much. Hmm, this sounds like something that we should fix in the asm-generic/unistd.h file. Is it just for __SC_WRAP, or also the other macros? Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.kundenserver.de ([212.227.17.13]:63080 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753417AbcD1UpP (ORCPT ); Thu, 28 Apr 2016 16:45:15 -0400 From: Arnd Bergmann Subject: Re: [PATCH 20/25] arm64:ilp32: add sys_ilp32.c and a separate table (in entry.S) to use it Date: Thu, 28 Apr 2016 22:43:59 +0200 Message-ID: <2760348.qmm1L3yQch@wuerfel> In-Reply-To: <20160428191914.GA28527@yury-N73SV> References: <1459894127-17698-1-git-send-email-ynorov@caviumnetworks.com> <20160426165701.GE8525@e104818-lin.cambridge.arm.com> <20160428191914.GA28527@yury-N73SV> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-arch-owner@vger.kernel.org List-ID: To: Yury Norov Cc: Catalin Marinas , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-s390@vger.kernel.org, pinskia@gmail.com, Prasun.Kapoor@caviumnetworks.com, schwab@suse.de, broonie@kernel.org, linux-doc@vger.kernel.org, heiko.carstens@de.ibm.com, agraf@suse.de, klimov.linux@gmail.com, Andrew Pinski , bamvor.zhangjian@huawei.com, Andrew Pinski , schwidefsky@de.ibm.com, Nathan_Lynch@mentor.com, joseph@codesourcery.com, christoph.muellner@theobroma-systems.com Message-ID: <20160428204359.u0rQeNKrGxrHR-L1sUK7zDjOscacbLJFd2HHaVJBF9Q@z> On Thursday 28 April 2016 22:19:14 Yury Norov wrote: > > Yes, we need. Otherwise we have circular dependency like this: > arch/arm64/kernel/sys_ilp32.c:60:0: warning: "__SC_WRAP" redefined > #define __SC_WRAP(nr, sym) [nr] = compat_##sym, > ^ > In file included from include/asm-generic/unistd.h:1:0, > from ./arch/arm64/include/uapi/asm/unistd.h:16, > from ./arch/arm64/include/asm/unistd.h:62, > from ./include/uapi/linux/unistd.h:7, > from include/linux/syscalls.h:23, > from arch/arm64/kernel/sys_ilp32.c:30: > include/uapi/asm-generic/unistd.h:33:0: note: this is the location of the previous definition > #define __SC_WRAP __SYSCALL > > Defining __SYSCALL_COMPAT at the top of the file does not help much. Hmm, this sounds like something that we should fix in the asm-generic/unistd.h file. Is it just for __SC_WRAP, or also the other macros? Arnd