From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH] arch: m32r: include: asm: add "dma-mapping-common.h" Date: Thu, 27 Jun 2013 10:30:51 +0200 Message-ID: <2831217.RWPZkclVnp@wuerfel> References: <51CBC4B3.807@asianux.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <51CBC4B3.807@asianux.com> Sender: linux-kernel-owner@vger.kernel.org To: Chen Gang Cc: Hirokazu Takata , "dhowells@redhat.com" , Paul McKenney , "sfr@canb.auug.org.au" , Rusty Russell , linux-m32r@ml.linux-m32r.org, linux-m32r-ja@ml.linux-m32r.org, "linux-kernel@vger.kernel.org" , Linux-Arch List-Id: linux-arch.vger.kernel.org On Thursday 27 June 2013 12:50:59 Chen Gang wrote: > Need add generic "dma-mapping-common.h", or compiling may fail. >=20 > The related error (with allmodconfig): >=20 > CC [M] net/irda/irlan/irlan_eth.o > drivers/media/v4l2-core/videobuf2-dma-contig.c: In function =E2=80=98= vb2_dc_mmap=E2=80=99: > drivers/media/v4l2-core/videobuf2-dma-contig.c:202:2: error: implic= it declaration of function =E2=80=98dma_mmap_coherent=E2=80=99 [-Werror= =3Dimplicit-function-declaration] > drivers/media/v4l2-core/videobuf2-dma-contig.c: In function =E2=80=98= vb2_dc_get_base_sgt=E2=80=99: > drivers/media/v4l2-core/videobuf2-dma-contig.c:385:2: error: implic= it declaration of function =E2=80=98dma_get_sgtable=E2=80=99 [-Werror=3D= implicit-function-declaration] >=20 >=20 > Signed-off-by: Chen Gang m32r does not provide the "common" version of the dma mapping API, so t= his is certainly wrong. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from moutng.kundenserver.de ([212.227.17.10]:57518 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752365Ab3F0I3a convert rfc822-to-8bit (ORCPT ); Thu, 27 Jun 2013 04:29:30 -0400 From: Arnd Bergmann Subject: Re: [PATCH] arch: m32r: include: asm: add "dma-mapping-common.h" Date: Thu, 27 Jun 2013 10:30:51 +0200 Message-ID: <2831217.RWPZkclVnp@wuerfel> In-Reply-To: <51CBC4B3.807@asianux.com> References: <51CBC4B3.807@asianux.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="utf-8" Sender: linux-arch-owner@vger.kernel.org List-ID: To: Chen Gang Cc: Hirokazu Takata , "dhowells@redhat.com" , Paul McKenney , "sfr@canb.auug.org.au" , Rusty Russell , linux-m32r@ml.linux-m32r.org, linux-m32r-ja@ml.linux-m32r.org, "linux-kernel@vger.kernel.org" , Linux-Arch Message-ID: <20130627083051.3SSdVzhOFfuxbrfh1fkDzW3Rgrsrfwws86HVK8K20ag@z> On Thursday 27 June 2013 12:50:59 Chen Gang wrote: > Need add generic "dma-mapping-common.h", or compiling may fail. > > The related error (with allmodconfig): > > CC [M] net/irda/irlan/irlan_eth.o > drivers/media/v4l2-core/videobuf2-dma-contig.c: In function ‘vb2_dc_mmap’: > drivers/media/v4l2-core/videobuf2-dma-contig.c:202:2: error: implicit declaration of function ‘dma_mmap_coherent’ [-Werror=implicit-function-declaration] > drivers/media/v4l2-core/videobuf2-dma-contig.c: In function ‘vb2_dc_get_base_sgt’: > drivers/media/v4l2-core/videobuf2-dma-contig.c:385:2: error: implicit declaration of function ‘dma_get_sgtable’ [-Werror=implicit-function-declaration] > > > Signed-off-by: Chen Gang m32r does not provide the "common" version of the dma mapping API, so this is certainly wrong. Arnd