From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Howells Subject: Re: [PATCH] Partially revert patch that encloses asm-offset.h numbers in brackets Date: Mon, 25 Oct 2010 15:54:25 +0100 Message-ID: <28707.1288018465@redhat.com> References: <4CC5B1A1020000780001EF7C@vpn.id2.novell.com> <20101025140218.5092.74117.stgit@warthog.procyon.org.uk> Return-path: Received: from mx1.redhat.com ([209.132.183.28]:11241 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751847Ab0JYOz7 (ORCPT ); Mon, 25 Oct 2010 10:55:59 -0400 In-Reply-To: <4CC5B1A1020000780001EF7C@vpn.id2.novell.com> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Jan Beulich Cc: dhowells@redhat.com, akpm@linux-foundation.org, torvalds@osdl.org, Ingo Molnar , Alexander van Heukelum , "H. Peter Anvin" , linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org Jan Beulich wrote: > Isn't this a gas bug then? Anywhere you use a plain number you > should also be permitted to use an expression. Whoever defined the gas assembly syntax for binutils specified that (N) as an operand defines an absolute address and N defines an immediate value. However, prefixing an expression with a unary plus works for me, so adding this into my patch: - s:^->\([^ ]*\) [\$$#]*\([-0-9]*\) \(.*\):#define \1 \2 /* \3 */:; \ + s:^->\([^ ]*\) [\$$#]*\([-0-9]*\) \(.*\):#define \1 +(\2) /* \3 */:; \ Does that work for you? David