From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Howells Subject: Re: [PATCH] UAPI: Remove empty Kbuild files Date: Tue, 26 Mar 2013 20:59:43 +0000 Message-ID: <29647.1364331583@warthog.procyon.org.uk> References: <20130326131828.209aff73e38d3273d078bb2e@linux-foundation.org> <20130326174853.10144.36253.stgit@warthog.procyon.org.uk> Return-path: In-Reply-To: <20130326131828.209aff73e38d3273d078bb2e@linux-foundation.org> Sender: linux-kernel-owner@vger.kernel.org To: Andrew Morton Cc: dhowells@redhat.com, torvalds@linux-foundation.org, arnd@arndb.de, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-arch.vger.kernel.org Andrew Morton wrote: > > Remove empty Kbuild files as they cause problems with the patch program > > which removes files that become empty. > > > > Should I also remove include/Kbuild as that now does nothing? Or should > > it be left as an anchor just in case we want it in future? > > I think that if the build system created it, a `make clean' or `make > mproper' should rub it out again. Ideally a `make mrproper' will give > you a tree which is identical to a freshly-untarred kernel.org tarball > (yes?). Ummm... What's that got to do with it? include/Kbuild is part of the sources: make clean/mrproper/distclean should not be removing it. > Which reminds me of my email which you're still hiding from ;) > Shouldn't a `make mrproper' undo the effects of `make headers_install' > by wiping ./usr/include/? Ummm... warthog>cp .../.config . warthog>make -j12 >&/dev/null warthog>find usr/include/ | wc -l 873 warthog>make distclean >&/dev/null warthog>find usr/include/ | wc -l find: `usr/include/': No such file or directory 0 and: warthog>cp .../.config . warthog>make -j12 >&/dev/null warthog>find usr/include/ | wc -l 873 warthog>make mrproper >&/dev/null warthog>find usr/include/ | wc -l find: `usr/include/': No such file or directory 0 so I don't see the problem. David From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com ([209.132.183.28]:60124 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752573Ab3CZU7u (ORCPT ); Tue, 26 Mar 2013 16:59:50 -0400 From: David Howells In-Reply-To: <20130326131828.209aff73e38d3273d078bb2e@linux-foundation.org> References: <20130326131828.209aff73e38d3273d078bb2e@linux-foundation.org> <20130326174853.10144.36253.stgit@warthog.procyon.org.uk> Subject: Re: [PATCH] UAPI: Remove empty Kbuild files Date: Tue, 26 Mar 2013 20:59:43 +0000 Message-ID: <29647.1364331583@warthog.procyon.org.uk> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Andrew Morton Cc: dhowells@redhat.com, torvalds@linux-foundation.org, arnd@arndb.de, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org Message-ID: <20130326205943.WSpqpwEdkriep_JDyOYuUqF8hKWWc9N1bbj-jr-14pA@z> Andrew Morton wrote: > > Remove empty Kbuild files as they cause problems with the patch program > > which removes files that become empty. > > > > Should I also remove include/Kbuild as that now does nothing? Or should > > it be left as an anchor just in case we want it in future? > > I think that if the build system created it, a `make clean' or `make > mproper' should rub it out again. Ideally a `make mrproper' will give > you a tree which is identical to a freshly-untarred kernel.org tarball > (yes?). Ummm... What's that got to do with it? include/Kbuild is part of the sources: make clean/mrproper/distclean should not be removing it. > Which reminds me of my email which you're still hiding from ;) > Shouldn't a `make mrproper' undo the effects of `make headers_install' > by wiping ./usr/include/? Ummm... warthog>cp .../.config . warthog>make -j12 >&/dev/null warthog>find usr/include/ | wc -l 873 warthog>make distclean >&/dev/null warthog>find usr/include/ | wc -l find: `usr/include/': No such file or directory 0 and: warthog>cp .../.config . warthog>make -j12 >&/dev/null warthog>find usr/include/ | wc -l 873 warthog>make mrproper >&/dev/null warthog>find usr/include/ | wc -l find: `usr/include/': No such file or directory 0 so I don't see the problem. David