Generic Linux architectural discussions
 help / color / mirror / Atom feed
From: Muhammad Usama Anjum <usama.anjum@arm.com>
To: "David Hildenbrand (Arm)" <david@kernel.org>,
	Catalin Marinas <catalin.marinas@arm.com>
Cc: usama.anjum@arm.com, Andrew Morton <akpm@linux-foundation.org>,
	Lorenzo Stoakes <ljs@kernel.org>,
	Ryan Roberts <ryan.roberts@arm.com>,
	Will Deacon <will@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Anshuman Khandual <anshuman.khandual@arm.com>,
	Zi Yan <ziy@nvidia.com>,
	Alexander Gordeev <agordeev@linux.ibm.com>,
	Heiko Carstens <hca@linux.ibm.com>,
	Vasily Gorbik <gor@linux.ibm.com>,
	Samuel Holland <samuel.holland@sifive.com>,
	Peter Xu <peterx@redhat.com>,
	linux-mm@kvack.org, linux-arch@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/9] mm: distinguish HW PTE pointers from SW PTE value pointers
Date: Wed, 18 Nov 2026 21:48:45 +0000	[thread overview]
Message-ID: <2a84fa4f-655d-4c4d-b6ad-b2ee9d37d972@arm.com> (raw)
In-Reply-To: <5a6f351e-0a68-4bbf-a9fc-5bb39d8439a4@kernel.org>

On 16/11/2026 6:18 pm, David Hildenbrand (Arm) wrote:
> On 11/16/26 18:41, Catalin Marinas wrote:
>> Hi Usama,
>>
> Hi,
> 
> David here :)
> 
>> (trimmed the Cc list, some lists reject it as too many recipients)
>>
>> On Tue, Sep 22, 2026 at 06:12:28PM +0100, Muhammad Usama Anjum wrote:
>>> pte_t currently describes both a software PTE value and an element stored
>>> in a PTE table. Consequently, pte_t * can point either to a software PTE
>>> value, often a stack copy, or to a PTE-table slot. The compiler cannot
>>> distinguish these cases. A value pointer can therefore be passed to an
>>> interface that expects table storage, while table storage can be read by
>>> direct dereference instead of the architecture accessor.
>>>
>>> This series begins a staged conversion at the PTE level. It introduces
>>> hw_pte_t as the element type for PTE-table storage and converts generic
>>> MM to use hw_pte_t *. Software PTE values remain pte_t. Interfaces that
>>> intentionally return a value through pte_t *, such as install_pte,
>>> remain value interfaces; the relevant parameters are named ptentp to
>>> make that distinction explicit.
>>
>> [...]
>>
>>> PMD, PUD, P4D and PGD storage are deliberately out of scope. They can be
>>> converted in later series after the PTE boundary is agreed, avoiding the
>>> PMD-specific cases that made an all-level conversion difficult to
>>> review.
>>
>> I looked at this (and the arm64 counterpart) and I'm not fully convinced
>> it's worth the effort (but I won't oppose it if the mm folk decide to go
>> this route).
> 
> I think this is the right thing to do to get type safety.
> 
>>
>> First, I'd like to see all such on-stack p*d pointers addressed as a
>> prerequisite (e.g. fix pmd_populate() in __split_huge_zero_page_pmd()).
>> If for some reason we deem pmd not fixable, I don't like half (or
>> quarter) baked solutions just addressing the pte.
> 
> IIRC doing the full PxD conversion is quite big; doens't make sense to post
> these on the list and instead move stepwise.
> 
> Agreed that it would be nice to get rid of all stack usage first.
> 
>>
>> Second, we could add a run-time page table check, at least for pmd/pte.
>> Something like below, gated by CONFIG_PAGE_TABLE_CHECK or
>> CONFIG_DEBUG_VM (untested and not entirely sure about using
>> PageTable()):
>>
>> static inline void pgtable_ptr_check(struct mm_struct *mm, const void *p)
>> {
>> 	if (object_is_on_stack(p)) {
>> 		WARN_ON_ONCE(1);
>> 		return;
>> 	}
>> 	if (mm != &init_mm && virt_addr_valid(p))
>> 		WARN_ON_ONCE(!PageTable(virt_to_page(p)));
>> }
>>
>> You already have some coccinelle patches to make the conversion. Could
>> we turn them into a coccicheck to detect new uses? With LLM reviews like
>> Sashiko, we can probably catch new uses violating the requirement (we
>> need to document it).
>>
>> LLMs and coccicheck won't catch all abuses nor does this series prevent
>> one from declaring hw_pte_t on the stack.
>>
>> Once the above are in place, I'd look again at these patches and see
>> whether they improve code clarity and are worth the churn.
>>
>> Maybe an argument in favour of these patchsets is future dynamic support
>> for FEAT_D128, we'd need to separate the software representation of a
>> pte from the hardware one but we've done this before (arm32 non-LPAE has
>> different representations).
> 
> Exactly; we'll need this and go one step further and disallow any ptep++ to
> instead route this through helpers.

Agreed, after the current series, we can easily make hw_pte_t opaque like the
following (or in even better way if we spend some more time thinking about it):

diff --git a/include/linux/pgtable_types.h b/include/linux/pgtable_types.h
index ee4eace5c3e1c..9898c0613e170 100644
--- a/include/linux/pgtable_types.h
+++ b/include/linux/pgtable_types.h
@@ -7,17 +7,38 @@
 #ifndef __ASSEMBLY__
 
 #ifdef CONFIG_ARCH_HAS_HW_PTE_T
-typedef struct __hw_pte_t { pte_t __pte; } hw_pte_t;
+typedef struct __hw_pte_t hw_pte_t;
+typedef struct { pte_t __pte; } __hw_pte_storage_t;
 #define __pte_from_hw(pte)	((pte).__pte)
 
 #define hw_pte_val(x)  pte_val((x).__pte)
 #else
 #define hw_pte_t pte_t
+typedef pte_t __hw_pte_storage_t;
 #define __pte_from_hw(pte)	(pte)
 
 #define hw_pte_val(x)  pte_val(x)
 #endif
 
+static inline hw_pte_t *ptep_advance(hw_pte_t *ptep, long nr)
+{
+	return (hw_pte_t *)((__hw_pte_storage_t *)ptep + nr);
+}
+
+static inline hw_pte_t *ptep_align_down(hw_pte_t *ptep, unsigned long nr)
+{
+	unsigned long size = sizeof(__hw_pte_storage_t) * nr;
+
+	return (hw_pte_t *)((unsigned long)ptep & ~(size - 1));
+}
+
+static inline long ptep_diff(const hw_pte_t *ptep,
+		const hw_pte_t *start_ptep)
+{
+	return (const __hw_pte_storage_t *)ptep -
+		(const __hw_pte_storage_t *)start_ptep;
+}
+
 #endif /* !__ASSEMBLY__ */
 
 #endif /* _LINUX_PGTABLE_TYPES_H */


-- 
Thanks,
Usama

  reply	other threads:[~2026-11-18 21:49 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-22 17:12 [PATCH v3 0/9] mm: distinguish HW PTE pointers from SW PTE value pointers Muhammad Usama Anjum
2026-09-22 17:12 ` [PATCH v3 1/9] mm: introduce hw_pte_t for PTE table storage Muhammad Usama Anjum
2026-09-30  4:13   ` Anshuman Khandual
2026-09-30 15:27   ` Zi Yan
2026-09-22 17:12 ` [PATCH v3 2/9] mm: rename pointers to software PTE values as ptentp Muhammad Usama Anjum
2026-09-30  4:20   ` Anshuman Khandual
2026-09-22 17:12 ` [PATCH v3 3/9] mm: use hw_pte_t for generic PTE table storage Muhammad Usama Anjum
2026-09-30  4:35   ` Anshuman Khandual
2026-09-30 17:40     ` Muhammad Usama Anjum
2026-10-01 11:25       ` David Hildenbrand (Arm)
2026-10-01 11:26   ` David Hildenbrand (Arm)
2026-09-22 17:12 ` [PATCH v3 4/9] mm: convert PTE table entries in ptep_get() Muhammad Usama Anjum
2026-09-30  5:10   ` Anshuman Khandual
2026-09-30 17:46     ` Muhammad Usama Anjum
2026-10-01 11:27   ` David Hildenbrand (Arm)
2026-09-22 17:12 ` [PATCH v3 5/9] mm: convert PTE table entry to pte Muhammad Usama Anjum
2026-10-01 11:17   ` David Hildenbrand (Arm)
2026-10-02 14:57     ` Muhammad Usama Anjum
2026-09-22 17:12 ` [PATCH v3 6/9] mm: add hw_pte_val for HW PTE storage Muhammad Usama Anjum
2026-10-01 11:19   ` David Hildenbrand (Arm)
2026-10-02 14:59     ` Muhammad Usama Anjum
2026-09-22 17:12 ` [PATCH v3 7/9] mm/kasan: use hw_pte_t for the early shadow PTE table Muhammad Usama Anjum
2026-10-01 11:20   ` David Hildenbrand (Arm)
2026-09-22 17:12 ` [PATCH v3 8/9] drm/i915: use hw_pte_t for PTE range callbacks Muhammad Usama Anjum
2026-10-01 11:21   ` David Hildenbrand (Arm)
2026-09-22 17:12 ` [PATCH v3 9/9] xen: " Muhammad Usama Anjum
2026-10-01 11:22   ` David Hildenbrand (Arm)
2026-09-28  7:09 ` [PATCH v3 0/9] mm: distinguish HW PTE pointers from SW PTE value pointers Alexander Gordeev
2026-11-16 17:41 ` Catalin Marinas
2026-11-16 18:18   ` David Hildenbrand (Arm)
2026-11-18 21:48     ` Muhammad Usama Anjum [this message]
2026-11-18 21:41   ` Muhammad Usama Anjum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2a84fa4f-655d-4c4d-b6ad-b2ee9d37d972@arm.com \
    --to=usama.anjum@arm.com \
    --cc=agordeev@linux.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=anshuman.khandual@arm.com \
    --cc=catalin.marinas@arm.com \
    --cc=david@kernel.org \
    --cc=gor@linux.ibm.com \
    --cc=hca@linux.ibm.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=ljs@kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=peterx@redhat.com \
    --cc=ryan.roberts@arm.com \
    --cc=samuel.holland@sifive.com \
    --cc=will@kernel.org \
    --cc=ziy@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox