From: "Arnd Bergmann" <arnd@arndb.de>
To: "Ignacio Encinas" <ignacio@iencinas.com>,
"Paul Walmsley" <paul.walmsley@sifive.com>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Alexandre Ghiti" <alex@ghiti.fr>
Cc: "Eric Biggers" <ebiggers@kernel.org>,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-kernel-mentees@lists.linux.dev,
"Shuah Khan" <skhan@linuxfoundation.org>,
"Zhihang Shao" <zhihang.shao.iscas@gmail.com>,
"Björn Töpel" <bjorn@kernel.org>,
Linux-Arch <linux-arch@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] include/uapi/linux/swab.h: move default implementation for swab macros into asm-generic
Date: Wed, 19 Mar 2025 22:12:49 +0100 [thread overview]
Message-ID: <2afab9dc-e39c-4399-ac5a-87ade4da5ab0@app.fastmail.com> (raw)
In-Reply-To: <20250319-riscv-swab-v2-1-d53b6d6ab915@iencinas.com>
On Wed, Mar 19, 2025, at 22:09, Ignacio Encinas wrote:
> Move the default byteswap implementation into asm-generic so that it can
> be included from arch code.
>
> This is required by RISC-V in order to have a fallback implementation
> without duplicating it.
>
> Signed-off-by: Ignacio Encinas <ignacio@iencinas.com>
> ---
> include/uapi/asm-generic/swab.h | 32 ++++++++++++++++++++++++++++++++
> include/uapi/linux/swab.h | 33 +--------------------------------
> 2 files changed, 33 insertions(+), 32 deletions(-)
>
I think we should just remove these entirely in favor of the
compiler-povided built-ins.
Arnd
next prev parent reply other threads:[~2025-03-19 21:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-19 21:09 [PATCH v2 0/2] Implement endianness swap macros for RISC-V Ignacio Encinas
2025-03-19 21:09 ` [PATCH v2 1/2] include/uapi/linux/swab.h: move default implementation for swab macros into asm-generic Ignacio Encinas
2025-03-19 21:12 ` Arnd Bergmann [this message]
2025-03-19 21:37 ` Ignacio Encinas Rubio
2025-03-19 21:49 ` Arnd Bergmann
2025-03-20 22:36 ` Ignacio Encinas Rubio
2025-03-21 10:23 ` Arnd Bergmann
2025-03-21 18:38 ` Ignacio Encinas Rubio
2025-03-19 21:09 ` [PATCH v2 2/2] riscv: introduce asm/swab.h Ignacio Encinas
2025-03-21 3:37 ` Eric Biggers
2025-03-21 21:07 ` Ignacio Encinas Rubio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2afab9dc-e39c-4399-ac5a-87ade4da5ab0@app.fastmail.com \
--to=arnd@arndb.de \
--cc=alex@ghiti.fr \
--cc=bjorn@kernel.org \
--cc=ebiggers@kernel.org \
--cc=ignacio@iencinas.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=skhan@linuxfoundation.org \
--cc=zhihang.shao.iscas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox