From: Arnd Bergmann <arnd@arndb.de>
To: Mikko Rapeli <mikko.rapeli@iki.fi>
Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
linux-api@vger.kernel.org
Subject: Re: [PATCH 45/45] include/uapi/asm-generic/ucontext.h: include signal.h and sigcontext.h
Date: Tue, 17 Feb 2015 10:10:42 +0100 [thread overview]
Message-ID: <3121580.utRRJPcIC6@wuerfel> (raw)
In-Reply-To: <1424127948-22484-46-git-send-email-mikko.rapeli@iki.fi>
On Tuesday 17 February 2015 00:05:48 Mikko Rapeli wrote:
> #ifndef __ASM_GENERIC_UCONTEXT_H
> #define __ASM_GENERIC_UCONTEXT_H
>
> +#include <asm-generic/signal.h>
> +#include <asm/sigcontext.h>
> +
> struct ucontext {
>
Including another asm-generic header here is a bad idea: it breaks
if an architecture overrides asm/signal.h with its own version
but wants to use the asm-generic/ucontext.h file.
It would be best to just use linux/signal.h here, which includes
the correct architecture specific files.
Arnd
next prev parent reply other threads:[~2015-02-17 9:10 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1424127948-22484-1-git-send-email-mikko.rapeli@iki.fi>
2015-02-16 23:05 ` [PATCH 28/45] include/uapi/asm-generic/ipcbuf.h: include linux/posix_types.h Mikko Rapeli
2015-02-16 23:05 ` Mikko Rapeli
[not found] ` <1424127948-22484-1-git-send-email-mikko.rapeli-X3B1VOXEql0@public.gmane.org>
2015-02-16 23:05 ` [PATCH 29/45] include/uapi/asm-generic/msgbuf.h: include asm/ipcbuf.h Mikko Rapeli
2015-02-16 23:05 ` Mikko Rapeli
2015-02-16 23:05 ` [PATCH 30/45] include/uapi/asm-generic/shmbuf.h: include fixes Mikko Rapeli
2015-02-16 23:05 ` Mikko Rapeli
2015-02-16 23:05 ` [PATCH 31/45] asm-generic/sembuf.h: include asm/posix_types.h and asm/ipcbuf.h Mikko Rapeli
2015-02-16 23:05 ` Mikko Rapeli
2015-02-16 23:05 ` [PATCH 33/45] include/uapi/asm-generic/signal.h: include stdlib.h in userspace Mikko Rapeli
2015-02-16 23:05 ` Mikko Rapeli
[not found] ` <1424127948-22484-34-git-send-email-mikko.rapeli-X3B1VOXEql0@public.gmane.org>
2015-02-17 9:44 ` Arnd Bergmann
2015-02-17 9:44 ` Arnd Bergmann
2015-03-10 22:58 ` Mikko Rapeli
[not found] ` <20150310225828.GZ12550-dqH1CgrzRhOk/eJAJmRu5A@public.gmane.org>
2015-03-11 10:02 ` Arnd Bergmann
2015-03-11 10:02 ` Arnd Bergmann
2015-02-16 23:05 ` [PATCH 34/45] include/uapi/asm-generic/signal.h: hide sigset_t definition " Mikko Rapeli
2015-02-16 23:05 ` Mikko Rapeli
[not found] ` <1424127948-22484-35-git-send-email-mikko.rapeli-X3B1VOXEql0@public.gmane.org>
2015-02-17 9:16 ` Arnd Bergmann
2015-02-17 9:16 ` Arnd Bergmann
2015-03-11 0:05 ` Mikko Rapeli
2015-02-16 23:05 ` [PATCH 45/45] include/uapi/asm-generic/ucontext.h: include signal.h and sigcontext.h Mikko Rapeli
2015-02-16 23:05 ` Mikko Rapeli
2015-02-17 9:10 ` Arnd Bergmann [this message]
2015-03-11 1:59 ` Mikko Rapeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3121580.utRRJPcIC6@wuerfel \
--to=arnd@arndb.de \
--cc=linux-api@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikko.rapeli@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox