From: David Howells <dhowells@redhat.com>
To: Rusty Russell <rusty@rustcorp.com.au>, Arnd Bergmann <arnd@arndb.de>
Cc: dhowells@redhat.com, linux-arch@vger.kernel.org,
Ralf Baechle <ralf@linux-mips.org>,
Sam Ravnborg <sam@ravnborg.org>,
Fengguang Wu <fengguang.wu@intel.com>
Subject: Re: [PATCH] Make most arch asm/module.h files use asm-generic/module.h [ver #2]
Date: Thu, 19 Jul 2012 12:40:46 +0100 [thread overview]
Message-ID: <31321.1342698046@warthog.procyon.org.uk> (raw)
In-Reply-To: <20105.1342623053@warthog.procyon.org.uk>
David Howells <dhowells@redhat.com> wrote:
> +static inline int apply_relocate(Elf_Shdr *sechdrs,
> + const char *strtab,
> + unsigned int symindex,
> + unsigned int relsec,
> + struct module *me)
> +{
> + pr_err("module %s: REL relocation unsupported\n", me->name);
> + return -ENOEXEC;
> +}
Turns out you cannot use pr_err() and friends in a header file, lest it get
included in a file that defines pr_fmt() to be something inconvenient.
Thanks to Fengguang and his GIT tree cruncher for finding this in Blackfin
with the BF526-EZBRD_defconfig.
David
next prev parent reply other threads:[~2012-07-19 11:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-18 14:50 [PATCH] Make most arch asm/module.h files use asm-generic/module.h [ver #2] David Howells
2012-07-19 11:40 ` David Howells [this message]
2012-07-19 13:07 ` Fengguang Wu
2012-07-19 13:30 ` Mike Frysinger
2012-07-20 8:13 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31321.1342698046@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=arnd@arndb.de \
--cc=fengguang.wu@intel.com \
--cc=linux-arch@vger.kernel.org \
--cc=ralf@linux-mips.org \
--cc=rusty@rustcorp.com.au \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).