Re: [PATCH] Adds a new ioctl32 syscall for backwards compatibility layers

Christoph Hellwig
2021-01-16T09:08:23Z

On Fri, Jan 15, 2021 at 04:07:46PM -0800, Andy Lutomirski wrote:
> Finally, I'm not convinced that this patch works correctly. We have
> in_compat_syscall(), and code that uses it may well be reachable from
> ioctl.

ioctls are the prime user of in_compat_syscall().

> I personally would like to see in_compat_syscall() go away,
> but some other people (Hi, Christoph!) disagree, and usage seems to be
> increasing, not decreasing.

I'm absolutely against it going away. in_compat_syscall helped to
remove so much crap compared to the explicit compat syscalls.