Re: [PATCH 7/9] x86: vdso: Modify asm/vdso/getrandom.h to include datapage

Vincenzo Frascino
2024-09-06T11:48:19Z

On 04/09/2024 18:19, Christophe Leroy wrote:
>
>
> Le 03/09/2024 à 17:14, Vincenzo Frascino a écrit :
>> The VDSO implementation includes headers from outside of the
>> vdso/ namespace.
>>
>> Modify asm/vdso/getrandom.h to include datapage.
>
> Does  asm/vdso/getrandom.h need datapage ? If not it is the ones that need it
> that should include it.
>

Why do you think it does not need it?

>>
>> Cc: Andy Lutomirski <luto@kernel.org>
>> Cc: Thomas Gleixner <tglx@linutronix.de>
>> Cc: Jason A. Donenfeld <Jason@zx2c4.com>
>> Signed-off-by: Vincenzo Frascino <vincenzo.frascino@arm.com>
>> ---
>>   arch/x86/include/asm/vdso/getrandom.h | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/arch/x86/include/asm/vdso/getrandom.h
>> b/arch/x86/include/asm/vdso/getrandom.h
>> index ff5334ad32a0..4597d5a6f094 100644
>> --- a/arch/x86/include/asm/vdso/getrandom.h
>> +++ b/arch/x86/include/asm/vdso/getrandom.h
>> @@ -7,6 +7,8 @@
>>     #ifndef __ASSEMBLY__
>>   +#include <vdso/datapage.h>
>> +
>>   #include <asm/unistd.h>
>>   #include <asm/vvar.h>
>>

--
Regards,
Vincenzo