Re: [PATCH 9/9] vdso: Modify getrandom to include the correct namespace

Vincenzo Frascino
2024-09-06T11:52:57Z

On 04/09/2024 18:26, Christophe Leroy wrote:
>
>
> Le 03/09/2024 à 17:14, Vincenzo Frascino a écrit :
...

>
> Now build fails on powerpc because struct vgetrandom_opaque_params is unknown.
>
> x86 get it by chance via the following header inclusion chain:
>
> In file included from ./include/linux/random.h:10,
>                  from ./include/linux/nodemask.h:98,
>                  from ./include/linux/mmzone.h:18,
>                  from ./include/linux/gfp.h:7,
>                  from ./include/linux/xarray.h:16,
>                  from ./include/linux/radix-tree.h:21,
>                  from ./include/linux/idr.h:15,
>                  from ./include/linux/kernfs.h:12,
>                  from ./include/linux/sysfs.h:16,
>                  from ./include/linux/kobject.h:20,
>                  from ./include/linux/of.h:18,
>                  from ./include/linux/clocksource.h:19,
>                  from ./include/clocksource/hyperv_timer.h:16,
>                  from ./arch/x86/include/asm/vdso/gettimeofday.h:21,
>                  from ./include/vdso/datapage.h:164,
>                  from arch/x86/entry/vdso/../../../../lib/vdso/getrandom.c:7,
>                  from arch/x86/entry/vdso/vgetrandom.c:7:
>
>
>
>

This tells me very little ;)

Can you please provide more details? e.g. What is the error you are getting? How
do I reproduce it?

I am happy to include the required change as part of this series.

Overall, the reason why I am doing this exercise it to sanitize the headers for
all the architectures so that in future we do not have issues. It is good we
find problems now.

--
Regards,
Vincenzo