From: Niels Dettenbach <nd@syndicat.com>
To: linux-arch@vger.kernel.org
Cc: stable@vger.kernel.org, trivial@kernel.org
Subject: Re: [PATCH 1/1] x86: SMT broken on Xen PV DomU since 6.9 (updated)
Date: Wed, 11 Sep 2024 17:49:46 +0200 [thread overview]
Message-ID: <3301863.oiGErgHkdL@gongov> (raw)
In-Reply-To: <4242435.1IzOArtZ34@gongov>
Am Mittwoch, 11. September 2024, 10:53:30 schrieb Niels Dettenbach:
> virtual machines under Xen Hypervisor (DomU) running in Xen PV mode use a
> special, nonstandard synthetized CPU topology which "just works" under
> kernels 6.9.x while newer kernels assuming a "crash kernel" and disable
> SMT (reducing to one CPU core) because the newer topology implementation
> produces a wrong error "[Firmware Bug]: APIC enumeration order not
> specification compliant" after new topology checks which are improper for
> Xen PV platform. As a result, the kernel disables SMT and activates just
> one CPU core within the VM (DomU).
>
> The patch disables the regarding checks if it is running in Xen PV
> mode (only) and bring back SMT / all CPUs as in the past to such DomU
> VMs.
>
> Signed-off-by: Niels Dettenbach <nd@syndicat.com>
>
Signed-off-by: Niels Dettenbach <nd@syndicat.com>
---
A reworked proposal patch which substitutes my initial proposed patch:
--- linux/arch/x86/kernel/cpu/topology.c 2024-09-11 17:42:42.699278317 +0200
+++ linux/arch/x86/kernel/cpu/topology.c.orig 2024-09-11 09:53:16.194095250 +0200
@@ -132,14 +132,6 @@
u64 msr;
/*
- * assume Xen PV has a working (special) topology
- */
- if (xen_pv_domain()) {
- topo_info.real_bsp_apic_id = topo_info.boot_cpu_apic_id;
- return false;
- }
-
- /*
* There is no real good way to detect whether this a kdump()
* kernel, but except on the Voyager SMP monstrosity which is not
* longer supported, the real BSP APIC ID is the first one which is
next prev parent reply other threads:[~2024-09-11 15:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-11 8:53 [PATCH 1/1] x86: SMT broken on Xen PV DomU since 6.9 Niels Dettenbach
2024-09-11 15:49 ` Niels Dettenbach [this message]
2024-09-12 5:21 ` [PATCH 1/1] x86: SMT broken on Xen PV DomU since 6.9 (updated) Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3301863.oiGErgHkdL@gongov \
--to=nd@syndicat.com \
--cc=linux-arch@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox