From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Hansen Subject: Re: [RFC PATCH v9 11/27] drm/i915/gvt: Change _PAGE_DIRTY to _PAGE_DIRTY_BITS Date: Wed, 26 Feb 2020 14:04:43 -0800 Message-ID: <34c83f97-f206-1b43-db40-7e6a7d0f6bb7@intel.com> References: <20200205181935.3712-1-yu-cheng.yu@intel.com> <20200205181935.3712-12-yu-cheng.yu@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <20200205181935.3712-12-yu-cheng.yu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> Content-Language: en-US Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Yu-cheng Yu , x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, linux-arch-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Borislav Petkov , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H.J. Lu" , Jann Horn , Jonathan Corbet , Kees Cook , Mike Kravetz List-Id: linux-arch.vger.kernel.org On 2/5/20 10:19 AM, Yu-cheng Yu wrote: > diff --git a/drivers/gpu/drm/i915/gvt/gtt.c b/drivers/gpu/drm/i915/gvt/gtt.c > index 4b04af569c05..e467ca182633 100644 > --- a/drivers/gpu/drm/i915/gvt/gtt.c > +++ b/drivers/gpu/drm/i915/gvt/gtt.c > @@ -1201,7 +1201,7 @@ static int split_2MB_gtt_entry(struct intel_vgpu *vgpu, > } > > /* Clear dirty field. */ > - se->val64 &= ~_PAGE_DIRTY; > + se->val64 &= ~_PAGE_DIRTY_BITS; > > ops->clear_pse(se); > ops->clear_ips(se); Are the i915 maintainers on cc? Shouldn't this use pte_mkclean() instead of open-coding? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [RFC PATCH v9 11/27] drm/i915/gvt: Change _PAGE_DIRTY to _PAGE_DIRTY_BITS References: <20200205181935.3712-1-yu-cheng.yu@intel.com> <20200205181935.3712-12-yu-cheng.yu@intel.com> From: Dave Hansen Message-ID: <34c83f97-f206-1b43-db40-7e6a7d0f6bb7@intel.com> Date: Wed, 26 Feb 2020 14:04:43 -0800 MIME-Version: 1.0 In-Reply-To: <20200205181935.3712-12-yu-cheng.yu@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Sender: owner-linux-mm@kvack.org To: Yu-cheng Yu , x86@kernel.org, "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Borislav Petkov , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H.J. Lu" , Jann Horn , Jonathan Corbet , Kees Cook , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , Randy Dunlap , "Ravi V. Shankar" , Vedvyas Shanbhogue , Dave Martin , x86-patch-review@intel.com List-ID: Message-ID: <20200226220443.QtYP1FFqieLQ5zily5ZmWJT0MFsO1bgkfN9SojNf1_c@z> On 2/5/20 10:19 AM, Yu-cheng Yu wrote: > diff --git a/drivers/gpu/drm/i915/gvt/gtt.c b/drivers/gpu/drm/i915/gvt/= gtt.c > index 4b04af569c05..e467ca182633 100644 > --- a/drivers/gpu/drm/i915/gvt/gtt.c > +++ b/drivers/gpu/drm/i915/gvt/gtt.c > @@ -1201,7 +1201,7 @@ static int split_2MB_gtt_entry(struct intel_vgpu = *vgpu, > } > =20 > /* Clear dirty field. */ > - se->val64 &=3D ~_PAGE_DIRTY; > + se->val64 &=3D ~_PAGE_DIRTY_BITS; > =20 > ops->clear_pse(se); > ops->clear_ips(se); Are the i915 maintainers on cc? Shouldn't this use pte_mkclean() instead of open-coding?