From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robin Murphy Subject: Re: [PATCH 11/33] dma-mapping: move swiotlb arch helpers to a new header Date: Wed, 10 Jan 2018 14:56:01 +0000 Message-ID: <3721b4ba-0685-255e-06b9-6e60678a1a92@arm.com> References: <20180110080027.13879-1-hch@lst.de> <20180110080027.13879-12-hch@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20180110080027.13879-12-hch-jcswGhMUV9g@public.gmane.org> Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Christoph Hellwig , iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Cc: linux-mips-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org, linux-ia64-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-sh-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, sparclinux-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Guan Xuetao , linux-arch-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-s390-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-c6x-dev-jPsnJVOj+W6hPH1hqNUYSQ@public.gmane.org, linux-hexagon-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, Konrad Rzeszutek Wilk , linux-snps-arc-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-m68k-cunTk1MwBs8S/qaLPR03pWD2FQJk+8+b@public.gmane.org, patches-q3qR2WxjNRFS9aJRtSZj7A@public.gmane.org, linux-metag-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Michal Simek , linux-cris-kernel-VrBV9hrLPhE@public.gmane.org, linux-parisc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-alpha-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org List-Id: linux-arch.vger.kernel.org On 10/01/18 08:00, Christoph Hellwig wrote: > phys_to_dma, dma_to_phys and dma_capable are helpers published by > architecture code for use of swiotlb and xen-swiotlb only. Drivers are > not supposed to use these directly, but use the DMA API instead. > > Move these to a new asm/dma-direct.h helper, included by a > linux/dma-direct.h wrapper that provides the default linear mapping > unless the architecture wants to override it. > > Signed-off-by: Christoph Hellwig > --- [...] > drivers/crypto/marvell/cesa.c | 1 + > drivers/mtd/nand/qcom_nandc.c | 1 + I took a look at these, and it seems their phys_to_dma() usage is doing the thing which we subsequently formalised as dma_map_resource(). I've had a crack at a quick patch to update the CESA driver; qcom_nandc looks slightly more complex in that the changes probably need to span the BAM dmaengine driver as well. In the process, though, I stumbled across gen_pool_dma_alloc() - yuck, something needs doing there, for sure... Robin. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:43364 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751352AbeAJO4I (ORCPT ); Wed, 10 Jan 2018 09:56:08 -0500 Subject: Re: [PATCH 11/33] dma-mapping: move swiotlb arch helpers to a new header References: <20180110080027.13879-1-hch@lst.de> <20180110080027.13879-12-hch@lst.de> From: Robin Murphy Message-ID: <3721b4ba-0685-255e-06b9-6e60678a1a92@arm.com> Date: Wed, 10 Jan 2018 14:56:01 +0000 MIME-Version: 1.0 In-Reply-To: <20180110080027.13879-12-hch@lst.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Christoph Hellwig , iommu@lists.linux-foundation.org Cc: linux-mips@linux-mips.org, linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, Guan Xuetao , linux-arch@vger.kernel.org, linux-s390@vger.kernel.org, linux-c6x-dev@linux-c6x.org, linux-hexagon@vger.kernel.org, x86@kernel.org, Konrad Rzeszutek Wilk , linux-snps-arc@lists.infradead.org, linux-m68k@lists.linux-m68k.org, patches@groups.riscv.org, linux-metag@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Michal Simek , linux-parisc@vger.kernel.org, linux-cris-kernel@axis.com, linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Message-ID: <20180110145601.vM-zTBFRXJVeTsaMeEyr-jLgpB8zSncSpXT7XDge8Ik@z> On 10/01/18 08:00, Christoph Hellwig wrote: > phys_to_dma, dma_to_phys and dma_capable are helpers published by > architecture code for use of swiotlb and xen-swiotlb only. Drivers are > not supposed to use these directly, but use the DMA API instead. > > Move these to a new asm/dma-direct.h helper, included by a > linux/dma-direct.h wrapper that provides the default linear mapping > unless the architecture wants to override it. > > Signed-off-by: Christoph Hellwig > --- [...] > drivers/crypto/marvell/cesa.c | 1 + > drivers/mtd/nand/qcom_nandc.c | 1 + I took a look at these, and it seems their phys_to_dma() usage is doing the thing which we subsequently formalised as dma_map_resource(). I've had a crack at a quick patch to update the CESA driver; qcom_nandc looks slightly more complex in that the changes probably need to span the BAM dmaengine driver as well. In the process, though, I stumbled across gen_pool_dma_alloc() - yuck, something needs doing there, for sure... Robin.