From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A43C33B8D6C; Sat, 6 Dec 2025 02:51:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=96.67.55.147 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764989479; cv=none; b=CumfmEfOSS1wnCMt2nh23Q2uuxwqR38rNZx3N0talj3Gdgmle+cpYksQcdDmTE7SLFetCi3pPmZc95wBombBOUjLmNNy42dSDDcPMSDaBJ8lmUexDtzHiTjg82Rel5UPwx1moprvedGif0ijs/DzJev8LHpTxdFXgrKCFbtUMQE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764989479; c=relaxed/simple; bh=46i4JdpR+8kUV3f1SyUYziYHtT5tVVSL7qw/bHAaonY=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=FzTi5gSUcmCOUlq+lyutvEAWQJlVJelZoG7NTtqf7wfB49RU+bOni/D9K0jq6d/wNmbO/DIk/JWQVNpM80d8TUtdtn6UB8Nub+aF3G4SDI6vxpB9dMzLqB889If56wU9GX5tWwKgo/jOfCqExtaFjCeW0GopBqNdsjhsovMy/do= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=surriel.com; spf=pass smtp.mailfrom=surriel.com; dkim=pass (2048-bit key) header.d=surriel.com header.i=@surriel.com header.b=JxwpmNur; arc=none smtp.client-ip=96.67.55.147 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=surriel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=surriel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=surriel.com header.i=@surriel.com header.b="JxwpmNur" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=surriel.com ; s=mail; h=MIME-Version:Content-Transfer-Encoding:Content-Type:References: In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=46i4JdpR+8kUV3f1SyUYziYHtT5tVVSL7qw/bHAaonY=; b=JxwpmNurKOPe7xdTaNKzFhbUjz 2+atJh5c6Ubg+NoOSUMWKObtHEXfymc0DOnXNL9yoRkLTddJBv9ByFJora6bNy+4zaRGadNIeq+B6 PvsNpOvYjWvx6JWKquKqNviKIfYR8B8MoL12pssq2YGmc1w7cJGcfo85AI0YdZK+4qkIVfqNtfKOX 9/0JxASVFchfnYmChRw9HqRTcWdVCfksTa5td5XVJnMZ28AvMNOFQOUZJulQYnZ+e2X/DpoTrhtoM d6PXJIsYMBsGZl62IGOokOSKG8qcmFYy7VMdGY5L3E96qGFxp0/CSCfj9Hx+9VDxvPbPHcib0Yu/7 pEkRM8xA==; Received: from fangorn.home.surriel.com ([10.0.13.7]) by shelob.surriel.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.97.1) (envelope-from ) id 1vRiNo-000000005lS-0ehm; Fri, 05 Dec 2025 21:50:53 -0500 Message-ID: <3a574abe86703f925c9ce8b751ca5fb1370d1ce2.camel@surriel.com> Subject: Re: [PATCH v1 3/4] mm/rmap: fix two comments related to huge_pmd_unshare() From: Rik van Riel To: "David Hildenbrand (Red Hat)" , linux-kernel@vger.kernel.org Cc: linux-arch@vger.kernel.org, linux-mm@kvack.org, Will Deacon , "Aneesh Kumar K.V" , Andrew Morton , Nick Piggin , Peter Zijlstra , Arnd Bergmann , Muchun Song , Oscar Salvador , "Liam R. Howlett" , Lorenzo Stoakes , Vlastimil Babka , Jann Horn , Pedro Falcato , Harry Yoo , Laurence Oberman , Prakash Sangappa , Nadav Amit , Liu Shixin Date: Fri, 05 Dec 2025 21:50:53 -0500 In-Reply-To: <20251205213558.2980480-4-david@kernel.org> References: <20251205213558.2980480-1-david@kernel.org> <20251205213558.2980480-4-david@kernel.org> Autocrypt: addr=riel@surriel.com; prefer-encrypt=mutual; keydata=mQENBFIt3aUBCADCK0LicyCYyMa0E1lodCDUBf6G+6C5UXKG1jEYwQu49cc/gUBTTk33A eo2hjn4JinVaPF3zfZprnKMEGGv4dHvEOCPWiNhlz5RtqH3SKJllq2dpeMS9RqbMvDA36rlJIIo47 Z/nl6IA8MDhSqyqdnTY8z7LnQHqq16jAqwo7Ll9qALXz4yG1ZdSCmo80VPetBZZPw7WMjo+1hByv/ lvdFnLfiQ52tayuuC1r9x2qZ/SYWd2M4p/f5CLmvG9UcnkbYFsKWz8bwOBWKg1PQcaYHLx06sHGdY dIDaeVvkIfMFwAprSo5EFU+aes2VB2ZjugOTbkkW2aPSWTRsBhPHhV6dABEBAAG0HlJpayB2YW4gU mllbCA8cmllbEByZWRoYXQuY29tPokBHwQwAQIACQUCW5LcVgIdIAAKCRDOed6ShMTeg05SB/986o gEgdq4byrtaBQKFg5LWfd8e+h+QzLOg/T8mSS3dJzFXe5JBOfvYg7Bj47xXi9I5sM+I9Lu9+1XVb/ r2rGJrU1DwA09TnmyFtK76bgMF0sBEh1ECILYNQTEIemzNFwOWLZZlEhZFRJsZyX+mtEp/WQIygHV WjwuP69VJw+fPQvLOGn4j8W9QXuvhha7u1QJ7mYx4dLGHrZlHdwDsqpvWsW+3rsIqs1BBe5/Itz9o 6y9gLNtQzwmSDioV8KhF85VmYInslhv5tUtMEppfdTLyX4SUKh8ftNIVmH9mXyRCZclSoa6IMd635 Jq1Pj2/Lp64tOzSvN5Y9zaiCc5FucXtB9SaWsgdmFuIFJpZWwgPHJpZWxAc3VycmllbC5jb20+iQE +BBMBAgAoBQJSLd2lAhsjBQkSzAMABgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgAAKCRDOed6ShMTe g4PpB/0ZivKYFt0LaB22ssWUrBoeNWCP1NY/lkq2QbPhR3agLB7ZXI97PF2z/5QD9Fuy/FD/jddPx KRTvFCtHcEzTOcFjBmf52uqgt3U40H9GM++0IM0yHusd9EzlaWsbp09vsAV2DwdqS69x9RPbvE/Ne fO5subhocH76okcF/aQiQ+oj2j6LJZGBJBVigOHg+4zyzdDgKM+jp0bvDI51KQ4XfxV593OhvkS3z 3FPx0CE7l62WhWrieHyBblqvkTYgJ6dq4bsYpqxxGJOkQ47WpEUx6onH+rImWmPJbSYGhwBzTo0Mm G1Nb1qGPG+mTrSmJjDRxrwf1zjmYqQreWVSFEt26tBpSaWsgdmFuIFJpZWwgPHJpZWxAZmIuY29tP okBPgQTAQIAKAUCW5LbiAIbIwUJEswDAAYLCQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQznneko TE3oOUEQgAsrGxjTC1bGtZyuvyQPcXclap11Ogib6rQywGYu6/Mnkbd6hbyY3wpdyQii/cas2S44N cQj8HkGv91JLVE24/Wt0gITPCH3rLVJJDGQxprHTVDs1t1RAbsbp0XTksZPCNWDGYIBo2aHDwErhI omYQ0Xluo1WBtH/UmHgirHvclsou1Ks9jyTxiPyUKRfae7GNOFiX99+ZlB27P3t8CjtSO831Ij0Ip QrfooZ21YVlUKw0Wy6Ll8EyefyrEYSh8KTm8dQj4O7xxvdg865TLeLpho5PwDRF+/mR3qi8CdGbkE c4pYZQO8UDXUN4S+pe0aTeTqlYw8rRHWF9TnvtpcNzZw== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.2 (3.56.2-2.fc42) Precedence: bulk X-Mailing-List: linux-arch@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Fri, 2025-12-05 at 22:35 +0100, David Hildenbrand (Red Hat) wrote: > PMD page table unsharing no longer touches the refcount of a PMD page > table. Also, it is not about dropping the refcount of a "PMD page" > but > the "PMD page table". >=20 > Let's just simplify by saying that the PMD page table was unmapped, > consequently also unmapping the folio that was mapped into this page. >=20 > This code should be deduplicated in the future. >=20 > Fixes: 59d9094df3d7 ("mm: hugetlb: independent PMD page table shared > count") > Cc: Liu Shixin > Signed-off-by: David Hildenbrand (Red Hat) >=20 Reviewed-by: Rik van Riel --=20 All Rights Reversed.