From mboxrd@z Thu Jan 1 00:00:00 1970 From: Timothy Pearson Subject: Re: [PATCH RFC 3/5] powerpc/speculation: Add support for 'cpu_spec_mitigations=' cmdline options Date: Thu, 4 Apr 2019 15:01:04 -0500 (CDT) Message-ID: <401506569.4710878.1554408064001.JavaMail.zimbra@raptorengineeringinc.com> References: <91b92d8182d2f114d92c95689fcd4bb1a8dda1b0.1554396090.git.jpoimboe@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Jiri Kosina Cc: Peter Zijlstra , Catalin Marinas , Will Deacon , Paul Mackerras , "H . Peter Anvin" , Ingo Molnar , Andrea Arcangeli , linux-s390@vger.kernel.org, x86@kernel.org, Jon Masters , Waiman Long , linux-arch@vger.kernel.org, Heiko Carstens , linuxppc-dev@lists.ozlabs.org, Borislav Petkov , Andy Lutomirski , Josh Poimboeuf , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Tyler Hicks , Martin Schwidefsky , Linus Torvalds List-Id: linux-arch.vger.kernel.org Will be joining in ~ 5 mins. Getting Chromium set up here. ----- Original Message ----- > From: "Jiri Kosina" > To: "Josh Poimboeuf" > Cc: "Peter Zijlstra" , "Heiko Carstens" , "Paul Mackerras" > , "H . Peter Anvin" , "Ingo Molnar" , "Andrea Arcangeli" > , linux-s390@vger.kernel.org, x86@kernel.org, "Will Deacon" , "Linus > Torvalds" , "Catalin Marinas" , "Waiman Long" > , linux-arch@vger.kernel.org, "Jon Masters" , "Borislav Petkov" , > "Andy Lutomirski" , "Thomas Gleixner" , linux-arm-kernel@lists.infradead.org, > "Greg Kroah-Hartman" , linux-kernel@vger.kernel.org, "Tyler Hicks" , > "Martin Schwidefsky" , linuxppc-dev@lists.ozlabs.org > Sent: Thursday, April 4, 2019 2:49:05 PM > Subject: Re: [PATCH RFC 3/5] powerpc/speculation: Add support for 'cpu_spec_mitigations=' cmdline options > On Thu, 4 Apr 2019, Josh Poimboeuf wrote: > >> Configure powerpc CPU runtime speculation bug mitigations in accordance >> with the 'cpu_spec_mitigations=' cmdline options. This affects >> Meltdown, Spectre v1, Spectre v2, and Speculative Store Bypass. > [ ... snip ... ] >> - if (!no_nospec) >> + if (!no_nospec && cpu_spec_mitigations != CPU_SPEC_MITIGATIONS_OFF) > > '!no_nospec' is something that I am sure will come back to hunt me in my > bad dreams. > > But that's been there already, and fixing it is out of scope of this > patch. Other than that, as discussed previously -- I really like this new > global option. Feel free to add > > Reviewed-by: Jiri Kosina > > for the whole set. > > Thanks, > > -- > Jiri Kosina > SUSE Labs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.rptsys.com ([23.155.224.45]:4802 "EHLO mail.rptsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729497AbfDDUJt (ORCPT ); Thu, 4 Apr 2019 16:09:49 -0400 Date: Thu, 4 Apr 2019 15:01:04 -0500 (CDT) From: Timothy Pearson Message-ID: <401506569.4710878.1554408064001.JavaMail.zimbra@raptorengineeringinc.com> In-Reply-To: References: <91b92d8182d2f114d92c95689fcd4bb1a8dda1b0.1554396090.git.jpoimboe@redhat.com> Subject: Re: [PATCH RFC 3/5] powerpc/speculation: Add support for 'cpu_spec_mitigations=' cmdline options MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Jiri Kosina Cc: Josh Poimboeuf , Peter Zijlstra , Heiko Carstens , Paul Mackerras , "H . Peter Anvin" , Ingo Molnar , Andrea Arcangeli , linux-s390@vger.kernel.org, x86@kernel.org, Will Deacon , Linus Torvalds , Catalin Marinas , Waiman Long , linux-arch@vger.kernel.org, Jon Masters , Borislav Petkov , Andy Lutomirski , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Tyler Hicks , Martin Schwidefsky , linuxppc-dev@lists.ozlabs.org Message-ID: <20190404200104.INe2nbO9Bg__dm-H_nSr2d4XkjWKVig0XnWHSYky-mk@z> Will be joining in ~ 5 mins. Getting Chromium set up here. ----- Original Message ----- > From: "Jiri Kosina" > To: "Josh Poimboeuf" > Cc: "Peter Zijlstra" , "Heiko Carstens" , "Paul Mackerras" > , "H . Peter Anvin" , "Ingo Molnar" , "Andrea Arcangeli" > , linux-s390@vger.kernel.org, x86@kernel.org, "Will Deacon" , "Linus > Torvalds" , "Catalin Marinas" , "Waiman Long" > , linux-arch@vger.kernel.org, "Jon Masters" , "Borislav Petkov" , > "Andy Lutomirski" , "Thomas Gleixner" , linux-arm-kernel@lists.infradead.org, > "Greg Kroah-Hartman" , linux-kernel@vger.kernel.org, "Tyler Hicks" , > "Martin Schwidefsky" , linuxppc-dev@lists.ozlabs.org > Sent: Thursday, April 4, 2019 2:49:05 PM > Subject: Re: [PATCH RFC 3/5] powerpc/speculation: Add support for 'cpu_spec_mitigations=' cmdline options > On Thu, 4 Apr 2019, Josh Poimboeuf wrote: > >> Configure powerpc CPU runtime speculation bug mitigations in accordance >> with the 'cpu_spec_mitigations=' cmdline options. This affects >> Meltdown, Spectre v1, Spectre v2, and Speculative Store Bypass. > [ ... snip ... ] >> - if (!no_nospec) >> + if (!no_nospec && cpu_spec_mitigations != CPU_SPEC_MITIGATIONS_OFF) > > '!no_nospec' is something that I am sure will come back to hunt me in my > bad dreams. > > But that's been there already, and fixing it is out of scope of this > patch. Other than that, as discussed previously -- I really like this new > global option. Feel free to add > > Reviewed-by: Jiri Kosina > > for the whole set. > > Thanks, > > -- > Jiri Kosina > SUSE Labs