From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [RFC6 PATCH v6 00/21] ILP32 for ARM64 Date: Wed, 18 May 2016 00:45:51 +0200 Message-ID: <4095406.jADDlVRiDg@wuerfel> References: <1459894127-17698-1-git-send-email-ynorov@caviumnetworks.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Andreas Schwab Cc: Joseph Myers , Szabolcs Nagy , Yury Norov , catalin.marinas@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, nd@arm.com, linux-arch@vger.kernel.org, linux-s390@vger.kernel.org, pinskia@gmail.com, Prasun.Kapoor@caviumnetworks.com, broonie@kernel.org, linux-doc@vger.kernel.org, heiko.carstens@de.ibm.com, agraf@suse.de, klimov.linux@gmail.com, bamvor.zhangjian@huawei.com, schwidefsky@de.ibm.com, Nathan_Lynch@mentor.com, christoph.muellner@theobroma-systems.com, GNU C Library List-Id: linux-arch.vger.kernel.org On Tuesday 17 May 2016 18:02:36 Andreas Schwab wrote: > Joseph Myers writes: > > > On Tue, 17 May 2016, Arnd Bergmann wrote: > > > >> I think it has become easier to override now and we just need to > >> update sysdeps/unix/sysv/linux/generic/bits/typesizes.h to set > >> > >> #define __INO64_T_TYPE __UQUAD_TYPE > >> #define __OFF64_T_TYPE __UQUAD_TYPE > >> #define __OFF_T_MATCHES_OFF64_T 1 > >> #define __INO_T_MATCHES_INO64_T 1 > >> > >> for new architectures (obviously not the ones that already use the > >> 32-bit types). I haven't tries this, so there may be other things > >> that are required. > > > > I think more than that would be needed to get struct stat to match and get > > things aliased for that (which is presumably desirable). > > Looking at sysdeps/unix/sysv/linux/generic/bits/stat.h, there is at > least blkcnt_t that differs between stat and stat64. And you probably > want to alias statfs and statfs64 as well, ie. fs{blk,fil}cnt_t. Makes sense. Indeed that is a bit more work than I hoped, in particular if we have to audit the uses of __WORDSIZE as well. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.kundenserver.de ([212.227.126.135]:49601 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750792AbcEQWqw (ORCPT ); Tue, 17 May 2016 18:46:52 -0400 From: Arnd Bergmann Subject: Re: [RFC6 PATCH v6 00/21] ILP32 for ARM64 Date: Wed, 18 May 2016 00:45:51 +0200 Message-ID: <4095406.jADDlVRiDg@wuerfel> In-Reply-To: References: <1459894127-17698-1-git-send-email-ynorov@caviumnetworks.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-arch-owner@vger.kernel.org List-ID: To: Andreas Schwab Cc: Joseph Myers , Szabolcs Nagy , Yury Norov , catalin.marinas@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, nd@arm.com, linux-arch@vger.kernel.org, linux-s390@vger.kernel.org, pinskia@gmail.com, Prasun.Kapoor@caviumnetworks.com, broonie@kernel.org, linux-doc@vger.kernel.org, heiko.carstens@de.ibm.com, agraf@suse.de, klimov.linux@gmail.com, bamvor.zhangjian@huawei.com, schwidefsky@de.ibm.com, Nathan_Lynch@mentor.com, christoph.muellner@theobroma-systems.com, GNU C Library Message-ID: <20160517224551.czZd7-uDQeK7XRXPv2MuZ0u3HvUU_HRoVFXiUHP5F_E@z> On Tuesday 17 May 2016 18:02:36 Andreas Schwab wrote: > Joseph Myers writes: > > > On Tue, 17 May 2016, Arnd Bergmann wrote: > > > >> I think it has become easier to override now and we just need to > >> update sysdeps/unix/sysv/linux/generic/bits/typesizes.h to set > >> > >> #define __INO64_T_TYPE __UQUAD_TYPE > >> #define __OFF64_T_TYPE __UQUAD_TYPE > >> #define __OFF_T_MATCHES_OFF64_T 1 > >> #define __INO_T_MATCHES_INO64_T 1 > >> > >> for new architectures (obviously not the ones that already use the > >> 32-bit types). I haven't tries this, so there may be other things > >> that are required. > > > > I think more than that would be needed to get struct stat to match and get > > things aliased for that (which is presumably desirable). > > Looking at sysdeps/unix/sysv/linux/generic/bits/stat.h, there is at > least blkcnt_t that differs between stat and stat64. And you probably > want to alias statfs and statfs64 as well, ie. fs{blk,fil}cnt_t. Makes sense. Indeed that is a bit more work than I hoped, in particular if we have to audit the uses of __WORDSIZE as well. Arnd